* [PATCH net-next] gve: Remove unused declaration gve_rx_alloc_rings()
@ 2024-08-16 10:19 Yue Haibing
2024-08-16 16:45 ` Simon Horman
2024-08-20 1:00 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 4+ messages in thread
From: Yue Haibing @ 2024-08-16 10:19 UTC (permalink / raw)
To: jeroendb, pkaligineedi, shailend, davem, edumazet, kuba, pabeni,
willemb, hramamurthy
Cc: netdev, linux-kernel, yuehaibing
Commit f13697cc7a19 ("gve: Switch to config-aware queue allocation")
convert this function to gve_rx_alloc_rings_gqi().
Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
drivers/net/ethernet/google/gve/gve.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/google/gve/gve.h b/drivers/net/ethernet/google/gve/gve.h
index 09a85ed59143..301fa1ea4f51 100644
--- a/drivers/net/ethernet/google/gve/gve.h
+++ b/drivers/net/ethernet/google/gve/gve.h
@@ -1153,7 +1153,6 @@ int gve_rx_alloc_ring_gqi(struct gve_priv *priv,
int idx);
void gve_rx_free_ring_gqi(struct gve_priv *priv, struct gve_rx_ring *rx,
struct gve_rx_alloc_rings_cfg *cfg);
-int gve_rx_alloc_rings(struct gve_priv *priv);
int gve_rx_alloc_rings_gqi(struct gve_priv *priv,
struct gve_rx_alloc_rings_cfg *cfg);
void gve_rx_free_rings_gqi(struct gve_priv *priv,
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] gve: Remove unused declaration gve_rx_alloc_rings()
2024-08-16 10:19 [PATCH net-next] gve: Remove unused declaration gve_rx_alloc_rings() Yue Haibing
@ 2024-08-16 16:45 ` Simon Horman
2024-08-17 6:15 ` Yue Haibing
2024-08-20 1:00 ` patchwork-bot+netdevbpf
1 sibling, 1 reply; 4+ messages in thread
From: Simon Horman @ 2024-08-16 16:45 UTC (permalink / raw)
To: Yue Haibing
Cc: jeroendb, pkaligineedi, shailend, davem, edumazet, kuba, pabeni,
willemb, hramamurthy, netdev, linux-kernel
On Fri, Aug 16, 2024 at 06:19:06PM +0800, Yue Haibing wrote:
> Commit f13697cc7a19 ("gve: Switch to config-aware queue allocation")
> convert this function to gve_rx_alloc_rings_gqi().
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
Reviewed-by: Simon Horman <horms@kernel.org>
In future, please consider grouping similar changes, say up to 10,
in a patchset.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] gve: Remove unused declaration gve_rx_alloc_rings()
2024-08-16 16:45 ` Simon Horman
@ 2024-08-17 6:15 ` Yue Haibing
0 siblings, 0 replies; 4+ messages in thread
From: Yue Haibing @ 2024-08-17 6:15 UTC (permalink / raw)
To: Simon Horman
Cc: jeroendb, pkaligineedi, shailend, davem, edumazet, kuba, pabeni,
willemb, hramamurthy, netdev, linux-kernel
On 2024/8/17 0:45, Simon Horman wrote:
> On Fri, Aug 16, 2024 at 06:19:06PM +0800, Yue Haibing wrote:
>> Commit f13697cc7a19 ("gve: Switch to config-aware queue allocation")
>> convert this function to gve_rx_alloc_rings_gqi().
>>
>> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
>
> Reviewed-by: Simon Horman <horms@kernel.org>
>
> In future, please consider grouping similar changes, say up to 10,
> in a patchset.
ok, thanks for your review.
> .
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] gve: Remove unused declaration gve_rx_alloc_rings()
2024-08-16 10:19 [PATCH net-next] gve: Remove unused declaration gve_rx_alloc_rings() Yue Haibing
2024-08-16 16:45 ` Simon Horman
@ 2024-08-20 1:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-08-20 1:00 UTC (permalink / raw)
To: Yue Haibing
Cc: jeroendb, pkaligineedi, shailend, davem, edumazet, kuba, pabeni,
willemb, hramamurthy, netdev, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 16 Aug 2024 18:19:06 +0800 you wrote:
> Commit f13697cc7a19 ("gve: Switch to config-aware queue allocation")
> convert this function to gve_rx_alloc_rings_gqi().
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
> drivers/net/ethernet/google/gve/gve.h | 1 -
> 1 file changed, 1 deletion(-)
Here is the summary with links:
- [net-next] gve: Remove unused declaration gve_rx_alloc_rings()
https://git.kernel.org/netdev/net-next/c/359c5eb0f736
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-08-20 1:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-16 10:19 [PATCH net-next] gve: Remove unused declaration gve_rx_alloc_rings() Yue Haibing
2024-08-16 16:45 ` Simon Horman
2024-08-17 6:15 ` Yue Haibing
2024-08-20 1:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).