From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7DB078C7D for ; Fri, 16 Aug 2024 17:18:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723828701; cv=none; b=RYc3RuEYUDHVIYpPpFwuHTrOEUmPpKVMnQBw06LekT7dYnFNra1TuNG1zJIdX0gnNBO+VhvdFqdpifH6AEqMw04RSGhotAFb7gFEQMhe0G4xm/QeSx7HOgEGRQw1R+Wm4QG2dsCbbvgq4iU6SReOHh28ova9TulHJHR7LO2TkFo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723828701; c=relaxed/simple; bh=7F1XINyfaaPwmpH1kZ/VqFh7DlR6Lb62y1QJvY5BOv0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dCMGYgI0OcdnplxyyZr0qf5YsxN2rS/Y2kLrUW7ScGCnvzyw9EGX8EhJF541iXVQVn+MDXgar6GUI6LL8FbNCOOAkunbN9fJJtgRRVWJdYFOLS6+Bc8D6Kttszn3Rvpsv66Do3YPHLiNjjLHbRVV9P3tiKyt+2SR0DkfF0SbUkg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cXzUtzvs; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cXzUtzvs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA2E0C32782; Fri, 16 Aug 2024 17:18:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723828700; bh=7F1XINyfaaPwmpH1kZ/VqFh7DlR6Lb62y1QJvY5BOv0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cXzUtzvsCiEC6/KOxahf79AMEyZuBREqaIa7hZTHypE4XDhaU5g1Dk8Nf85KHiTeo FzfW2+kcxcIUGHSTs7J5DUYBU1zJYahxUKLAr1Dfi3gc0B9fbUrB5XhOEyWpsWk26R pbiEGdBS9W1dL/jbGKVIK2UWbjI5SvVU3GruqxqAroSE1VnPdT96Q6djfvjrEYrd/u EJKhJAtpnG68MzozJzTIPlJUxTi0HiNbM4imQ+bnQMsLZWOKq5lk2DVikOADii9Scn BQmLbpvuGXFVyAmEASwLArRqpZ+00YeIdqyyecb7BT9BJcMhJMO0u1AagW2GYQ6v3x dGZyk44CwNSjA== Date: Fri, 16 Aug 2024 18:18:16 +0100 From: Simon Horman To: Jeremy Kerr Cc: Matt Johnston , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Dan Carpenter , netdev@vger.kernel.org Subject: Re: [PATCH net-next] net: mctp: test: Use correct skb for route input check Message-ID: <20240816171816.GE632411@kernel.org> References: <20240816-mctp-kunit-skb-fix-v1-1-3c367ac89c27@codeconstruct.com.au> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240816-mctp-kunit-skb-fix-v1-1-3c367ac89c27@codeconstruct.com.au> On Fri, Aug 16, 2024 at 06:29:17PM +0800, Jeremy Kerr wrote: > In the MCTP route input test, we're routing one skb, then (when delivery > is expected) checking the resulting routed skb. > > However, we're currently checking the original skb length, rather than > the routed skb. Check the routed skb instead; the original will have > been freed at this point. > > Fixes: 8892c0490779 ("mctp: Add route input to socket tests") > Reported-by: Dan Carpenter > Closes: https://lore.kernel.org/kernel-janitors/4ad204f0-94cf-46c5-bdab-49592addf315@kili.mountain/ > Signed-off-by: Jeremy Kerr Reviewed-by: Simon Horman