* [PATCH] cxgb4: add forgotten u64 ivlan cast before shift
@ 2024-08-16 8:22 Nikolay Kuratov
2024-08-16 17:20 ` Simon Horman
0 siblings, 1 reply; 2+ messages in thread
From: Nikolay Kuratov @ 2024-08-16 8:22 UTC (permalink / raw)
To: linux-kernel
Cc: netdev, stable, lvc-project, Kumar Sanghvi, Potnuri Bharat Teja,
Rahul Lakkireddy, Ganesh Goudar, David S. Miller, Nikolay Kuratov
It is done everywhere in cxgb4 code, e.g. in is_filter_exact_match()
There is no reason it should not be done here
Found by Linux Verification Center (linuxtesting.org) with SVACE
Signed-off-by: Nikolay Kuratov <kniv@yandex-team.ru>
Cc: stable@vger.kernel.org
Fixes: 12b276fbf6e0 ("cxgb4: add support to create hash filters")
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
index 786ceae34488..e417ff0ea06c 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
@@ -1244,7 +1244,7 @@ static u64 hash_filter_ntuple(struct ch_filter_specification *fs,
* in the Compressed Filter Tuple.
*/
if (tp->vlan_shift >= 0 && fs->mask.ivlan)
- ntuple |= (FT_VLAN_VLD_F | fs->val.ivlan) << tp->vlan_shift;
+ ntuple |= (u64)(FT_VLAN_VLD_F | fs->val.ivlan) << tp->vlan_shift;
if (tp->port_shift >= 0 && fs->mask.iport)
ntuple |= (u64)fs->val.iport << tp->port_shift;
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] cxgb4: add forgotten u64 ivlan cast before shift
2024-08-16 8:22 [PATCH] cxgb4: add forgotten u64 ivlan cast before shift Nikolay Kuratov
@ 2024-08-16 17:20 ` Simon Horman
0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2024-08-16 17:20 UTC (permalink / raw)
To: Nikolay Kuratov
Cc: linux-kernel, netdev, stable, lvc-project, Kumar Sanghvi,
Potnuri Bharat Teja, Rahul Lakkireddy, Ganesh Goudar,
David S. Miller
On Fri, Aug 16, 2024 at 11:22:39AM +0300, Nikolay Kuratov wrote:
> It is done everywhere in cxgb4 code, e.g. in is_filter_exact_match()
> There is no reason it should not be done here
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE
>
> Signed-off-by: Nikolay Kuratov <kniv@yandex-team.ru>
> Cc: stable@vger.kernel.org
> Fixes: 12b276fbf6e0 ("cxgb4: add support to create hash filters")
> ---
> drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
> index 786ceae34488..e417ff0ea06c 100644
> --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
> +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
> @@ -1244,7 +1244,7 @@ static u64 hash_filter_ntuple(struct ch_filter_specification *fs,
> * in the Compressed Filter Tuple.
> */
> if (tp->vlan_shift >= 0 && fs->mask.ivlan)
> - ntuple |= (FT_VLAN_VLD_F | fs->val.ivlan) << tp->vlan_shift;
> + ntuple |= (u64)(FT_VLAN_VLD_F | fs->val.ivlan) << tp->vlan_shift;
LGTM, but please line wrap this so that it doesn't extend
beyond 80 columns wide (as is the case elsewhere in this function).
>
> if (tp->port_shift >= 0 && fs->mask.iport)
> ntuple |= (u64)fs->val.iport << tp->port_shift;
--
pw-bot: cr
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-16 17:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-16 8:22 [PATCH] cxgb4: add forgotten u64 ivlan cast before shift Nikolay Kuratov
2024-08-16 17:20 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).