* [PATCH net-next 1/2] tty: Add N_TASHTALK line discipline for TashTalk Localtalk serial driver
@ 2024-08-17 9:32 Rodolfo Zitellini
2024-08-17 11:03 ` Greg Kroah-Hartman
2024-08-19 5:16 ` Jiri Slaby
0 siblings, 2 replies; 5+ messages in thread
From: Rodolfo Zitellini @ 2024-08-17 9:32 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Jonathan Corbet, Greg Kroah-Hartman, Jiri Slaby
Cc: netdev, linux-doc, linux-serial, linux-kernel, Arnd Bergmann,
Doug Brown, Rodolfo Zitellini
This is the patch for the line discipline
Signed-off-by: Rodolfo Zitellini <rwz@xhero.org>
---
include/uapi/linux/tty.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/uapi/linux/tty.h b/include/uapi/linux/tty.h
index 68aeae2addec..bac4c0af67e6 100644
--- a/include/uapi/linux/tty.h
+++ b/include/uapi/linux/tty.h
@@ -39,8 +39,9 @@
#define N_MCTP 28 /* MCTP-over-serial */
#define N_DEVELOPMENT 29 /* Manual out-of-tree testing */
#define N_CAN327 30 /* ELM327 based OBD-II interfaces */
+#define N_TASHTALK 31 /* TashTalk LocalTalk driver */
/* Always the newest line discipline + 1 */
-#define NR_LDISCS 31
+#define NR_LDISCS 32
#endif /* _UAPI_LINUX_TTY_H */
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH net-next 1/2] tty: Add N_TASHTALK line discipline for TashTalk Localtalk serial driver
2024-08-17 9:32 [PATCH net-next 1/2] tty: Add N_TASHTALK line discipline for TashTalk Localtalk serial driver Rodolfo Zitellini
@ 2024-08-17 11:03 ` Greg Kroah-Hartman
2024-08-17 13:15 ` Rodolfo Zitellini
2024-08-19 5:16 ` Jiri Slaby
1 sibling, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2024-08-17 11:03 UTC (permalink / raw)
To: Rodolfo Zitellini
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Jonathan Corbet, Jiri Slaby, netdev, linux-doc, linux-serial,
linux-kernel, Arnd Bergmann, Doug Brown
On Sat, Aug 17, 2024 at 11:32:58AM +0200, Rodolfo Zitellini wrote:
> This is the patch for the line discipline
Please look at the kernel documentation for best how to write changelog
texts. This needs a bit of work.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next 1/2] tty: Add N_TASHTALK line discipline for TashTalk Localtalk serial driver
2024-08-17 11:03 ` Greg Kroah-Hartman
@ 2024-08-17 13:15 ` Rodolfo Zitellini
0 siblings, 0 replies; 5+ messages in thread
From: Rodolfo Zitellini @ 2024-08-17 13:15 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Jonathan Corbet, Jiri Slaby, netdev, linux-doc, linux-serial,
linux-kernel, Arnd Bergmann, Doug Brown
> Please look at the kernel documentation for best how to write changelog
> texts. This needs a bit of work.
Hi Greg,
thanks for your review! I will absolutely improve the commit messages on both patches in the next version of the series.
Kind Regards,
Rodolfo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next 1/2] tty: Add N_TASHTALK line discipline for TashTalk Localtalk serial driver
2024-08-17 9:32 [PATCH net-next 1/2] tty: Add N_TASHTALK line discipline for TashTalk Localtalk serial driver Rodolfo Zitellini
2024-08-17 11:03 ` Greg Kroah-Hartman
@ 2024-08-19 5:16 ` Jiri Slaby
2024-08-19 5:32 ` Jiri Slaby
1 sibling, 1 reply; 5+ messages in thread
From: Jiri Slaby @ 2024-08-19 5:16 UTC (permalink / raw)
To: Rodolfo Zitellini, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Jonathan Corbet, Greg Kroah-Hartman
Cc: netdev, linux-doc, linux-serial, linux-kernel, Arnd Bergmann,
Doug Brown
Where is 2/2?
It cannot be seen:
https://lore.kernel.org/all/20240817093258.9220-1-rwz@xhero.org/#r
On 17. 08. 24, 11:32, Rodolfo Zitellini wrote:
> This is the patch for the line discipline
>
> Signed-off-by: Rodolfo Zitellini <rwz@xhero.org>
>
> ---
> include/uapi/linux/tty.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/tty.h b/include/uapi/linux/tty.h
> index 68aeae2addec..bac4c0af67e6 100644
> --- a/include/uapi/linux/tty.h
> +++ b/include/uapi/linux/tty.h
> @@ -39,8 +39,9 @@
> #define N_MCTP 28 /* MCTP-over-serial */
> #define N_DEVELOPMENT 29 /* Manual out-of-tree testing */
> #define N_CAN327 30 /* ELM327 based OBD-II interfaces */
> +#define N_TASHTALK 31 /* TashTalk LocalTalk driver */
>
> /* Always the newest line discipline + 1 */
> -#define NR_LDISCS 31
> +#define NR_LDISCS 32
>
> #endif /* _UAPI_LINUX_TTY_H */
--
js
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next 1/2] tty: Add N_TASHTALK line discipline for TashTalk Localtalk serial driver
2024-08-19 5:16 ` Jiri Slaby
@ 2024-08-19 5:32 ` Jiri Slaby
0 siblings, 0 replies; 5+ messages in thread
From: Jiri Slaby @ 2024-08-19 5:32 UTC (permalink / raw)
To: Rodolfo Zitellini, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Jonathan Corbet, Greg Kroah-Hartman
Cc: netdev, linux-doc, linux-serial, linux-kernel, Arnd Bergmann,
Doug Brown
On 19. 08. 24, 7:16, Jiri Slaby wrote:
> Where is 2/2?
>
> It cannot be seen:
> https://lore.kernel.org/all/20240817093258.9220-1-rwz@xhero.org/#r
It's a separate <20240817093316.9239-1-rwz@xhero.org>. Please fix
threading when sending next time.
--
js
suse labs
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-08-19 5:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-17 9:32 [PATCH net-next 1/2] tty: Add N_TASHTALK line discipline for TashTalk Localtalk serial driver Rodolfo Zitellini
2024-08-17 11:03 ` Greg Kroah-Hartman
2024-08-17 13:15 ` Rodolfo Zitellini
2024-08-19 5:16 ` Jiri Slaby
2024-08-19 5:32 ` Jiri Slaby
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).