From: Jakub Kicinski <kuba@kernel.org>
To: David Thompson <davthompson@nvidia.com>
Cc: Benjamin Poirier <benjamin.poirier@gmail.com>,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
andriy.shevchenko@linux.intel.com,
u.kleine-koenig@pengutronix.de, asmaa@nvidia.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v1] mlxbf_gige: disable port during stop()
Date: Mon, 19 Aug 2024 17:47:22 -0700 [thread overview]
Message-ID: <20240819174722.7701fa3c@kernel.org> (raw)
In-Reply-To: <ZsOVEMvzAXfaRiEY@f4>
On Mon, 19 Aug 2024 14:55:12 -0400 Benjamin Poirier wrote:
> Is this memory barrier paired with another one?
+1
You probably want synchronize_irq() here?
You should explain in the cover letter, the mb() seems to not be
mentioned.
--
pw-bot: cr
next prev parent reply other threads:[~2024-08-20 0:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-16 20:48 [PATCH net v1] mlxbf_gige: disable port during stop() David Thompson
2024-08-19 18:55 ` Benjamin Poirier
2024-08-20 0:47 ` Jakub Kicinski [this message]
2024-08-28 21:37 ` David Thompson
2024-08-28 22:55 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240819174722.7701fa3c@kernel.org \
--to=kuba@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=asmaa@nvidia.com \
--cc=benjamin.poirier@gmail.com \
--cc=davem@davemloft.net \
--cc=davthompson@nvidia.com \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).