* [PATCH net] netpoll: do not export netpoll_poll_[disable|enable]()
@ 2024-08-20 16:20 Eric Dumazet
2024-08-21 13:48 ` Simon Horman
2024-08-22 0:40 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Eric Dumazet @ 2024-08-20 16:20 UTC (permalink / raw)
To: David S . Miller, Jakub Kicinski, Paolo Abeni
Cc: netdev, eric.dumazet, Eric Dumazet
netpoll_poll_disable() and netpoll_poll_enable() are only used
from core networking code, there is no need to export them.
Signed-off-by: Eric Dumazet <edumazet@google.com>
---
net/core/netpoll.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/core/netpoll.c b/net/core/netpoll.c
index a58ea724790ce772004f4053afab0f7da458aff1..cff1f89719b6d6ba66b4687db03596d8362b6571 100644
--- a/net/core/netpoll.c
+++ b/net/core/netpoll.c
@@ -228,7 +228,6 @@ void netpoll_poll_disable(struct net_device *dev)
down(&ni->dev_lock);
srcu_read_unlock(&netpoll_srcu, idx);
}
-EXPORT_SYMBOL(netpoll_poll_disable);
void netpoll_poll_enable(struct net_device *dev)
{
@@ -239,7 +238,6 @@ void netpoll_poll_enable(struct net_device *dev)
up(&ni->dev_lock);
rcu_read_unlock();
}
-EXPORT_SYMBOL(netpoll_poll_enable);
static void refill_skbs(void)
{
--
2.46.0.184.g6999bdac58-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] netpoll: do not export netpoll_poll_[disable|enable]()
2024-08-20 16:20 [PATCH net] netpoll: do not export netpoll_poll_[disable|enable]() Eric Dumazet
@ 2024-08-21 13:48 ` Simon Horman
2024-08-22 0:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2024-08-21 13:48 UTC (permalink / raw)
To: Eric Dumazet
Cc: David S. Miller, Jakub Kicinski, Paolo Abeni, netdev,
eric.dumazet
On Tue, Aug 20, 2024 at 04:20:53PM +0000, Eric Dumazet wrote:
> netpoll_poll_disable() and netpoll_poll_enable() are only used
> from core networking code, there is no need to export them.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] netpoll: do not export netpoll_poll_[disable|enable]()
2024-08-20 16:20 [PATCH net] netpoll: do not export netpoll_poll_[disable|enable]() Eric Dumazet
2024-08-21 13:48 ` Simon Horman
@ 2024-08-22 0:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-08-22 0:40 UTC (permalink / raw)
To: Eric Dumazet; +Cc: davem, kuba, pabeni, netdev, eric.dumazet
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 20 Aug 2024 16:20:53 +0000 you wrote:
> netpoll_poll_disable() and netpoll_poll_enable() are only used
> from core networking code, there is no need to export them.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> ---
> net/core/netpoll.c | 2 --
> 1 file changed, 2 deletions(-)
Here is the summary with links:
- [net] netpoll: do not export netpoll_poll_[disable|enable]()
https://git.kernel.org/netdev/net/c/007d4271a5f1
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-22 0:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-20 16:20 [PATCH net] netpoll: do not export netpoll_poll_[disable|enable]() Eric Dumazet
2024-08-21 13:48 ` Simon Horman
2024-08-22 0:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).