netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net] selftests: mlxsw: ethtool_lanes: Source ethtool lib from correct path
@ 2024-08-20 10:53 Petr Machata
  2024-08-21 12:28 ` Simon Horman
  2024-08-22  0:30 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Petr Machata @ 2024-08-20 10:53 UTC (permalink / raw)
  To: Shuah Khan, linux-kselftest, netdev
  Cc: Jakub Kicinski, mlxsw, Ido Schimmel, Petr Machata

From: Ido Schimmel <idosch@nvidia.com>

Source the ethtool library from the correct path and avoid the following
error:

./ethtool_lanes.sh: line 14: ./../../../net/forwarding/ethtool_lib.sh: No such file or directory

Fixes: 40d269c000bd ("selftests: forwarding: Move several selftests")
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Signed-off-by: Petr Machata <petrm@nvidia.com>
---
 tools/testing/selftests/drivers/net/mlxsw/ethtool_lanes.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/drivers/net/mlxsw/ethtool_lanes.sh b/tools/testing/selftests/drivers/net/mlxsw/ethtool_lanes.sh
index 877cd6df94a1..fe905a7f34b3 100755
--- a/tools/testing/selftests/drivers/net/mlxsw/ethtool_lanes.sh
+++ b/tools/testing/selftests/drivers/net/mlxsw/ethtool_lanes.sh
@@ -2,6 +2,7 @@
 # SPDX-License-Identifier: GPL-2.0
 
 lib_dir=$(dirname $0)/../../../net/forwarding
+ethtool_lib_dir=$(dirname $0)/../hw
 
 ALL_TESTS="
 	autoneg
@@ -11,7 +12,7 @@ ALL_TESTS="
 NUM_NETIFS=2
 : ${TIMEOUT:=30000} # ms
 source $lib_dir/lib.sh
-source $lib_dir/ethtool_lib.sh
+source $ethtool_lib_dir/ethtool_lib.sh
 
 setup_prepare()
 {
-- 
2.45.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net] selftests: mlxsw: ethtool_lanes: Source ethtool lib from correct path
  2024-08-20 10:53 [PATCH net] selftests: mlxsw: ethtool_lanes: Source ethtool lib from correct path Petr Machata
@ 2024-08-21 12:28 ` Simon Horman
  2024-08-22  0:30 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2024-08-21 12:28 UTC (permalink / raw)
  To: Petr Machata
  Cc: Shuah Khan, linux-kselftest, netdev, Jakub Kicinski, mlxsw,
	Ido Schimmel

On Tue, Aug 20, 2024 at 12:53:47PM +0200, Petr Machata wrote:
> From: Ido Schimmel <idosch@nvidia.com>
> 
> Source the ethtool library from the correct path and avoid the following
> error:
> 
> ./ethtool_lanes.sh: line 14: ./../../../net/forwarding/ethtool_lib.sh: No such file or directory
> 
> Fixes: 40d269c000bd ("selftests: forwarding: Move several selftests")
> Signed-off-by: Ido Schimmel <idosch@nvidia.com>
> Signed-off-by: Petr Machata <petrm@nvidia.com>

Reviewed-by: Simon Horman <horms@kernel.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net] selftests: mlxsw: ethtool_lanes: Source ethtool lib from correct path
  2024-08-20 10:53 [PATCH net] selftests: mlxsw: ethtool_lanes: Source ethtool lib from correct path Petr Machata
  2024-08-21 12:28 ` Simon Horman
@ 2024-08-22  0:30 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-08-22  0:30 UTC (permalink / raw)
  To: Petr Machata; +Cc: shuah, linux-kselftest, netdev, kuba, mlxsw, idosch

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 20 Aug 2024 12:53:47 +0200 you wrote:
> From: Ido Schimmel <idosch@nvidia.com>
> 
> Source the ethtool library from the correct path and avoid the following
> error:
> 
> ./ethtool_lanes.sh: line 14: ./../../../net/forwarding/ethtool_lib.sh: No such file or directory
> 
> [...]

Here is the summary with links:
  - [net] selftests: mlxsw: ethtool_lanes: Source ethtool lib from correct path
    https://git.kernel.org/netdev/net/c/f8669d7b5f5d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-08-22  0:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-20 10:53 [PATCH net] selftests: mlxsw: ethtool_lanes: Source ethtool lib from correct path Petr Machata
2024-08-21 12:28 ` Simon Horman
2024-08-22  0:30 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).