From: Simon Horman <horms@kernel.org>
To: Bharat Bhushan <bbhushan2@marvell.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
sgoutham@marvell.com, gakula@marvell.com, sbhatta@marvell.com,
hkelam@marvell.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, jerinj@marvell.com,
lcherian@marvell.com, ndabilpuram@marvell.com
Subject: Re: [net PATCH v3] octeontx2-af: Fix CPT AF register offset calculation
Date: Wed, 21 Aug 2024 16:00:50 +0100 [thread overview]
Message-ID: <20240821150050.GB2164@kernel.org> (raw)
In-Reply-To: <20240821070558.1020101-1-bbhushan2@marvell.com>
On Wed, Aug 21, 2024 at 12:35:58PM +0530, Bharat Bhushan wrote:
> Some CPT AF registers are per LF and others are global. Translation
> of PF/VF local LF slot number to actual LF slot number is required
> only for accessing perf LF registers. CPT AF global registers access
> do not require any LF slot number. Also, there is no reason CPT
> PF/VF to know actual lf's register offset.
>
> Without this fix microcode loading will fail, VFs cannot be created
> and hardware is not usable.
>
> Fixes: bc35e28af789 ("octeontx2-af: replace cpt slot with lf id on reg write")
> Signed-off-by: Bharat Bhushan <bbhushan2@marvell.com>
> ---
> v3:
> - Updated patch description about what's broken without this fix
> - Added patch history
>
> v2: https://lore.kernel.org/netdev/20240819152744.GA543198@kernel.org/T/
> - Spelling fixes in patch description
>
> v1: https://lore.kernel.org/lkml/CAAeCc_nJtR2ryzoaXop8-bbw_0RGciZsniiUqS+NVMg7dHahiQ@mail.gmail.com/T/
> - Added "net" in patch subject prefix, missed in previous patch:
> https://lore.kernel.org/lkml/20240806070239.1541623-1-bbhushan2@marvell.com/
>
Thanks for the updates, and the information below the scissors ('---').
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-08-21 15:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-21 7:05 [net PATCH v3] octeontx2-af: Fix CPT AF register offset calculation Bharat Bhushan
2024-08-21 15:00 ` Simon Horman [this message]
2024-08-22 11:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240821150050.GB2164@kernel.org \
--to=horms@kernel.org \
--cc=bbhushan2@marvell.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=jerinj@marvell.com \
--cc=kuba@kernel.org \
--cc=lcherian@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ndabilpuram@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).