From: Jakub Kicinski <kuba@kernel.org>
To: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Cc: Alexandra Winter <wintera@linux.ibm.com>,
<netdev@vger.kernel.org>, David Miller <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>, <linux-s390@vger.kernel.org>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Thorsten Winkler <twinkler@linux.ibm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH net v2] s390/iucv: Fix vargs handling in iucv_alloc_device()
Date: Wed, 21 Aug 2024 17:34:46 -0700 [thread overview]
Message-ID: <20240821173446.6f515d26@kernel.org> (raw)
In-Reply-To: <5e5bb753-9d6b-4e6f-8b02-ffa2cae1a4f7@intel.com>
On Tue, 20 Aug 2024 13:51:06 +0200 Przemek Kitszel wrote:
> > + rc = dev_set_name(dev, buf);
>
> would be good to pass "%s" as fmt to dev_set_name()
Sounds like a good idea
--
pw-bot: cr
next prev parent reply other threads:[~2024-08-22 0:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-20 8:45 [PATCH net v2] s390/iucv: Fix vargs handling in iucv_alloc_device() Alexandra Winter
2024-08-20 11:51 ` Przemek Kitszel
2024-08-22 0:34 ` Jakub Kicinski [this message]
2024-08-24 3:12 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240821173446.6f515d26@kernel.org \
--to=kuba@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gor@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=hca@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=svens@linux.ibm.com \
--cc=twinkler@linux.ibm.com \
--cc=wintera@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).