From: Jakub Kicinski <kuba@kernel.org>
To: Xi Huang <xuiagnh@gmail.com>
Cc: madalin.bucur@nxp.com, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2] net: dpaa:reduce number of synchronize_net() calls
Date: Thu, 22 Aug 2024 08:12:16 -0700 [thread overview]
Message-ID: <20240822081216.78b3a0de@kernel.org> (raw)
In-Reply-To: <20240822072042.42750-1-xuiagnh@gmail.com>
On Thu, 22 Aug 2024 15:20:42 +0800 Xi Huang wrote:
> In the function dpaa_napi_del(), we execute the netif_napi_del()
> for each cpu, which is actually a high overhead operation
> because each call to netif_napi_del() contains a synchronize_net(),
> i.e. an RCU operation. In fact, it is only necessary to call
> __netif_napi_del and use synchronize_net() once outside of the loop.
> This change is similar to commit 2543a6000e593a ("gro_cells: reduce
> number of synchronize_net() calls") and commit 5198d545dba8ad (" net:
> remove napi_hash_del() from driver-facing API") 5198d545db.
>
> Signed-off-by: Xi Huang <xuiagnh@gmail.com>
> Reviewed-by: Eric Dumazet <edumazet@google.com>
You missed the part of Eric's response that told you to wait 24 hours:
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html
--
pv-bot: 24h
next prev parent reply other threads:[~2024-08-22 15:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 7:20 [PATCHv2] net: dpaa:reduce number of synchronize_net() calls Xi Huang
2024-08-22 15:12 ` Jakub Kicinski [this message]
2024-08-22 16:03 ` XI HUANG
2024-08-26 22:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240822081216.78b3a0de@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=madalin.bucur@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xuiagnh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).