From: Simon Horman <horms@kernel.org>
To: Yuesong Li <liyuesong@vivo.com>
Cc: mark.einon@gmail.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, opensource.kernel@vivo.com
Subject: Re: [PATCH v1] driver:net:et131x:Remove NULL check of list_entry()
Date: Thu, 22 Aug 2024 13:07:18 +0100 [thread overview]
Message-ID: <20240822120718.GN2164@kernel.org> (raw)
In-Reply-To: <20240822030535.1214176-1-liyuesong@vivo.com>
On Thu, Aug 22, 2024 at 11:05:35AM +0800, Yuesong Li wrote:
> list_entry() will never return a NULL pointer, thus remove the
> check.
>
> Signed-off-by: Yuesong Li <liyuesong@vivo.com>
Hi Yuesong Li,
Thanks for your patch.
Some minor points about process.
1. As a Networking patch, that is not a bug fix, it should
be explicitly targeted at net-next.
Subject: [PATCH net-next] ...
2. Looking at git history, it looks like 'et131x' would be an appropriate
prefix for this patch.
Subject: [PATCH net-next] et131x: ...
Please consider reading
https://docs.kernel.org/process/maintainer-netdev.html
And, please post a v2, addressing the above, and including Mark's tag,
after waiting 24h from the initial patch posting (as described in the link
above). Please do so as a new email thread.
FWIIW, the code change itself looks good to me.
...
--
pw-bot: changes-requested
prev parent reply other threads:[~2024-08-22 12:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 3:05 [PATCH v1] driver:net:et131x:Remove NULL check of list_entry() Yuesong Li
2024-08-22 11:03 ` Mark Einon
2024-08-22 12:07 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240822120718.GN2164@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liyuesong@vivo.com \
--cc=mark.einon@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).