netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Jianbo Liu <jianbol@nvidia.com>
Cc: Jay Vosburgh <jv@jvosburgh.net>,
	"liuhangbin@gmail.com" <liuhangbin@gmail.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	Leon Romanovsky <leonro@nvidia.com>,
	Gal Pressman <gal@nvidia.com>,
	"andy@greyhouse.net" <andy@greyhouse.net>,
	Tariq Toukan <tariqt@nvidia.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"pabeni@redhat.com" <pabeni@redhat.com>,
	"edumazet@google.com" <edumazet@google.com>,
	Saeed Mahameed <saeedm@nvidia.com>
Subject: Re: [PATCH net V5 3/3] bonding: change ipsec_lock from spin lock to mutex
Date: Thu, 22 Aug 2024 16:19:45 -0700	[thread overview]
Message-ID: <20240822161945.7b237a5d@kernel.org> (raw)
In-Reply-To: <02d8277b-e6fc-44d4-8c88-2eb42813cd22@nvidia.com>

On Thu, 22 Aug 2024 19:15:24 +0800 Jianbo Liu wrote:
> +       dev_hold(real_dev);

netdev_hold(), please, so that we can find the location of the
reference leak if a bug sneaks in.

  reply	other threads:[~2024-08-22 23:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-21  9:04 [PATCH net V5 0/3] Fixes for IPsec over bonding Jianbo Liu
2024-08-21  9:04 ` [PATCH net V5 1/3] bonding: implement xdo_dev_state_free and call it after deletion Jianbo Liu
2024-08-21  9:04 ` [PATCH net V5 2/3] bonding: extract the use of real_device into local variable Jianbo Liu
2024-08-21  9:04 ` [PATCH net V5 3/3] bonding: change ipsec_lock from spin lock to mutex Jianbo Liu
2024-08-21 16:00   ` Jay Vosburgh
2024-08-22  0:11     ` Jakub Kicinski
2024-08-22  2:07       ` Jianbo Liu
2024-08-22  1:53     ` Jianbo Liu
2024-08-22  6:05       ` Jay Vosburgh
2024-08-22 11:15         ` Jianbo Liu
2024-08-22 23:19           ` Jakub Kicinski [this message]
2024-08-23  0:17           ` Jay Vosburgh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240822161945.7b237a5d@kernel.org \
    --to=kuba@kernel.org \
    --cc=andy@greyhouse.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gal@nvidia.com \
    --cc=jianbol@nvidia.com \
    --cc=jv@jvosburgh.net \
    --cc=leonro@nvidia.com \
    --cc=liuhangbin@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=saeedm@nvidia.com \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).