From: Felix Fietkau <nbd@nbd.name>
To: netdev@vger.kernel.org, Roopa Prabhu <roopa@nvidia.com>,
Nikolay Aleksandrov <razor@blackwall.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: bridge@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH] net: bridge: fix switchdev host mdb entry updates
Date: Thu, 22 Aug 2024 18:38:35 +0200 [thread overview]
Message-ID: <20240822163836.67061-1-nbd@nbd.name> (raw)
When a mdb entry is removed, the bridge switchdev code can issue a
switchdev_port_obj_del call for a port that was not offloaded.
This leads to an imbalance in switchdev_port_obj_add/del calls, since
br_switchdev_mdb_replay has not been called for the port before.
This can lead to potential multicast forwarding issues and messages such as:
mt7915e 0000:01:00.0 wl1-ap0: Failed to del Host Multicast Database entry
(object id=3) with error: -ENOENT (-2).
Fix this issue by checking the port offload status when iterating over
lower devs.
Signed-off-by: Felix Fietkau <nbd@nbd.name>
---
net/bridge/br_switchdev.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/net/bridge/br_switchdev.c b/net/bridge/br_switchdev.c
index 7b41ee8740cb..3490c3968638 100644
--- a/net/bridge/br_switchdev.c
+++ b/net/bridge/br_switchdev.c
@@ -568,10 +568,18 @@ static void br_switchdev_host_mdb(struct net_device *dev,
struct net_bridge_mdb_entry *mp, int type)
{
struct net_device *lower_dev;
+ struct net_bridge_port *port;
struct list_head *iter;
- netdev_for_each_lower_dev(dev, lower_dev, iter)
+ rcu_read_lock();
+ netdev_for_each_lower_dev(dev, lower_dev, iter) {
+ port = br_port_get_rcu(lower_dev);
+ if (!port || !port->offload_count)
+ continue;
+
br_switchdev_host_mdb_one(dev, lower_dev, mp, type);
+ }
+ rcu_read_unlock();
}
static int
--
2.46.0
next reply other threads:[~2024-08-22 16:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 16:38 Felix Fietkau [this message]
2024-08-27 11:03 ` [PATCH] net: bridge: fix switchdev host mdb entry updates Paolo Abeni
2024-08-27 15:56 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240822163836.67061-1-nbd@nbd.name \
--to=nbd@nbd.name \
--cc=bridge@lists.linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox