* [PATCH net-next] selftests: forwarding: no_forwarding: Down ports on cleanup
@ 2024-08-23 16:25 Petr Machata
2024-08-23 17:42 ` Simon Horman
2024-08-27 20:00 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Petr Machata @ 2024-08-23 16:25 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
netdev
Cc: Vladimir Oltean, linux-kselftest, Shuah Khan, Petr Machata
This test neglects to put ports down on cleanup. Fix it.
Fixes: 476a4f05d9b8 ("selftests: forwarding: add a no_forwarding.sh test")
Signed-off-by: Petr Machata <petrm@nvidia.com>
---
tools/testing/selftests/net/forwarding/no_forwarding.sh | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/testing/selftests/net/forwarding/no_forwarding.sh b/tools/testing/selftests/net/forwarding/no_forwarding.sh
index af3b398d13f0..9e677aa64a06 100755
--- a/tools/testing/selftests/net/forwarding/no_forwarding.sh
+++ b/tools/testing/selftests/net/forwarding/no_forwarding.sh
@@ -233,6 +233,9 @@ cleanup()
{
pre_cleanup
+ ip link set dev $swp2 down
+ ip link set dev $swp1 down
+
h2_destroy
h1_destroy
--
2.45.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] selftests: forwarding: no_forwarding: Down ports on cleanup
2024-08-23 16:25 [PATCH net-next] selftests: forwarding: no_forwarding: Down ports on cleanup Petr Machata
@ 2024-08-23 17:42 ` Simon Horman
2024-08-27 20:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2024-08-23 17:42 UTC (permalink / raw)
To: Petr Machata
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
netdev, Vladimir Oltean, linux-kselftest, Shuah Khan
On Fri, Aug 23, 2024 at 06:25:37PM +0200, Petr Machata wrote:
> This test neglects to put ports down on cleanup. Fix it.
>
> Fixes: 476a4f05d9b8 ("selftests: forwarding: add a no_forwarding.sh test")
> Signed-off-by: Petr Machata <petrm@nvidia.com>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] selftests: forwarding: no_forwarding: Down ports on cleanup
2024-08-23 16:25 [PATCH net-next] selftests: forwarding: no_forwarding: Down ports on cleanup Petr Machata
2024-08-23 17:42 ` Simon Horman
@ 2024-08-27 20:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-08-27 20:00 UTC (permalink / raw)
To: Petr Machata
Cc: davem, edumazet, kuba, pabeni, netdev, vladimir.oltean,
linux-kselftest, shuah
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 23 Aug 2024 18:25:37 +0200 you wrote:
> This test neglects to put ports down on cleanup. Fix it.
>
> Fixes: 476a4f05d9b8 ("selftests: forwarding: add a no_forwarding.sh test")
> Signed-off-by: Petr Machata <petrm@nvidia.com>
> ---
> tools/testing/selftests/net/forwarding/no_forwarding.sh | 3 +++
> 1 file changed, 3 insertions(+)
Here is the summary with links:
- [net-next] selftests: forwarding: no_forwarding: Down ports on cleanup
https://git.kernel.org/netdev/net/c/e8497d6951ee
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-27 20:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-23 16:25 [PATCH net-next] selftests: forwarding: no_forwarding: Down ports on cleanup Petr Machata
2024-08-23 17:42 ` Simon Horman
2024-08-27 20:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).