From: Simon Horman <horms@kernel.org>
To: Yue Haibing <yuehaibing@huawei.com>
Cc: sgoutham@marvell.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: thunderx: Remove unused declarations
Date: Sun, 25 Aug 2024 09:12:14 +0100 [thread overview]
Message-ID: <20240825081214.GV2164@kernel.org> (raw)
In-Reply-To: <20240824082754.3637963-1-yuehaibing@huawei.com>
On Sat, Aug 24, 2024 at 04:27:54PM +0800, Yue Haibing wrote:
> Commit 4863dea3fab0 ("net: Adding support for Cavium ThunderX network
> controller") declared nicvf_qset_reg_{write,read}() but never implemented.
>
> Commit 4863dea3fab0 ("net: Adding support for Cavium ThunderX network
> controller") declared bgx_add_dmac_addr() but no implementation.
>
> After commit 5fc7cf179449 ("net: thunderx: Cleanup PHY probing code.")
> octeon_mdiobus_force_mod_depencency() is not used any more.
Maybe not so important, but perhaps it is worth mentioning that the
implementation of octeon_mdiobus_force_mod_depencency was subsequently
removed from the tree in commit 791e5f61aec5 ("net: phy: mdio-octeon:
Cleanup module loading dependencies").
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
I checked and all these symbols are indeed neither used nor implemented as
described above. And, my comment above notwithstanding, the cited commits
also look correct to me.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-08-25 8:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-24 8:27 [PATCH net-next] net: thunderx: Remove unused declarations Yue Haibing
2024-08-25 8:12 ` Simon Horman [this message]
2024-08-27 21:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240825081214.GV2164@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sgoutham@marvell.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).