[PATCH net-next] net: thunderx: Remove unused declarations

[PATCH net-next] net: thunderx: Remove unused declarations

[Yue Haibing]

Commit 4863dea3fab0 ("net: Adding support for Cavium ThunderX network
controller") declared nicvf_qset_reg_{write,read}() but never implemented.

Commit 4863dea3fab0 ("net: Adding support for Cavium ThunderX network
controller") declared bgx_add_dmac_addr() but no implementation.

After commit 5fc7cf179449 ("net: thunderx: Cleanup PHY probing code.")
octeon_mdiobus_force_mod_depencency() is not used any more.

Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
 drivers/net/ethernet/cavium/thunder/nicvf_queues.h | 2 --
 drivers/net/ethernet/cavium/thunder/thunder_bgx.h  | 2 --
 2 files changed, 4 deletions(-)

diff --git a/drivers/net/ethernet/cavium/thunder/nicvf_queues.h b/drivers/net/ethernet/cavium/thunder/nicvf_queues.h
index 8453defc296c..b7531041c56d 100644
--- a/drivers/net/ethernet/cavium/thunder/nicvf_queues.h
+++ b/drivers/net/ethernet/cavium/thunder/nicvf_queues.h
@@ -359,8 +359,6 @@ int nicvf_is_intr_enabled(struct nicvf *nic, int int_type, int q_idx);
 /* Register access APIs */
 void nicvf_reg_write(struct nicvf *nic, u64 offset, u64 val);
 u64  nicvf_reg_read(struct nicvf *nic, u64 offset);
-void nicvf_qset_reg_write(struct nicvf *nic, u64 offset, u64 val);
-u64 nicvf_qset_reg_read(struct nicvf *nic, u64 offset);
 void nicvf_queue_reg_write(struct nicvf *nic, u64 offset,
 			   u64 qidx, u64 val);
 u64  nicvf_queue_reg_read(struct nicvf *nic,
diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.h b/drivers/net/ethernet/cavium/thunder/thunder_bgx.h
index cdea49392185..84f16ababaee 100644
--- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.h
+++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.h
@@ -219,9 +219,7 @@
 void bgx_set_dmac_cam_filter(int node, int bgx_idx, int lmacid, u64 mac, u8 vf);
 void bgx_reset_xcast_mode(int node, int bgx_idx, int lmacid, u8 vf);
 void bgx_set_xcast_mode(int node, int bgx_idx, int lmacid, u8 mode);
-void octeon_mdiobus_force_mod_depencency(void);
 void bgx_lmac_rx_tx_enable(int node, int bgx_idx, int lmacid, bool enable);
-void bgx_add_dmac_addr(u64 dmac, int node, int bgx_idx, int lmac);
 unsigned bgx_get_map(int node);
 int bgx_get_lmac_count(int node, int bgx);
 const u8 *bgx_get_lmac_mac(int node, int bgx_idx, int lmacid);
-- 
2.34.1

Re: [PATCH net-next] net: thunderx: Remove unused declarations

[Simon Horman]

On Sat, Aug 24, 2024 at 04:27:54PM +0800, Yue Haibing wrote:
> Commit 4863dea3fab0 ("net: Adding support for Cavium ThunderX network
> controller") declared nicvf_qset_reg_{write,read}() but never implemented.
> 
> Commit 4863dea3fab0 ("net: Adding support for Cavium ThunderX network
> controller") declared bgx_add_dmac_addr() but no implementation.
> 
> After commit 5fc7cf179449 ("net: thunderx: Cleanup PHY probing code.")
> octeon_mdiobus_force_mod_depencency() is not used any more.

Maybe not so important, but perhaps it is worth mentioning that the
implementation of octeon_mdiobus_force_mod_depencency was subsequently
removed from the tree in commit 791e5f61aec5 ("net: phy: mdio-octeon:
Cleanup module loading dependencies").

> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>

I checked and all these symbols are indeed neither used nor implemented as
described above. And, my comment above notwithstanding, the cited commits
also look correct to me.

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [PATCH net-next] net: thunderx: Remove unused declarations

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Sat, 24 Aug 2024 16:27:54 +0800 you wrote:
> Commit 4863dea3fab0 ("net: Adding support for Cavium ThunderX network
> controller") declared nicvf_qset_reg_{write,read}() but never implemented.
> 
> Commit 4863dea3fab0 ("net: Adding support for Cavium ThunderX network
> controller") declared bgx_add_dmac_addr() but no implementation.
> 
> After commit 5fc7cf179449 ("net: thunderx: Cleanup PHY probing code.")
> octeon_mdiobus_force_mod_depencency() is not used any more.
> 
> [...]

Here is the summary with links:
  - [net-next] net: thunderx: Remove unused declarations
    https://git.kernel.org/netdev/net-next/c/9a4556862d1f

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html