netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Yue Haibing <yuehaibing@huawei.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: liquidio: Remove unused declarations
Date: Sun, 25 Aug 2024 09:18:20 +0100	[thread overview]
Message-ID: <20240825081820.GW2164@kernel.org> (raw)
In-Reply-To: <20240824083107.3639602-1-yuehaibing@huawei.com>

On Sat, Aug 24, 2024 at 04:31:07PM +0800, Yue Haibing wrote:
> Commit da15c78b5664 ("liquidio CN23XX: VF register access") declared
> cn23xx_dump_vf_initialized_regs() but never implemented it.
> 
> octeon_dump_soft_command() is never implemented and used since introduction in
> commit 35878618c92d ("liquidio: Added delayed work for periodically updating
> the link statistics.").
> 
> And finally, a few other declarations were never implenmented since introduction
> in commit f21fb3ed364b ("Add support of Cavium Liquidio ethernet adapters").
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>

Thanks, I looked over the git history of this driver
and agree with the analysis above.

Reviewed-by: Simon Horman <horms@kernel.org>

  reply	other threads:[~2024-08-25  8:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-24  8:31 [PATCH net-next] net: liquidio: Remove unused declarations Yue Haibing
2024-08-25  8:18 ` Simon Horman [this message]
2024-08-27 21:20 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240825081820.GW2164@kernel.org \
    --to=horms@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).