From: Jakub Kicinski <kuba@kernel.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v3 1/3] phy: open_alliance_helpers: Add defines for link quality metrics
Date: Mon, 26 Aug 2024 09:32:17 -0700 [thread overview]
Message-ID: <20240826093217.3e076b5c@kernel.org> (raw)
In-Reply-To: <20240822115939.1387015-2-o.rempel@pengutronix.de>
On Thu, 22 Aug 2024 13:59:37 +0200 Oleksij Rempel wrote:
> Introduce a set of defines for link quality (LQ) related metrics in the
> Open Alliance helpers. These metrics include:
>
> - `oa_lq_lfl_esd_event_count`: Number of ESD events detected by the Link
> Failures and Losses (LFL).
> - `oa_lq_link_training_time`: Time required to establish a link.
> - `oa_lq_remote_receiver_time`: Time required until the remote receiver
> signals that it is locked.
> - `oa_lq_local_receiver_time`: Time required until the local receiver is
> locked.
> - `oa_lq_lfl_link_loss_count`: Number of link losses.
> - `oa_lq_lfl_link_failure_count`: Number of link failures that do not
> cause a link loss.
>
> These standardized defines will be used by PHY drivers to report these
> statistics.
If these are defined by a standard why not report them as structured
data? Like we report ethtool_eth_mac_stats, ethtool_eth_ctrl_stats,
ethtool_rmon_stats etc.?
next prev parent reply other threads:[~2024-08-26 16:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 11:59 [PATCH net-next v3 0/3] Add Statistics Support for DP83TG720 PHY Oleksij Rempel
2024-08-22 11:59 ` [PATCH net-next v3 1/3] phy: open_alliance_helpers: Add defines for link quality metrics Oleksij Rempel
2024-08-22 15:48 ` Andrew Lunn
2024-08-26 16:32 ` Jakub Kicinski [this message]
2024-08-26 17:12 ` Andrew Lunn
2024-08-26 19:57 ` Jakub Kicinski
2024-08-27 4:51 ` Oleksij Rempel
2024-08-27 18:33 ` Jakub Kicinski
2024-08-28 4:50 ` Oleksij Rempel
2024-08-28 20:34 ` Jakub Kicinski
2024-08-28 20:45 ` Andrew Lunn
2024-08-29 4:41 ` Oleksij Rempel
2024-08-22 11:59 ` [PATCH net-next v3 2/3] phy: Add defines for standardized PHY generic counters Oleksij Rempel
2024-08-22 15:49 ` Andrew Lunn
2024-08-22 11:59 ` [PATCH net-next v3 3/3] phy: dp83tg720: Add statistics support Oleksij Rempel
2024-08-22 15:49 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240826093217.3e076b5c@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).