* [PATCH][next] qlcnic: make read-only const array key static
@ 2024-08-22 21:10 Colin Ian King
2024-08-26 20:23 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2024-08-22 21:10 UTC (permalink / raw)
To: Shahed Shaikh, Manish Chopra, GR-Linux-NIC-Dev, David S . Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, netdev
Cc: kernel-janitors, linux-kernel
Don't populate the const read-only array key on the stack at
run time, instead make it static.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
index bcef8ab715bf..5a91e9f9c408 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
@@ -2045,9 +2045,11 @@ int qlcnic_83xx_config_rss(struct qlcnic_adapter *adapter, int enable)
int err;
u32 word;
struct qlcnic_cmd_args cmd;
- const u64 key[] = { 0xbeac01fa6a42b73bULL, 0x8030f20c77cb2da3ULL,
- 0xae7b30b4d0ca2bcbULL, 0x43a38fb04167253dULL,
- 0x255b0ec26d5a56daULL };
+ static const u64 key[] = {
+ 0xbeac01fa6a42b73bULL, 0x8030f20c77cb2da3ULL,
+ 0xae7b30b4d0ca2bcbULL, 0x43a38fb04167253dULL,
+ 0x255b0ec26d5a56daULL
+ };
err = qlcnic_alloc_mbx_args(&cmd, adapter, QLCNIC_CMD_CONFIGURE_RSS);
if (err)
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH][next] qlcnic: make read-only const array key static
2024-08-22 21:10 [PATCH][next] qlcnic: make read-only const array key static Colin Ian King
@ 2024-08-26 20:23 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2024-08-26 20:23 UTC (permalink / raw)
To: Colin Ian King
Cc: Shahed Shaikh, Manish Chopra, GR-Linux-NIC-Dev, David S . Miller,
Eric Dumazet, Paolo Abeni, netdev, kernel-janitors, linux-kernel
On Thu, 22 Aug 2024 22:10:28 +0100 Colin Ian King wrote:
> diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
> index bcef8ab715bf..5a91e9f9c408 100644
> --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
> +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
> @@ -2045,9 +2045,11 @@ int qlcnic_83xx_config_rss(struct qlcnic_adapter *adapter, int enable)
> int err;
> u32 word;
> struct qlcnic_cmd_args cmd;
> - const u64 key[] = { 0xbeac01fa6a42b73bULL, 0x8030f20c77cb2da3ULL,
> - 0xae7b30b4d0ca2bcbULL, 0x43a38fb04167253dULL,
> - 0x255b0ec26d5a56daULL };
> + static const u64 key[] = {
> + 0xbeac01fa6a42b73bULL, 0x8030f20c77cb2da3ULL,
> + 0xae7b30b4d0ca2bcbULL, 0x43a38fb04167253dULL,
> + 0x255b0ec26d5a56daULL
> + };
Move it up, please, reverse xmas tree
--
pw-bot: cr
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-26 20:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-22 21:10 [PATCH][next] qlcnic: make read-only const array key static Colin Ian King
2024-08-26 20:23 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).