From: Stephen Hemminger <stephen@networkplumber.org>
To: Liu Mingrui <liumingrui@huawei.com>
Cc: <willemdebruijn.kernel@gmail.com>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<netdev@vger.kernel.org>
Subject: Re: [PATCH -next] af_packet: display drop field in packet_seq_show
Date: Mon, 26 Aug 2024 17:19:17 -0700 [thread overview]
Message-ID: <20240826171917.55444272@hermes.local> (raw)
In-Reply-To: <20240826092625.2637632-1-liumingrui@huawei.com>
On Mon, 26 Aug 2024 09:26:25 +0000
Liu Mingrui <liumingrui@huawei.com> wrote:
> Display the dropped count of the packet, which could provide more
> information for debugging.
>
> Signed-off-by: Liu Mingrui <liumingrui@huawei.com>
> ---
At this point /proc/net/packet is a poor choice for extension.
For example, ss command ignores it if PACKET_DIAG_MEMINFO is available.
Better to add new netlink field see net/packet/diag.c.
Maybe time for PACKET_DIAG_STATS with name/value like ethtool.
prev parent reply other threads:[~2024-08-27 0:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 9:26 [PATCH -next] af_packet: display drop field in packet_seq_show Liu Mingrui
2024-08-26 7:10 ` Eric Dumazet
2024-08-27 0:19 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240826171917.55444272@hermes.local \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=liumingrui@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox