From: Jakub Kicinski <kuba@kernel.org>
To: Yan Zhen <yanzhen@vivo.com>
Cc: louis.peens@corigine.com, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, oss-drivers@corigine.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
opensource.kernel@vivo.vom
Subject: Re: [PATCH v1] netronome: nfp: Use min macro
Date: Tue, 27 Aug 2024 07:24:23 -0700 [thread overview]
Message-ID: <20240827072423.4540bed6@kernel.org> (raw)
In-Reply-To: <20240827084005.3815912-1-yanzhen@vivo.com>
On Tue, 27 Aug 2024 16:40:05 +0800 Yan Zhen wrote:
> Using min macro not only makes the code more concise and readable
> but also improves efficiency sometimes.
The code is fine, you're making it worse.
How many of those pointless min()/max() conversions do you have
for drivers/net ?
--
pw-bot: reject
next prev parent reply other threads:[~2024-08-27 14:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 8:40 [PATCH v1] netronome: nfp: Use min macro Yan Zhen
2024-08-27 14:24 ` Jakub Kicinski [this message]
2024-08-31 12:49 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240827072423.4540bed6@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=louis.peens@corigine.com \
--cc=netdev@vger.kernel.org \
--cc=opensource.kernel@vivo.vom \
--cc=oss-drivers@corigine.com \
--cc=pabeni@redhat.com \
--cc=yanzhen@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).