From: Hongbo Li <lihongbo22@huawei.com>
To: <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <dsahern@kernel.org>, <ralf@linux-mips.org>,
<jmaloy@redhat.com>, <ying.xue@windriver.com>
Cc: <netdev@vger.kernel.org>, <linux-hams@vger.kernel.org>,
<netfilter-devel@vger.kernel.org>
Subject: [PATCH net-next 2/6] net/ipv6: replace deprecated strcpy with strscpy
Date: Tue, 27 Aug 2024 19:35:23 +0800 [thread overview]
Message-ID: <20240827113527.4019856-3-lihongbo22@huawei.com> (raw)
In-Reply-To: <20240827113527.4019856-1-lihongbo22@huawei.com>
The deprecated helper strcpy() performs no bounds checking on the
destination buffer. This could result in linear overflows beyond
the end of the buffer, leading to all kinds of misbehaviors.
The safe replacement is strscpy() [1].
Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy [1]
Signed-off-by: Hongbo Li <lihongbo22@huawei.com>
---
net/ipv6/ndisc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c
index 1e42e40fb379..d231d678dabc 100644
--- a/net/ipv6/ndisc.c
+++ b/net/ipv6/ndisc.c
@@ -1944,7 +1944,7 @@ static void ndisc_warn_deprecated_sysctl(const struct ctl_table *ctl,
static char warncomm[TASK_COMM_LEN];
static int warned;
if (strcmp(warncomm, current->comm) && warned < 5) {
- strcpy(warncomm, current->comm);
+ strscpy(warncomm, current->comm, TASK_COMM_LEN);
pr_warn("process `%s' is using deprecated sysctl (%s) net.ipv6.neigh.%s.%s - use net.ipv6.neigh.%s.%s_ms instead\n",
warncomm, func,
dev_name, ctl->procname,
--
2.34.1
next prev parent reply other threads:[~2024-08-27 11:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 11:35 [PATCH net-next 0/6] replace deprecated strcpy with strscpy Hongbo Li
2024-08-27 11:35 ` [PATCH net-next 1/6] net: prefer strscpy over strcpy Hongbo Li
2024-08-27 12:30 ` Dan Carpenter
2024-08-28 7:43 ` Hongbo Li
2024-08-28 8:54 ` Dan Carpenter
2024-08-27 11:35 ` Hongbo Li [this message]
2024-08-27 11:35 ` [PATCH net-next 3/6] net/netrom: " Hongbo Li
2024-08-27 11:35 ` [PATCH net-next 4/6] net/netfilter: replace deprecated strcpy with strscpy Hongbo Li
2024-08-27 11:35 ` [PATCH net-next 5/6] net/tipc: " Hongbo Li
2024-08-27 11:35 ` [PATCH net-next 6/6] net/ipv4: net: prefer strscpy over strcpy Hongbo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240827113527.4019856-3-lihongbo22@huawei.com \
--to=lihongbo22@huawei.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=jmaloy@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-hams@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ralf@linux-mips.org \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox