netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org, Jay Vosburgh <j.vosburgh@gmail.com>,
	"David S . Miller" <davem@davemloft.net>,
	Paolo Abeni <pabeni@redhat.com>,
	Eric Dumazet <edumazet@google.com>,
	Nikolay Aleksandrov <razor@blackwall.org>,
	Tariq Toukan <tariqt@nvidia.com>, Jianbo Liu <jianbol@nvidia.com>,
	Sabrina Dubroca <sd@queasysnail.net>,
	Simon Horman <horms@kernel.org>,
	Steffen Klassert <steffen.klassert@secunet.com>
Subject: Re: [PATCHv4 net-next 1/3] bonding: add common function to check ipsec device
Date: Tue, 27 Aug 2024 13:06:19 -0700	[thread overview]
Message-ID: <20240827130619.1a1cd34f@kernel.org> (raw)
In-Reply-To: <20240821105003.547460-2-liuhangbin@gmail.com>

On Wed, 21 Aug 2024 18:50:01 +0800 Hangbin Liu wrote:
> +/**
> + * bond_ipsec_dev - return the device for ipsec offload, or NULL if not exist
> + *                  caller must hold rcu_read_lock.
> + * @xs: pointer to transformer state struct
> + **/

in addition to the feedback on v3, nit: document the return value in
kdoc for non-void functions

  reply	other threads:[~2024-08-27 20:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-21 10:50 [PATCHv4 net-next 0/3] Bonding: support new xfrm state offload functions Hangbin Liu
2024-08-21 10:50 ` [PATCHv4 net-next 1/3] bonding: add common function to check ipsec device Hangbin Liu
2024-08-27 20:06   ` Jakub Kicinski [this message]
2024-08-28  1:14     ` Hangbin Liu
2024-08-28  2:28       ` Jakub Kicinski
2024-08-28  3:30         ` Hangbin Liu
2024-08-28 14:43       ` Simon Horman
2024-08-29  9:28         ` Hangbin Liu
2024-08-21 10:50 ` [PATCHv4 net-next 2/3] bonding: Add ESN support to IPSec HW offload Hangbin Liu
2024-08-21 10:50 ` [PATCHv4 net-next 3/3] bonding: support xfrm state update Hangbin Liu
2024-08-23 20:48 ` [PATCHv4 net-next 0/3] Bonding: support new xfrm state offload functions Jay Vosburgh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240827130619.1a1cd34f@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=j.vosburgh@gmail.com \
    --cc=jianbol@nvidia.com \
    --cc=liuhangbin@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=razor@blackwall.org \
    --cc=sd@queasysnail.net \
    --cc=steffen.klassert@secunet.com \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).