* [PATCH -next] MIPS: Remove obsoleted declaration for mv64340_irq_init
@ 2024-08-26 3:23 Gaosheng Cui
2024-08-27 14:43 ` Simon Horman
2024-08-27 21:25 ` Jakub Kicinski
0 siblings, 2 replies; 4+ messages in thread
From: Gaosheng Cui @ 2024-08-26 3:23 UTC (permalink / raw)
To: sebastian.hesselbarth, cuigaosheng1; +Cc: netdev
The mv64340_irq_init() have been removed since
commit 688b3d720820 ("[MIPS] Delete Ocelot 3 support."), and now
it is useless, so remove it.
Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
---
include/linux/mv643xx.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/linux/mv643xx.h b/include/linux/mv643xx.h
index 000b126acfb6..a7975c16d13f 100644
--- a/include/linux/mv643xx.h
+++ b/include/linux/mv643xx.h
@@ -916,6 +916,4 @@
#define MV64340_SERIAL_INIT_CONTROL 0xf328
#define MV64340_SERIAL_INIT_STATUS 0xf32c
-extern void mv64340_irq_init(unsigned int base);
-
#endif /* __ASM_MV643XX_H */
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH -next] MIPS: Remove obsoleted declaration for mv64340_irq_init
2024-08-26 3:23 [PATCH -next] MIPS: Remove obsoleted declaration for mv64340_irq_init Gaosheng Cui
@ 2024-08-27 14:43 ` Simon Horman
2024-08-27 21:25 ` Jakub Kicinski
1 sibling, 0 replies; 4+ messages in thread
From: Simon Horman @ 2024-08-27 14:43 UTC (permalink / raw)
To: Gaosheng Cui; +Cc: sebastian.hesselbarth, netdev
On Mon, Aug 26, 2024 at 11:23:44AM +0800, Gaosheng Cui wrote:
> The mv64340_irq_init() have been removed since
> commit 688b3d720820 ("[MIPS] Delete Ocelot 3 support."), and now
> it is useless, so remove it.
>
> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
Thanks,
I agree that the mv64340_irq_init declaration is dangling since
the cited commit.
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next] MIPS: Remove obsoleted declaration for mv64340_irq_init
2024-08-26 3:23 [PATCH -next] MIPS: Remove obsoleted declaration for mv64340_irq_init Gaosheng Cui
2024-08-27 14:43 ` Simon Horman
@ 2024-08-27 21:25 ` Jakub Kicinski
2024-09-09 13:50 ` cuigaosheng
1 sibling, 1 reply; 4+ messages in thread
From: Jakub Kicinski @ 2024-08-27 21:25 UTC (permalink / raw)
To: Gaosheng Cui; +Cc: sebastian.hesselbarth, netdev
On Mon, 26 Aug 2024 11:23:44 +0800 Gaosheng Cui wrote:
> The mv64340_irq_init() have been removed since
> commit 688b3d720820 ("[MIPS] Delete Ocelot 3 support."), and now
> it is useless, so remove it.
Most of the drivers which used this header have been deleted.
Please move the only 3(?) defines that are actually used into
arch/powerpc/platforms/chrp/pegasos_eth.c
and delete the file completely.
--
pw-bot: cr
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next] MIPS: Remove obsoleted declaration for mv64340_irq_init
2024-08-27 21:25 ` Jakub Kicinski
@ 2024-09-09 13:50 ` cuigaosheng
0 siblings, 0 replies; 4+ messages in thread
From: cuigaosheng @ 2024-09-09 13:50 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: sebastian.hesselbarth, netdev
On 2024/8/28 5:25, Jakub Kicinski wrote:
> On Mon, 26 Aug 2024 11:23:44 +0800 Gaosheng Cui wrote:
>> The mv64340_irq_init() have been removed since
>> commit 688b3d720820 ("[MIPS] Delete Ocelot 3 support."), and now
>> it is useless, so remove it.
> Most of the drivers which used this header have been deleted.
> Please move the only 3(?) defines that are actually used into
> arch/powerpc/platforms/chrp/pegasos_eth.c
> and delete the file completely.
I hava re-sent a new patch v2 with this change, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-09-09 13:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-26 3:23 [PATCH -next] MIPS: Remove obsoleted declaration for mv64340_irq_init Gaosheng Cui
2024-08-27 14:43 ` Simon Horman
2024-08-27 21:25 ` Jakub Kicinski
2024-09-09 13:50 ` cuigaosheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).