netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Yu Liao <liaoyu15@huawei.com>
Cc: jiawenwu@trustnetic.com, mengyuanlou@net-swift.com,
	liwei391@huawei.com, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH -next] net: txgbe: use pci_dev_id() helper
Date: Tue, 27 Aug 2024 15:42:56 +0100	[thread overview]
Message-ID: <20240827144256.GF1368797@kernel.org> (raw)
In-Reply-To: <20240826012100.3975175-1-liaoyu15@huawei.com>

On Mon, Aug 26, 2024 at 09:21:00AM +0800, Yu Liao wrote:
> PCI core API pci_dev_id() can be used to get the BDF number for a PCI
> device. We don't need to compose it manually. Use pci_dev_id() to
> simplify the code a little bit.
> 
> Signed-off-by: Yu Liao <liaoyu15@huawei.com>

Thanks Yu Liao,

I agree that pci_dev_id() was being open coded here.
And that it is nicer to use that helper.

Reviewed-by: Simon Horman <horms@kernel.org>


  reply	other threads:[~2024-08-27 14:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-26  1:21 [PATCH -next] net: txgbe: use pci_dev_id() helper Yu Liao
2024-08-27 14:42 ` Simon Horman [this message]
2024-08-27 21:30 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240827144256.GF1368797@kernel.org \
    --to=horms@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jiawenwu@trustnetic.com \
    --cc=kuba@kernel.org \
    --cc=liaoyu15@huawei.com \
    --cc=liwei391@huawei.com \
    --cc=mengyuanlou@net-swift.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).