From: Jakub Kicinski <kuba@kernel.org>
To: David Hunter <david.hunter.linux@gmail.com>
Cc: davem@davemloft.net, edumazet@google.com,
javier.carrasco.cruz@gmail.com, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, netdev@vger.kernel.org,
pabeni@redhat.com, shuah@kernel.org
Subject: Re: [PATCH 1/1 V2] Selftests: net: Set executable bit for shell script
Date: Tue, 27 Aug 2024 14:44:48 -0700 [thread overview]
Message-ID: <20240827144448.64524df3@kernel.org> (raw)
In-Reply-To: <20240827213721.53379-1-david.hunter.linux@gmail.com>
On Tue, 27 Aug 2024 17:37:21 -0400 David Hunter wrote:
> On Mon, 26 Aug 2024 14:40:22 -0700 Jakub Kicinski wrote:
> > What is linux_mainline and how does one download from it?
>
> The Linux Mainline source files can be downloaded using the following command:
>
> git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git linux_mainline
>
> I meant to say "Linux Mainline". In my computer, I put the title for
> the directory as "linux_mainline", so I have a habit of putting the
> underscore when I should not.
I see. But going back to the commit message - why would the files be
skipped? At some point you shared a warning which gets printed:
# Warning: file test_ingress_egress_chaining.sh is not executable
that's a better thing to put in the commit message, than talking
about downloading.
Keep in mind you need to put a space or two before the # otherwise
git will think it's a comment.
prev parent reply other threads:[~2024-08-27 21:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-20 20:21 [PATCH 1/1] Improve missing mods error message and make shell script executable David Hunter
2024-08-22 1:02 ` Jakub Kicinski
2024-08-23 19:08 ` David Hunter
2024-08-24 14:38 ` [PATCH 1/1 V2] Selftests: net: Set executable bit for shell script David Hunter
2024-08-26 16:10 ` patchwork-bot+netdevbpf
2024-08-26 21:40 ` Jakub Kicinski
2024-08-27 21:37 ` David Hunter
2024-08-27 21:44 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240827144448.64524df3@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=david.hunter.linux@gmail.com \
--cc=edumazet@google.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).