[PATCH net-next RESEND 0/3] net: hisilicon: minor fixes

[PATCH net-next RESEND 0/3] net: hisilicon: minor fixes

[Krzysztof Kozlowski]

Minor fixes for hisilicon ethernet driver which look too trivial to be
considered for current RC.

Best regards,
Krzysztof

Krzysztof Kozlowski (3):
  net: hisilicon: hip04: fix OF node leak in probe()
  net: hisilicon: hns_dsaf_mac: fix OF node leak in hns_mac_get_info()
  net: hisilicon: hns_mdio: fix OF node leak in probe()

 drivers/net/ethernet/hisilicon/hip04_eth.c        | 1 +
 drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 1 +
 drivers/net/ethernet/hisilicon/hns_mdio.c         | 1 +
 3 files changed, 3 insertions(+)

[PATCH net-next RESEND 1/3] net: hisilicon: hip04: fix OF node leak in probe()

[Krzysztof Kozlowski]

Driver is leaking OF node reference from
of_parse_phandle_with_fixed_args() in probe().

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/net/ethernet/hisilicon/hip04_eth.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/hisilicon/hip04_eth.c b/drivers/net/ethernet/hisilicon/hip04_eth.c
index b91e7a06b97f..beb815e5289b 100644
--- a/drivers/net/ethernet/hisilicon/hip04_eth.c
+++ b/drivers/net/ethernet/hisilicon/hip04_eth.c
@@ -947,6 +947,7 @@ static int hip04_mac_probe(struct platform_device *pdev)
 	priv->tx_coalesce_timer.function = tx_done;
 
 	priv->map = syscon_node_to_regmap(arg.np);
+	of_node_put(arg.np);
 	if (IS_ERR(priv->map)) {
 		dev_warn(d, "no syscon hisilicon,hip04-ppe\n");
 		ret = PTR_ERR(priv->map);
-- 
2.43.0

[PATCH net-next RESEND 2/3] net: hisilicon: hns_dsaf_mac: fix OF node leak in hns_mac_get_info()

[Krzysztof Kozlowski]

Driver is leaking OF node reference from
of_parse_phandle_with_fixed_args() in hns_mac_get_info().

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
index f75668c47935..616a2768e504 100644
--- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
+++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
@@ -933,6 +933,7 @@ static int hns_mac_get_info(struct hns_mac_cb *mac_cb)
 			mac_cb->cpld_ctrl = NULL;
 		} else {
 			syscon = syscon_node_to_regmap(cpld_args.np);
+			of_node_put(cpld_args.np);
 			if (IS_ERR_OR_NULL(syscon)) {
 				dev_dbg(mac_cb->dev, "no cpld-syscon found!\n");
 				mac_cb->cpld_ctrl = NULL;
-- 
2.43.0

[PATCH net-next RESEND 3/3] net: hisilicon: hns_mdio: fix OF node leak in probe()

[Krzysztof Kozlowski]

Driver is leaking OF node reference from
of_parse_phandle_with_fixed_args() in probe().

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/net/ethernet/hisilicon/hns_mdio.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/hisilicon/hns_mdio.c b/drivers/net/ethernet/hisilicon/hns_mdio.c
index ed73707176c1..8a047145f0c5 100644
--- a/drivers/net/ethernet/hisilicon/hns_mdio.c
+++ b/drivers/net/ethernet/hisilicon/hns_mdio.c
@@ -575,6 +575,7 @@ static int hns_mdio_probe(struct platform_device *pdev)
 						MDIO_SC_RESET_ST;
 				}
 			}
+			of_node_put(reg_args.np);
 		} else {
 			dev_warn(&pdev->dev, "find syscon ret = %#x\n", ret);
 			mdio_dev->subctrl_vbase = NULL;
-- 
2.43.0

Re: [PATCH net-next RESEND 1/3] net: hisilicon: hip04: fix OF node leak in probe()

[Simon Horman]

On Tue, Aug 27, 2024 at 04:44:19PM +0200, Krzysztof Kozlowski wrote:
> Driver is leaking OF node reference from
> of_parse_phandle_with_fixed_args() in probe().
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [PATCH net-next RESEND 2/3] net: hisilicon: hns_dsaf_mac: fix OF node leak in hns_mac_get_info()

[Simon Horman]

On Tue, Aug 27, 2024 at 04:44:20PM +0200, Krzysztof Kozlowski wrote:
> Driver is leaking OF node reference from
> of_parse_phandle_with_fixed_args() in hns_mac_get_info().
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [PATCH net-next RESEND 3/3] net: hisilicon: hns_mdio: fix OF node leak in probe()

[Simon Horman]

On Tue, Aug 27, 2024 at 04:44:21PM +0200, Krzysztof Kozlowski wrote:
> Driver is leaking OF node reference from
> of_parse_phandle_with_fixed_args() in probe().
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [PATCH net-next RESEND 0/3] net: hisilicon: minor fixes

[patchwork-bot+netdevbpf]

Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 27 Aug 2024 16:44:18 +0200 you wrote:
> Minor fixes for hisilicon ethernet driver which look too trivial to be
> considered for current RC.
> 
> Best regards,
> Krzysztof
> 
> Krzysztof Kozlowski (3):
>   net: hisilicon: hip04: fix OF node leak in probe()
>   net: hisilicon: hns_dsaf_mac: fix OF node leak in hns_mac_get_info()
>   net: hisilicon: hns_mdio: fix OF node leak in probe()
> 
> [...]

Here is the summary with links:
  - [net-next,RESEND,1/3] net: hisilicon: hip04: fix OF node leak in probe()
    https://git.kernel.org/netdev/net-next/c/17555297dbd5
  - [net-next,RESEND,2/3] net: hisilicon: hns_dsaf_mac: fix OF node leak in hns_mac_get_info()
    https://git.kernel.org/netdev/net-next/c/5680cf8d34e1
  - [net-next,RESEND,3/3] net: hisilicon: hns_mdio: fix OF node leak in probe()
    https://git.kernel.org/netdev/net-next/c/e62beddc45f4

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html