From: Jakub Kicinski <kuba@kernel.org>
To: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Cc: Mohsin Bashir <mohsin.bashr@gmail.com>,
netdev@vger.kernel.org, alexanderduyck@fb.com, andrew@lunn.ch,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
kernel-team@meta.com, sanmanpradhan@meta.com, sdf@fomichev.me,
jdamato@fastly.com
Subject: Re: [PATCH net-next v2 1/2] eth: fbnic: Add ethtool support for fbnic
Date: Wed, 28 Aug 2024 11:18:16 -0700 [thread overview]
Message-ID: <20240828111816.5749db28@kernel.org> (raw)
In-Reply-To: <34c52e04-00aa-4507-9150-0230ce760c9a@gmail.com>
On Wed, 28 Aug 2024 10:49:06 -0700 Mohsin Bashir wrote:
> > Isn't it cleaner to have it in sth like fbnic_ethtool.h file? Probably
> > you will have more functions there in the future.
>
> It would definitely be cleaner if have a large number of functions which
> isn't the case hence, did not add fbnic_ethtool.h
To further clarify, if I'm grepping right - the more fully featured
"prototype" driver out of tree only exposes this one function from
fbnic_ethtool.c
Most ethtool functions get hooked in via ops, and ethtool code calls
out, rather than getting called by the driver itself. So it's probably
fine (and I only mean in this particular case, IDK if all the headers
in fbnic are well organized, it's been a while.)
next prev parent reply other threads:[~2024-08-28 18:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 20:59 [PATCH net-next v2 0/2] eth: Add basic ethtool support for fbnic Mohsin Bashir
2024-08-27 20:59 ` [PATCH net-next v2 1/2] eth: fbnic: Add " Mohsin Bashir
2024-08-28 6:29 ` Michal Swiatkowski
2024-08-28 17:49 ` Mohsin Bashir
2024-08-28 18:18 ` Jakub Kicinski [this message]
2024-08-27 20:59 ` [PATCH net-next v2 2/2] eth: fbnic: Add support to fetch group stats Mohsin Bashir
2024-08-28 0:30 ` Nelson, Shannon
2024-08-28 16:41 ` Alexander H Duyck
2024-08-29 0:47 ` Mohsin Bashir
2024-08-28 14:37 ` Simon Horman
2024-08-28 17:50 ` Mohsin Bashir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240828111816.5749db28@kernel.org \
--to=kuba@kernel.org \
--cc=alexanderduyck@fb.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jdamato@fastly.com \
--cc=kernel-team@meta.com \
--cc=michal.swiatkowski@linux.intel.com \
--cc=mohsin.bashr@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sanmanpradhan@meta.com \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).