From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 473DE1A38E0 for ; Wed, 28 Aug 2024 20:30:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724877050; cv=none; b=lN4FtHf9EflmAiM2hIXRaO60dX5eUNir1qvwuumyD7vdsFFii/pbQCCUp0Svs79W/Iv1b0P0J/bYwZLufTZLKHfL8qiCDANEOkF2GXQ8FMEvNZep7zbrtHIiK/Dax7klXaUW+CxyGwjS2h1KIZ/LyOVPRt64YlzpI2NjgIFrp68= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724877050; c=relaxed/simple; bh=NcCH55ExngTBLNsf0KzMUjxVkqb0h/ouLVWnSI1nMnk=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lL3LxYLA0AWbs9HuTrZgAWKyMRWed9Pl9hYp4r1XmEpKCgV9zE8nxk1hePVBJR5GOmgvAh9+69jwtNFuV8keMaUIQ6/4VTX/qmYRIrbXRl7VhBeyl4GUBT9PZTp03JnKeCtZPn8eqgtcaR6w205EW318fnKGh+38ohTdDBfLtrU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TH9NCiOZ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TH9NCiOZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98DBEC4CEC0; Wed, 28 Aug 2024 20:30:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724877049; bh=NcCH55ExngTBLNsf0KzMUjxVkqb0h/ouLVWnSI1nMnk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=TH9NCiOZ1k0nbyEwPgPSMrJhtwIe9fld1QQnELbZYi0oXM23vsMPqdQLMs0kNTGlq QCICC/cA3GHvtnRc25OxGpz9pl27OPebv+ocltjI6+dQE357uoyGeIpVZz21j3M9DS w5OeeejZBVvLshFq6eBcjgZ3VKt5KVpCEL65XLMsHdsB8gWa1vMA8s4u8W+mqrtyt1 ei7raJcG5gER4EnjmEeTBkYIDy2brK2xj5NYKBbqX45LmM8iKLSpuQsUJE0u5VjY1p 9GEXq/gjAu+Nu/5ixFbAb/cXDcsy33bv6U5o8iKl/Q8QDv/D+X2FRIr0AlNu2EWDGy kdTUcGEMxK93A== Date: Wed, 28 Aug 2024 13:30:48 -0700 From: Jakub Kicinski To: Paolo Abeni Cc: Jiri Pirko , netdev@vger.kernel.org, Madhu Chittim , Sridhar Samudrala , Simon Horman , John Fastabend , Sunil Kovvuri Goutham , Jamal Hadi Salim Subject: Re: [PATCH v3 03/12] net-shapers: implement NL get operation Message-ID: <20240828133048.35768be6@kernel.org> In-Reply-To: <061cba21-ad88-4a1e-ab37-14d42ea1adc3@redhat.com> References: <432f8531-cf4a-480c-84f7-61954c480e46@redhat.com> <20240827075406.34050de2@kernel.org> <20240827140351.4e0c5445@kernel.org> <061cba21-ad88-4a1e-ab37-14d42ea1adc3@redhat.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 28 Aug 2024 12:55:31 +0200 Paolo Abeni wrote: > - Update the NL definition to nest the =E2=80=98ifindex=E2=80=99 attribut= e under the=20 > =E2=80=98binding=E2=80=99 one. No mention/reference to devlink yet, so mo= st of the=20 > documentation will be unchanged. Sorry but I think that's a bad idea. Nesting attributes in netlink with no semantic implications, just to "organize" attributes which are somehow related just complicates the code and wastes space. Netlink is not JSON. Especially in this case, where we would do it for future uAPI extension which I really hope we won't need, since (1) devlink already has one, (2) the point of this API is to reduce the uAPI surface, not extend it, (3) user requirements for devlink and netdev config are different.