From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4620D16C865; Wed, 28 Aug 2024 12:38:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724848734; cv=none; b=m6ofnKLRbtTiTp5A6Jmoy3Gj/NNn/Vt9QoYU3IQyBhm15G658Ul1+UH1s7MVWnP3GZ2e4oPFy+RK0hegSzojqGwjgFEIxgJLvlu8Enc3zAoGjF3iYKKd4OmpVg6NzQlWkn7SKcI1FjcmQtd5lQpKOB284Z+GR4JcBiq7Iv/d+aw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724848734; c=relaxed/simple; bh=Kb42ny4JQIEMx/QzK5RnzyL5pG52Hi2BMThbTfxIaEM=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=oUOaFoXB/qJP7wLyaT/Q80iihReJd8dY1pxr0sP45Vx62fl1it+XEX0zXFm8yMeFuMuP/OR6jvrlF9JQV6GhzuCXrUisj3V8jkA3Ljqw9r3WV1fHrVZCGZpeHIMgnCFyZ8NzhmHQnw8MvhnOO7qAgrhPNqeO8L2E7Y0Ae7R1ivI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Wv3m35lmWz6K993; Wed, 28 Aug 2024 20:35:31 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 165B714038F; Wed, 28 Aug 2024 20:38:50 +0800 (CST) Received: from localhost (10.203.177.66) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 28 Aug 2024 13:38:49 +0100 Date: Wed, 28 Aug 2024 13:38:48 +0100 From: Jonathan Cameron To: Jinjie Ruan CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH net-next v2 02/13] net: stmmac: dwmac-sun8i: Use __free() to simplify code Message-ID: <20240828133848.00006fe2@Huawei.com> In-Reply-To: <20240828032343.1218749-3-ruanjinjie@huawei.com> References: <20240828032343.1218749-1-ruanjinjie@huawei.com> <20240828032343.1218749-3-ruanjinjie@huawei.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml100001.china.huawei.com (7.191.160.183) To lhrpeml500005.china.huawei.com (7.191.163.240) On Wed, 28 Aug 2024 11:23:32 +0800 Jinjie Ruan wrote: > Avoid need to manually handle of_node_put() by using __free(), which > can simplfy code. > > Signed-off-by: Jinjie Ruan Reviewed-by: Jonathan Cameron