From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F359915A86D; Wed, 28 Aug 2024 12:40:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724848825; cv=none; b=m6CT+lRIDN+LsK4/1+kuVscHpSvIfYkaR9r8xPD/dI1i1BagMZ5bxf6zJ0NcJm02dybTlNIAHHdtJx77aNX46pW0IPYXk3OaSlCCx5IDTcrrPEZFOauGgyfqftbPqv1LCmd6cTaWtRBYFakklag/u+H/dALLtkowuEKr+w09s+E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724848825; c=relaxed/simple; bh=gCQoT8MaQHP9jU0461ggHIjp7ehY9/Fq/mnbrruIrok=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=UdpNYxrXNYgMP4Vd10d9ZpQm0a6YV3aE8OmOHjT7s7pnPfTVarIvlpXzoVsBY/06OkMRze4Y+Vso1MlqBhYQty+OjIzcQiqEPYDNQX7jXfj40olFgcU+bm29IOBQVbdq4XVI/vvsHclG/i/CaPXYyJu1tvS7w79z/2qG6n9+dzw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Wv3nq3QgKz6K98q; Wed, 28 Aug 2024 20:37:03 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id ADF3C140740; Wed, 28 Aug 2024 20:40:21 +0800 (CST) Received: from localhost (10.203.177.66) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 28 Aug 2024 13:40:21 +0100 Date: Wed, 28 Aug 2024 13:40:20 +0100 From: Jonathan Cameron To: Jinjie Ruan CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH net-next v2 05/13] net: phy: Fix missing of_node_put() for leds Message-ID: <20240828134020.00005d99@Huawei.com> In-Reply-To: <20240828032343.1218749-6-ruanjinjie@huawei.com> References: <20240828032343.1218749-1-ruanjinjie@huawei.com> <20240828032343.1218749-6-ruanjinjie@huawei.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml100001.china.huawei.com (7.191.160.183) To lhrpeml500005.china.huawei.com (7.191.163.240) On Wed, 28 Aug 2024 11:23:35 +0800 Jinjie Ruan wrote: > The call of of_get_child_by_name() will cause refcount incremented > for leds, if it succeeds, it should call of_node_put() to decrease > it, fix it. > > Fixes: 01e5b728e9e4 ("net: phy: Add a binding for PHY LEDs") > Signed-off-by: Jinjie Ruan Reviewed-by: Jonathan Cameron