From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07D8117BEBD; Wed, 28 Aug 2024 12:46:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724849170; cv=none; b=V2QT8B9JXhndxDs78ow+42EW0/O0nV3UdIs6nrBczq2D1nR3cjzt6lUOx64JaOHzNXhdNUeBhMFPcnEwwE+ihYqcCcDvA9EMA8Lqm/kCmSCkPu90lHcFXdUARV5JLfnxw2SgBAnHHcTlRxd4Rd86KFFEUghidfsABj0lE2CaSc0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724849170; c=relaxed/simple; bh=oPRETZ/eOqh0lUEXpvzBxlA/tnATbRnzHbuB+l9VgQY=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=oslvhDmuedcWKKdTieGNQRlwIBuqWApNRKkrTKeb4QHKMBQVMFkadmZF1E0nek5YHwzgX3ggxWKiRVFcEv1xU/Yu6lmZp38OI0ELIkibMsL3pu69z23+CM1Pe5c+pxaFskP2jOh6LKTRWsX6OrC9OlnIpXvfrIeGsp+Ro5U3ZQU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Wv3vd4st5z6K6HL; Wed, 28 Aug 2024 20:42:05 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 106911400D1; Wed, 28 Aug 2024 20:46:07 +0800 (CST) Received: from localhost (10.203.177.66) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 28 Aug 2024 13:46:06 +0100 Date: Wed, 28 Aug 2024 13:46:05 +0100 From: Jonathan Cameron To: Jinjie Ruan CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH net-next v2 07/13] net: mdio: mux-mmioreg: Simplified with scoped function Message-ID: <20240828134605.00000d23@Huawei.com> In-Reply-To: <20240828032343.1218749-8-ruanjinjie@huawei.com> References: <20240828032343.1218749-1-ruanjinjie@huawei.com> <20240828032343.1218749-8-ruanjinjie@huawei.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml100001.china.huawei.com (7.191.160.183) To lhrpeml500005.china.huawei.com (7.191.163.240) On Wed, 28 Aug 2024 11:23:37 +0800 Jinjie Ruan wrote: > Avoids the need for manual cleanup of_node_put() in early exits > from the loop by using for_each_available_child_of_node_scoped(). > > Signed-off-by: Jinjie Ruan Looks fine, though maybe driver would also benefit from dev_err_probe() Reviewed-by: Jonathan Cameron