From: Simon Horman <horms@kernel.org>
To: Mohsin Bashir <mohsin.bashr@gmail.com>
Cc: netdev@vger.kernel.org, alexanderduyck@fb.com, kuba@kernel.org,
andrew@lunn.ch, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, kernel-team@meta.com, sanmanpradhan@meta.com,
sdf@fomichev.me, jdamato@fastly.com
Subject: Re: [PATCH net-next v2 2/2] eth: fbnic: Add support to fetch group stats
Date: Wed, 28 Aug 2024 15:37:36 +0100 [thread overview]
Message-ID: <20240828143736.GH1368797@kernel.org> (raw)
In-Reply-To: <20240827205904.1944066-3-mohsin.bashr@gmail.com>
On Tue, Aug 27, 2024 at 01:59:04PM -0700, Mohsin Bashir wrote:
> Add support for group stats for mac. The fbnic_set_counter helps prevent
> overriding the default values for counters which are not collected by the device.
>
> The 'reset' flag in 'get_eth_mac_stats' allows choosing between
> resetting the counter to recent most value or fecthing the aggregate
nit: fetching
> values of counters. This is important to cater for cases such as
> device reset.
>
> The 'fbnic_stat_rd64' read 64b stats counters in a consistent fashion using
> high-low-high approach. This allows to isolate cases where counter is
> wrapped between the reads.
>
> Command: ethtool -S eth0 --groups eth-mac
> Example Output:
> eth-mac-FramesTransmittedOK: 421644
> eth-mac-FramesReceivedOK: 3849708
> eth-mac-FrameCheckSequenceErrors: 0
> eth-mac-AlignmentErrors: 0
> eth-mac-OctetsTransmittedOK: 64799060
> eth-mac-FramesLostDueToIntMACXmitError: 0
> eth-mac-OctetsReceivedOK: 5134513531
> eth-mac-FramesLostDueToIntMACRcvError: 0
> eth-mac-MulticastFramesXmittedOK: 568
> eth-mac-BroadcastFramesXmittedOK: 454
> eth-mac-MulticastFramesReceivedOK: 276106
> eth-mac-BroadcastFramesReceivedOK: 26119
> eth-mac-FrameTooLongErrors: 0
>
> Signed-off-by: Mohsin Bashir <mohsin.bashr@gmail.com>
...
next prev parent reply other threads:[~2024-08-28 14:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 20:59 [PATCH net-next v2 0/2] eth: Add basic ethtool support for fbnic Mohsin Bashir
2024-08-27 20:59 ` [PATCH net-next v2 1/2] eth: fbnic: Add " Mohsin Bashir
2024-08-28 6:29 ` Michal Swiatkowski
2024-08-28 17:49 ` Mohsin Bashir
2024-08-28 18:18 ` Jakub Kicinski
2024-08-27 20:59 ` [PATCH net-next v2 2/2] eth: fbnic: Add support to fetch group stats Mohsin Bashir
2024-08-28 0:30 ` Nelson, Shannon
2024-08-28 16:41 ` Alexander H Duyck
2024-08-29 0:47 ` Mohsin Bashir
2024-08-28 14:37 ` Simon Horman [this message]
2024-08-28 17:50 ` Mohsin Bashir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240828143736.GH1368797@kernel.org \
--to=horms@kernel.org \
--cc=alexanderduyck@fb.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jdamato@fastly.com \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=mohsin.bashr@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sanmanpradhan@meta.com \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).