Re: [PATCH net] net: marvell: prestera: Remove unneeded check in prestera_port_create()

[Maxime Chevallier <maxime.chevallier@bootlin.com>]

Hello Aleksandr,

On Wed, 28 Aug 2024 16:26:06 +0300
Aleksandr Mishin <amishin@t-argos.ru> wrote:

> prestera_port_create() calls prestera_rxtx_port_init() and analyze its
> return code. prestera_rxtx_port_init() always returns 0, so this check is
> unneeded and should be removed.
> 
> Remove unneeded check to clean up the code.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Fixes: 501ef3066c89 ("net: marvell: prestera: Add driver for Prestera family ASIC devices")
> Signed-off-by: Aleksandr Mishin <amishin@t-argos.ru>
> ---
>  drivers/net/ethernet/marvell/prestera/prestera_main.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/marvell/prestera/prestera_main.c b/drivers/net/ethernet/marvell/prestera/prestera_main.c
> index 63ae01954dfc..2d4f6d03b729 100644
> --- a/drivers/net/ethernet/marvell/prestera/prestera_main.c
> +++ b/drivers/net/ethernet/marvell/prestera/prestera_main.c
> @@ -718,9 +718,7 @@ static int prestera_port_create(struct prestera_switch *sw, u32 id)
>  		}
>  	}
>  
> -	err = prestera_rxtx_port_init(port);
> -	if (err)
> -		goto err_port_init;
> +	prestera_rxtx_port_init(port);

If this function always return 0, you might as well change it to return
void. This would avoid future issues if one were to change
prestera_rxtx_port_init() to acually make it return something. It would
then become obvious that the caller doesn't check the return, whereas
with the current patch, we are simply ignoring it.

I also think you can target that patch to net-next, this isn't fixing
any bug, but rather cleans the code up.

Thanks,

Maxime