From: Jakub Kicinski <kuba@kernel.org>
To: Alexander Lobakin <aleksander.lobakin@intel.com>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>, <davem@davemloft.net>,
<pabeni@redhat.com>, <edumazet@google.com>,
<netdev@vger.kernel.org>, <przemyslaw.kitszel@intel.com>,
<joshua.a.hay@intel.com>, <michal.kubiak@intel.com>,
<nex.sw.ncis.osdt.itp.upstreaming@intel.com>
Subject: Re: [PATCH net-next v2 2/9] libeth: add common queue stats
Date: Thu, 29 Aug 2024 07:39:54 -0700 [thread overview]
Message-ID: <20240829073954.73ef0765@kernel.org> (raw)
In-Reply-To: <bf736d48-813e-4bdd-b33f-23bb1c7d4c0a@intel.com>
On Thu, 29 Aug 2024 14:01:06 +0200 Alexander Lobakin wrote:
> > Either way is fine by me. You may want to float the XDP stats first as
> > a smaller series, just extending the spec and exposing from some driver
> > already implementing qstat. In case someone else does object.
>
> I think I'll do that the following way. To not delay this series and XDP
> for idpf in general, I'll drop these stats for now, leaving only onstack
> containers (they will be used in libeth_xdp etc.), without the macro
> magic. But at the same time I'll work on extending the NL queue stats,
> incl. XDP ones, and send them separately when they're done. Would that
> be fine?
Modulo implementation details -- SGTM!
next prev parent reply other threads:[~2024-08-29 14:39 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 22:34 [PATCH net-next v2 0/9][pull request] idpf: XDP chapter II: convert Tx completion to libeth Tony Nguyen
2024-08-19 22:34 ` [PATCH net-next v2 1/9] unroll: add generic loop unroll helpers Tony Nguyen
2024-08-21 0:55 ` Jakub Kicinski
2024-08-22 15:15 ` Alexander Lobakin
2024-08-22 22:59 ` Jakub Kicinski
2024-08-22 23:35 ` Tony Nguyen
2024-08-23 12:37 ` Alexander Lobakin
2024-08-19 22:34 ` [PATCH net-next v2 2/9] libeth: add common queue stats Tony Nguyen
2024-08-21 1:17 ` Jakub Kicinski
2024-08-22 15:13 ` Alexander Lobakin
2024-08-22 23:17 ` Jakub Kicinski
2024-08-23 12:59 ` Alexander Lobakin
2024-08-27 1:09 ` Jakub Kicinski
2024-08-27 15:31 ` Alexander Lobakin
2024-08-27 18:29 ` Jakub Kicinski
2024-08-28 15:06 ` Alexander Lobakin
2024-08-28 20:22 ` Jakub Kicinski
2024-08-29 12:01 ` Alexander Lobakin
2024-08-29 14:39 ` Jakub Kicinski [this message]
2024-08-19 22:34 ` [PATCH net-next v2 3/9] libie: add Tx buffer completion helpers Tony Nguyen
2024-08-19 22:34 ` [PATCH net-next v2 4/9] idpf: convert to libie Tx buffer completion Tony Nguyen
2024-08-19 22:34 ` [PATCH net-next v2 5/9] netdevice: add netdev_tx_reset_subqueue() shorthand Tony Nguyen
2024-08-19 22:34 ` [PATCH net-next v2 6/9] idpf: refactor Tx completion routines Tony Nguyen
2024-08-19 22:34 ` [PATCH net-next v2 7/9] idpf: fix netdev Tx queue stop/wake Tony Nguyen
2024-08-19 22:34 ` [PATCH net-next v2 8/9] idpf: enable WB_ON_ITR Tony Nguyen
2024-08-19 22:34 ` [PATCH net-next v2 9/9] idpf: switch to libeth generic statistics Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240829073954.73ef0765@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=joshua.a.hay@intel.com \
--cc=michal.kubiak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nex.sw.ncis.osdt.itp.upstreaming@intel.com \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).