From: Jakub Kicinski <kuba@kernel.org>
To: Bharat Bhushan <bharatb.linux@gmail.com>
Cc: Bharat Bhushan <bbhushan2@marvell.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
sgoutham@marvell.com, gakula@marvell.com, sbhatta@marvell.com,
hkelam@marvell.com, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, jerinj@marvell.com, lcherian@marvell.com,
richardcochran@gmail.com
Subject: Re: [net-next PATCH v7 1/8] octeontx2-pf: map skb data as device writeable
Date: Thu, 29 Aug 2024 07:48:32 -0700 [thread overview]
Message-ID: <20240829074832.0f091f53@kernel.org> (raw)
In-Reply-To: <CAAeCc_=3vXvRgo1wxzHwSY6LJS-vUzeShSdJKLotYSuHBi-Vzw@mail.gmail.com>
On Thu, 29 Aug 2024 11:17:25 +0530 Bharat Bhushan wrote:
> > How did you test this prior to adding skb_unshare()?
> > Could you share some performance data with this change?
>
> testing using flood ping and iperf with multiple instance,
Makes sense, neither of these will detect corruption of data pages :(
IIRC iperf just ignores the data, ping doesn't retransmit.
You gotta beef up your testing...
> I do not see any drop in performance numbers
Well. What's the difference in CPU busy time of v5 vs v7?
You'll copy all TCP packets, they are (pretty much) all clones.
next prev parent reply other threads:[~2024-08-29 14:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 13:32 [net-next PATCH v7 0/8] cn10k-ipsec: Add outbound inline ipsec support Bharat Bhushan
2024-08-27 13:32 ` [net-next PATCH v7 1/8] octeontx2-pf: map skb data as device writeable Bharat Bhushan
2024-08-29 1:21 ` Jakub Kicinski
2024-08-29 5:47 ` Bharat Bhushan
2024-08-29 14:48 ` Jakub Kicinski [this message]
2024-09-02 5:48 ` Bharat Bhushan
2024-08-27 13:32 ` [net-next PATCH v7 2/8] octeontx2-pf: Move skb fragment map/unmap to common code Bharat Bhushan
2024-08-27 13:32 ` [net-next PATCH v7 3/8] octeontx2-af: Disable backpressure between CPT and NIX Bharat Bhushan
2024-08-27 13:32 ` [net-next PATCH v7 4/8] cn10k-ipsec: Init hardware for outbound ipsec crypto offload Bharat Bhushan
2024-08-27 13:32 ` [net-next PATCH v7 5/8] cn10k-ipsec: Add SA add/del support for outb " Bharat Bhushan
2024-08-27 13:32 ` [net-next PATCH v7 6/8] cn10k-ipsec: Process outbound " Bharat Bhushan
2024-08-27 13:32 ` [net-next PATCH v7 7/8] cn10k-ipsec: Allow ipsec crypto offload for skb with SA Bharat Bhushan
2024-08-27 13:32 ` [net-next PATCH v7 8/8] cn10k-ipsec: Enable outbound ipsec crypto offload Bharat Bhushan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240829074832.0f091f53@kernel.org \
--to=kuba@kernel.org \
--cc=bbhushan2@marvell.com \
--cc=bharatb.linux@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=jerinj@marvell.com \
--cc=lcherian@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).