Re: [patch net-next v4] ethtool: pse-pd: move pse validation into set

[Maxime Chevallier <maxime.chevallier@bootlin.com>]

Hi Diogo,

On Wed, 28 Aug 2024 14:43:17 -0300
Diogo Jahchan Koike <djahchankoike@gmail.com> wrote:

> Move validation into set, removing .set_validate operation as its current
> implementation holds the rtnl lock for acquiring the PHY device, defeating
> the intended purpose of checking before grabbing the lock.

[...] 

>  static int
> -ethnl_set_pse_validate(struct ethnl_req_info *req_info, struct genl_info *info)
> +ethnl_set_pse_validate(struct phy_device *phydev, struct genl_info *info)
>  {
>  	struct nlattr **tb = info->attrs;
> -	struct phy_device *phydev;
> -
> -	phydev = ethnl_req_get_phydev(req_info, tb[ETHTOOL_A_PSE_HEADER],
> -				      info->extack);
> +	
   ^^^
You have an extra white space here. Make sure you run your patch through
the checkpatch script to detect this kind of issues.

The rest looks good to me. For the next version,

Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>

Thanks,

Maxime