From: Jakub Kicinski <kuba@kernel.org>
To: Hongbo Li <lihongbo22@huawei.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<dsahern@kernel.org>, <ralf@linux-mips.org>, <jmaloy@redhat.com>,
<ying.xue@windriver.com>, <dan.carpenter@linaro.org>,
<netdev@vger.kernel.org>, <linux-hams@vger.kernel.org>,
<netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH net-next v2 0/6] replace deprecated strcpy with strscpy
Date: Thu, 29 Aug 2024 12:36:47 -0700 [thread overview]
Message-ID: <20240829123647.32aaeb17@kernel.org> (raw)
In-Reply-To: <20240828123224.3697672-1-lihongbo22@huawei.com>
On Wed, 28 Aug 2024 20:32:18 +0800 Hongbo Li wrote:
> The deprecated helper strcpy() performs no bounds checking on the
> destination buffer. This could result in linear overflows beyond
> the end of the buffer, leading to all kinds of misbehaviors.
> The safe replacement is strscpy() [1].
What's you plan? Are you going to send 200 patches like this
just for networking?
$ git grep strcpy -- net/ drivers/net/ | wc -l
199
Please don't. I'll look thru this series but it feels like such
a waste of time.
next prev parent reply other threads:[~2024-08-29 19:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 12:32 [PATCH net-next v2 0/6] replace deprecated strcpy with strscpy Hongbo Li
2024-08-28 12:32 ` [PATCH net-next v2 1/6] net: prefer strscpy over strcpy Hongbo Li
2024-08-28 12:32 ` [PATCH net-next v2 2/6] net/ipv6: replace deprecated strcpy with strscpy Hongbo Li
2024-08-28 12:32 ` [PATCH net-next v2 3/6] net/netrom: prefer strscpy over strcpy Hongbo Li
2024-08-28 12:32 ` [PATCH net-next v2 4/6] net/netfilter: replace deprecated strcpy with strscpy Hongbo Li
2024-08-28 12:32 ` [PATCH net-next v2 5/6] net/tipc: " Hongbo Li
2024-08-28 12:32 ` [PATCH net-next v2 6/6] net/ipv4: net: prefer strscpy over strcpy Hongbo Li
2024-08-29 19:36 ` Jakub Kicinski [this message]
2024-08-29 19:50 ` [PATCH net-next v2 0/6] replace deprecated strcpy with strscpy patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240829123647.32aaeb17@kernel.org \
--to=kuba@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=jmaloy@redhat.com \
--cc=lihongbo22@huawei.com \
--cc=linux-hams@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ralf@linux-mips.org \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).