From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from flow5-smtp.messagingengine.com (flow5-smtp.messagingengine.com [103.168.172.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40754EAD5 for ; Thu, 29 Aug 2024 20:44:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.140 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724964280; cv=none; b=EsDB+jQB3xGn8tMOJHj0yqJlCrk6KCgrTHTnX3iF7T0nY4LeBuQy0YAwWNFJ5KRzi8HgBb8hCMM8/eYcu18IN5noJzWV60GnrsaatlhT3EewUpFc6Prcdeu1BaAq7lkALDeA5PyexhZxym6zyNmW7mXQP4DFVPIN7g1gxC9ShIg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724964280; c=relaxed/simple; bh=3c+LxsPSerQXVA35hjXHOGW3vBqqo1V8JbKGSzdJkAg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WtJyx887Jh3RKE646nRY5tXjHj2QfP16dTD2wSBh1wxAWay3tye/ciuI4+hZgkFwtreCdk8zq05qRoPsmrtKhNJCbq6xESLWXIUdsrBuAEbeA9Ac/PTA/JHhPlZE1A6xf1TNyaUBAQhrQ4iC8nKR7qicafuHdY4e02+sk1CDb84= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ragnatech.se; spf=pass smtp.mailfrom=ragnatech.se; dkim=pass (2048-bit key) header.d=ragnatech.se header.i=@ragnatech.se header.b=Ps17Oqv2; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=tcHp4T7C; arc=none smtp.client-ip=103.168.172.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ragnatech.se Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ragnatech.se Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ragnatech.se header.i=@ragnatech.se header.b="Ps17Oqv2"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="tcHp4T7C" Received: from phl-compute-03.internal (phl-compute-03.nyi.internal [10.202.2.43]) by mailflow.nyi.internal (Postfix) with ESMTP id A77BC200EC0; Thu, 29 Aug 2024 16:44:34 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-03.internal (MEProxy); Thu, 29 Aug 2024 16:44:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech.se; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1724964274; x=1724971474; bh=oGtWUSV+gMrRLDX6LoVsoBOQBNaadyxH7aU0cLUuoJg=; b= Ps17Oqv2Jg7sEtygs5+50rMDTeIh0NoS5R41M+lofmWN3O1kgY16P0qc1HRuji9O UQQQ2bokkROnVoYHm65cuH7ruLDcQMjU5ZGMRq7lDNozfJVioIeIMEY8z8bGAuOd NLGCn1NMOXX84MA2gcmkgMYEg2mBQy83CZQulJ06vInzah6KnjmWD9H9NkkmbUEX 2w6uO71PKA4S5zAy2jnwGirEcEXo4vveBB/ujdZycc/tDFOB3YIpWc23vXOa+0hT fRvX52M+grcQHHZywwsiBY3urthfbSuCrq8zIWu4AnjiOY+/QbwlmTPIs4XIpaBo JKypgGFJXTgl1+M5JTSQDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1724964274; x= 1724971474; bh=oGtWUSV+gMrRLDX6LoVsoBOQBNaadyxH7aU0cLUuoJg=; b=t cHp4T7CvyhpJz1IndkD6sm3uIUv+n7lv/Ta+3b+f3c7IxFOBRq7Q3b87f0wxej0/ W3t2hOMU0jpt05Eq1LvH6GjLAha2DSAf+79cKerWNCHMtU5LSVrkIeY0v+IqhmFp QXjHynfimrrKWmtQyN8yU3reb3fltr+av3jlkaDdXFvHATqxucZfUqjmdNhakS12 tsq2r26tNNORC3j1dbgy2wSvxbZskGYJJQycjVKpHyvN0wMDlmI3Hvqkw3AcA5vj FIfFkl7pLb12mGwDS0xNwtGgxCdPWaHkJ/r1SEZJCOIZSiMlJQNjJm2pKoy03Vy8 tTI8ELyDkAJH4nefqNNdg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudefgedgudehudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpeffhffvvefukfhfgggtugfgjgesthekredttddt jeenucfhrhhomheppfhikhhlrghsucfunpguvghrlhhunhguuceonhhikhhlrghsrdhsoh guvghrlhhunhgusehrrghgnhgrthgvtghhrdhsvgeqnecuggftrfgrthhtvghrnhepveet gedtvddvhfdtkeeghfeffeehteehkeekgeefjeduieduueelgedtheekkeetnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepnhhikhhlrghsrdhs ohguvghrlhhunhgusehrrghgnhgrthgvtghhrdhsvgdpnhgspghrtghpthhtohepiedvpd hmohguvgepshhmthhpohhuthdprhgtphhtthhopehgrghlsehnvhhiughirgdrtghomhdp rhgtphhtthhopegurghvvghmsegurghvvghmlhhofhhtrdhnvghtpdhrtghpthhtohepkh husggrsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehnvghtuggvvhesvhhgvghrrdhk vghrnhgvlhdrohhrghdprhgtphhtthhopehjvhesjhhvohhssghurhhghhdrnhgvthdprh gtphhtthhopegrnhguhiesghhrvgihhhhouhhsvgdrnhgvthdprhgtphhtthhopehmkhhl sehpvghnghhuthhrohhnihigrdguvgdprhgtphhtthhopehmrghilhhhohhlrdhvihhntg gvnhhtseifrghnrgguohhordhfrhdprhgtphhtthhopehshhihrghmqdhsuhhnuggrrhdr shdqkhesrghmugdrtghomh X-ME-Proxy: Feedback-ID: i80c9496c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 29 Aug 2024 16:44:31 -0400 (EDT) Date: Thu, 29 Aug 2024 22:44:29 +0200 From: Niklas =?utf-8?Q?S=C3=B6derlund?= To: Gal Pressman Cc: "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, Jay Vosburgh , Andy Gospodarek , Marc Kleine-Budde , Vincent Mailhol , Shyam Sundar S K , Sudarsana Kalluru , Manish Chopra , Michael Chan , Pavan Chebbi , Nicolas Ferre , Claudiu Beznea , Sunil Goutham , Potnuri Bharat Teja , Christian Benvenuti , Satish Kharat , Claudiu Manoil , Vladimir Oltean , Wei Fang , Shenwei Wang , Clark Wang , Dimitris Michailidis , Yisen Zhuang , Salil Mehta , Jijie Shao , Tony Nguyen , Przemek Kitszel , Marcin Wojtas , Russell King , Geetha sowjanya , Subbaraya Sundeep , hariprasad , Ido Schimmel , Petr Machata , Bryan Whitehead , UNGLinuxDriver@microchip.com, Horatiu Vultur , Lars Povlsen , Steen Hegelund , Daniel Machon , Alexandre Belloni , Shannon Nelson , Brett Creeley , Sergey Shtylyov , Yoshihiro Shimoda , Edward Cree , Martin Habets , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Siddharth Vadapalli , Roger Quadros , MD Danish Anwar , Linus Walleij , Imre Kaloz , Richard Cochran , Willem de Bruijn , Carolina Jubran , Rahul Rameshbabu Subject: Re: [PATCH net-next 2/2] net: Remove setting of RX software timestamp from drivers Message-ID: <20240829204429.GA3708622@ragnatech.se> References: <20240829144253.122215-1-gal@nvidia.com> <20240829144253.122215-3-gal@nvidia.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240829144253.122215-3-gal@nvidia.com> Hi Gal, Thanks for your work. On 2024-08-29 17:42:53 +0300, Gal Pressman wrote: > diff --git a/drivers/net/ethernet/renesas/ravb_main.c > b/drivers/net/ethernet/renesas/ravb_main.c > index c02fb296bf7d..c7ec23688d56 100644 > --- a/drivers/net/ethernet/renesas/ravb_main.c > +++ b/drivers/net/ethernet/renesas/ravb_main.c > @@ -1744,8 +1744,6 @@ static int ravb_get_ts_info(struct net_device *ndev, > > info->so_timestamping = > SOF_TIMESTAMPING_TX_SOFTWARE | > - SOF_TIMESTAMPING_RX_SOFTWARE | > - SOF_TIMESTAMPING_SOFTWARE | > SOF_TIMESTAMPING_TX_HARDWARE | > SOF_TIMESTAMPING_RX_HARDWARE | > SOF_TIMESTAMPING_RAW_HARDWARE; > @@ -1756,6 +1754,8 @@ static int ravb_get_ts_info(struct net_device *ndev, > (1 << HWTSTAMP_FILTER_ALL); > if (hw_info->gptp || hw_info->ccc_gac) > info->phc_index = ptp_clock_index(priv->ptp.clock); > + else > + info->phc_index = 0; I understand this work keeps things the same as they where before and that this change do not alter the existing behavior. But should not phc_index be left untouched here (kept at -1) as there are no ptp clock? I think this might have been introduced in commit 7e09a052dc4e ("ravb: Exclude gPTP feature support for RZ/G2L") when the driver excluded ptp support for some devices. I suspect the so_timestamping mask should also depend on this check and only advertise hardware clocks if it indeed exists? If my assumption is correct I can fix this on top. For this change the existing behavior is kept, so for drivers/net/ethernet/renesas, Reviewed-by: Niklas Söderlund > > return 0; > } -- Kind Regards, Niklas Söderlund