netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Yue Haibing <yuehaibing@huawei.com>
Cc: bharat@chelsio.com, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/3] cxgb4: Remove unused declarations
Date: Fri, 30 Aug 2024 08:35:53 +0100	[thread overview]
Message-ID: <20240830073553.GF1368797@kernel.org> (raw)
In-Reply-To: <20240829123707.2276148-3-yuehaibing@huawei.com>

On Thu, Aug 29, 2024 at 08:37:06PM +0800, Yue Haibing wrote:
> Commit e2d14b42c25c ("cxgb4: Remove WOL get/set ethtool support") removed
> t4_wol_magic_enable() and t4_wol_pat_enable() but leave declarations.
> 
> Commit 02d805dc5fe3 ("cxgb4: use new fw interface to get the VIN and smt
> index") leave behind cxgb4_tp_smt_idx().
> 
> cxgb4_dcb_set_caps() is never implemented and used since introduction in
> commit 76bcb31efc06 ("cxgb4 : Add DCBx support codebase and dcbnl_ops").
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>

Thanks, I agree with your analysis.

Reviewed-by: Simon Horman <horms@kernel.org>


  reply	other threads:[~2024-08-30  7:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-29 12:37 [PATCH net-next 0/3] cleanup chelsio driver declarations Yue Haibing
2024-08-29 12:37 ` [PATCH net-next 1/3] cxgb3: Remove unused declarations Yue Haibing
2024-08-30  7:35   ` Simon Horman
2024-08-29 12:37 ` [PATCH net-next 2/3] cxgb4: " Yue Haibing
2024-08-30  7:35   ` Simon Horman [this message]
2024-08-29 12:37 ` [PATCH net-next 3/3] cxgb: " Yue Haibing
2024-08-30  7:36   ` Simon Horman
2024-08-30  9:23     ` Yue Haibing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240830073553.GF1368797@kernel.org \
    --to=horms@kernel.org \
    --cc=bharat@chelsio.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).