[PATCH net-next 0/3] cleanup chelsio driver declarations

[PATCH net-next 0/3] cleanup chelsio driver declarations

[Yue Haibing]

Yue Haibing (3):
  cxgb3: Remove unused declarations
  cxgb4: Remove unused declarations
  cxgb: Remove unused declarations

 drivers/net/ethernet/chelsio/cxgb/common.h      | 2 --
 drivers/net/ethernet/chelsio/cxgb/tp.h          | 2 --
 drivers/net/ethernet/chelsio/cxgb3/cxgb3_defs.h | 2 --
 drivers/net/ethernet/chelsio/cxgb4/cxgb4.h      | 5 -----
 drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.h  | 1 -
 drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.h  | 1 -
 6 files changed, 13 deletions(-)

-- 
2.34.1

[PATCH net-next 1/3] cxgb3: Remove unused declarations

[Yue Haibing]

Commit 4d22de3e6cc4 ("Add support for the latest 1G/10G Chelsio adapter,
T3.") declared but never implemented these.

Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
 drivers/net/ethernet/chelsio/cxgb3/cxgb3_defs.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_defs.h b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_defs.h
index f04e81f33795..a08fc762a438 100644
--- a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_defs.h
+++ b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_defs.h
@@ -106,6 +106,4 @@ static inline struct t3c_tid_entry *lookup_atid(const struct tid_info *t,
 	return &e->t3c_tid;
 }
 
-int attach_t3cdev(struct t3cdev *dev);
-void detach_t3cdev(struct t3cdev *dev);
 #endif
-- 
2.34.1

[PATCH net-next 2/3] cxgb4: Remove unused declarations

[Yue Haibing]

Commit e2d14b42c25c ("cxgb4: Remove WOL get/set ethtool support") removed
t4_wol_magic_enable() and t4_wol_pat_enable() but leave declarations.

Commit 02d805dc5fe3 ("cxgb4: use new fw interface to get the VIN and smt
index") leave behind cxgb4_tp_smt_idx().

cxgb4_dcb_set_caps() is never implemented and used since introduction in
commit 76bcb31efc06 ("cxgb4 : Add DCBx support codebase and dcbnl_ops").

Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
 drivers/net/ethernet/chelsio/cxgb4/cxgb4.h     | 5 -----
 drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.h | 1 -
 drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.h | 1 -
 3 files changed, 7 deletions(-)

diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4.h b/drivers/net/ethernet/chelsio/cxgb4/cxgb4.h
index fca9533bc011..bbf7641a0fc7 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4.h
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4.h
@@ -1958,11 +1958,6 @@ void t4_ulprx_read_la(struct adapter *adap, u32 *la_buf);
 void t4_get_chan_txrate(struct adapter *adap, u64 *nic_rate, u64 *ofld_rate);
 void t4_mk_filtdelwr(unsigned int ftid, struct fw_filter_wr *wr, int qid);
 
-void t4_wol_magic_enable(struct adapter *adap, unsigned int port,
-			 const u8 *addr);
-int t4_wol_pat_enable(struct adapter *adap, unsigned int port, unsigned int map,
-		      u64 mask0, u64 mask1, unsigned int crc, bool enable);
-
 int t4_fw_hello(struct adapter *adap, unsigned int mbox, unsigned int evt_mbox,
 		enum dev_master master, enum dev_state *state);
 int t4_fw_bye(struct adapter *adap, unsigned int mbox);
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.h b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.h
index 80c6627fe981..c80a93347a8c 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.h
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.h
@@ -122,7 +122,6 @@ void cxgb4_dcb_version_init(struct net_device *);
 void cxgb4_dcb_reset(struct net_device *dev);
 void cxgb4_dcb_state_fsm(struct net_device *, enum cxgb4_dcb_state_input);
 void cxgb4_dcb_handle_fw_update(struct adapter *, const struct fw_port_cmd *);
-void cxgb4_dcb_set_caps(struct adapter *, const struct fw_port_cmd *);
 extern const struct dcbnl_rtnl_ops cxgb4_dcb_ops;
 
 static inline __u8 bitswap_1(unsigned char val)
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.h b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.h
index a9599ba26975..d8cafaa7ddb4 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.h
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.h
@@ -508,7 +508,6 @@ unsigned int cxgb4_dbfifo_count(const struct net_device *dev, int lpfifo);
 unsigned int cxgb4_port_chan(const struct net_device *dev);
 unsigned int cxgb4_port_e2cchan(const struct net_device *dev);
 unsigned int cxgb4_port_viid(const struct net_device *dev);
-unsigned int cxgb4_tp_smt_idx(enum chip_type chip, unsigned int viid);
 unsigned int cxgb4_port_idx(const struct net_device *dev);
 unsigned int cxgb4_best_mtu(const unsigned short *mtus, unsigned short mtu,
 			    unsigned int *idx);
-- 
2.34.1

[PATCH net-next 3/3] cxgb: Remove unused declarations

[Yue Haibing]

These were never implenmented since introduction in commit 4d22de3e6cc4
("Add support for the latest 1G/10G Chelsio adapter, T3.").

Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
 drivers/net/ethernet/chelsio/cxgb/common.h | 2 --
 drivers/net/ethernet/chelsio/cxgb/tp.h     | 2 --
 2 files changed, 4 deletions(-)

diff --git a/drivers/net/ethernet/chelsio/cxgb/common.h b/drivers/net/ethernet/chelsio/cxgb/common.h
index e56eff701395..304bb282ab03 100644
--- a/drivers/net/ethernet/chelsio/cxgb/common.h
+++ b/drivers/net/ethernet/chelsio/cxgb/common.h
@@ -329,8 +329,6 @@ irqreturn_t t1_slow_intr_handler(adapter_t *adapter);
 
 int t1_link_start(struct cphy *phy, struct cmac *mac, struct link_config *lc);
 const struct board_info *t1_get_board_info(unsigned int board_id);
-const struct board_info *t1_get_board_info_from_ids(unsigned int devid,
-						    unsigned short ssid);
 int t1_seeprom_read(adapter_t *adapter, u32 addr, __le32 *data);
 int t1_get_board_rev(adapter_t *adapter, const struct board_info *bi,
 		     struct adapter_params *p);
diff --git a/drivers/net/ethernet/chelsio/cxgb/tp.h b/drivers/net/ethernet/chelsio/cxgb/tp.h
index ba15675d56df..64f93dcc676b 100644
--- a/drivers/net/ethernet/chelsio/cxgb/tp.h
+++ b/drivers/net/ethernet/chelsio/cxgb/tp.h
@@ -65,9 +65,7 @@ void t1_tp_intr_enable(struct petp *tp);
 void t1_tp_intr_clear(struct petp *tp);
 int t1_tp_intr_handler(struct petp *tp);
 
-void t1_tp_get_mib_statistics(adapter_t *adap, struct tp_mib_statistics *tps);
 void t1_tp_set_tcp_checksum_offload(struct petp *tp, int enable);
 void t1_tp_set_ip_checksum_offload(struct petp *tp, int enable);
-int t1_tp_set_coalescing_size(struct petp *tp, unsigned int size);
 int t1_tp_reset(struct petp *tp, struct tp_params *p, unsigned int tp_clk);
 #endif
-- 
2.34.1

Re: [PATCH net-next 1/3] cxgb3: Remove unused declarations

[Simon Horman]

On Thu, Aug 29, 2024 at 08:37:05PM +0800, Yue Haibing wrote:
> Commit 4d22de3e6cc4 ("Add support for the latest 1G/10G Chelsio adapter,
> T3.") declared but never implemented these.
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>

Thanks, I agree with your analysis.

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [PATCH net-next 2/3] cxgb4: Remove unused declarations

[Simon Horman]

On Thu, Aug 29, 2024 at 08:37:06PM +0800, Yue Haibing wrote:
> Commit e2d14b42c25c ("cxgb4: Remove WOL get/set ethtool support") removed
> t4_wol_magic_enable() and t4_wol_pat_enable() but leave declarations.
> 
> Commit 02d805dc5fe3 ("cxgb4: use new fw interface to get the VIN and smt
> index") leave behind cxgb4_tp_smt_idx().
> 
> cxgb4_dcb_set_caps() is never implemented and used since introduction in
> commit 76bcb31efc06 ("cxgb4 : Add DCBx support codebase and dcbnl_ops").
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>

Thanks, I agree with your analysis.

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [PATCH net-next 3/3] cxgb: Remove unused declarations

[Simon Horman]

On Thu, Aug 29, 2024 at 08:37:07PM +0800, Yue Haibing wrote:
> These were never implenmented since introduction in commit 4d22de3e6cc4
> ("Add support for the latest 1G/10G Chelsio adapter, T3.").
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>

Hi,

I agree that these were never implemented, but I think the at the
correct citation is:

commit 8199d3a79c22 ("[PATCH] A new 10GB Ethernet Driver by Chelsio Communications")

...

Re: [PATCH net-next 3/3] cxgb: Remove unused declarations

[Yue Haibing]

On 2024/8/30 15:36, Simon Horman wrote:
> On Thu, Aug 29, 2024 at 08:37:07PM +0800, Yue Haibing wrote:
>> These were never implenmented since introduction in commit 4d22de3e6cc4
>> ("Add support for the latest 1G/10G Chelsio adapter, T3.").
>>
>> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> 
> Hi,
> 
> I agree that these were never implemented, but I think the at the
> correct citation is:
> 
> commit 8199d3a79c22 ("[PATCH] A new 10GB Ethernet Driver by Chelsio Communications")

Indeed, I missed this one, thanks!

> 
> ...
> .