From: Jakub Kicinski <kuba@kernel.org>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
linux-can@vger.kernel.org, kernel@pengutronix.de,
Martin Jocic <martin.jocic@kvaser.com>
Subject: Re: [PATCH net 13/13] can: kvaser_pciefd: Enable 64-bit DMA addressing
Date: Fri, 30 Aug 2024 13:17:24 -0700 [thread overview]
Message-ID: <20240830131724.7c08eac4@kernel.org> (raw)
In-Reply-To: <20240829192947.1186760-14-mkl@pengutronix.de>
On Thu, 29 Aug 2024 21:20:46 +0200 Marc Kleine-Budde wrote:
> + if (IS_ENABLED(CONFIG_ARCH_DMA_ADDR_T_64BIT))
> + dma_set_mask_and_coherent(&pcie->pci->dev, DMA_BIT_MASK(64));
This IS_ENABLED() is quite unusual. The driver just advertises its
capability of using 64 addressing. If the platform doesn't support
64b DMA addressing and therefore dma_addr_t is narrower, everything
will still work. I could be wrong, but that's how I understand it.
next prev parent reply other threads:[~2024-08-30 20:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 19:20 [PATCH net 0/13] pull-request: can 2024-08-29 Marc Kleine-Budde
2024-08-29 19:20 ` [PATCH net 01/13] can: bcm: Remove proc entry when dev is unregistered Marc Kleine-Budde
2024-08-29 19:20 ` [PATCH net 02/13] can: m_can: Release irq on error in m_can_open Marc Kleine-Budde
2024-08-29 19:20 ` [PATCH net 03/13] can: m_can: Reset coalescing during suspend/resume Marc Kleine-Budde
2024-08-29 19:20 ` [PATCH net 04/13] can: m_can: Remove coalesing disable in isr during suspend Marc Kleine-Budde
2024-08-29 19:20 ` [PATCH net 05/13] can: m_can: Remove m_can_rx_peripheral indirection Marc Kleine-Budde
2024-08-29 19:20 ` [PATCH net 06/13] can: m_can: Do not cancel timer from within timer Marc Kleine-Budde
2024-08-29 19:20 ` [PATCH net 07/13] can: m_can: disable_all_interrupts, not clear active_interrupts Marc Kleine-Budde
2024-08-29 19:20 ` [PATCH net 08/13] can: m_can: Reset cached active_interrupts on start Marc Kleine-Budde
2024-08-29 19:20 ` [PATCH net 09/13] can: m_can: Limit coalescing to peripheral instances Marc Kleine-Budde
2024-08-29 19:20 ` [PATCH net 10/13] can: mcp251xfd: fix ring configuration when switching from CAN-CC to CAN-FD mode Marc Kleine-Budde
2024-08-29 19:20 ` [PATCH net 11/13] can: mcp251xfd: mcp251xfd_ring_init(): check TX-coalescing configuration Marc Kleine-Budde
2024-08-29 19:20 ` [PATCH net 12/13] can: mcp251x: fix deadlock if an interrupt occurs during mcp251x_open Marc Kleine-Budde
2024-08-29 19:20 ` [PATCH net 13/13] can: kvaser_pciefd: Enable 64-bit DMA addressing Marc Kleine-Budde
2024-08-30 20:17 ` Jakub Kicinski [this message]
2024-08-30 22:03 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240830131724.7c08eac4@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=kernel@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=martin.jocic@kvaser.com \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).