From: Simon Horman <horms@kernel.org>
To: Steffen Klassert <steffen.klassert@secunet.com>,
Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Florian Westphal <fw@strlen.de>,
netdev@vger.kernel.org,
Naresh Kamboju <naresh.kamboju@linaro.org>,
Nathan Chancellor <nathan@kernel.org>
Subject: Re: [PATCH ipsec-next] xfrm: Initialise dir in xfrm_hash_rebuild()
Date: Sat, 31 Aug 2024 09:25:49 +0100 [thread overview]
Message-ID: <20240831082549.GD4063074@kernel.org> (raw)
In-Reply-To: <20240830-xfrm_hash_rebuild-dir-v1-1-f75092d07e1b@kernel.org>
+ Nathan
On Fri, Aug 30, 2024 at 06:01:50PM +0100, Simon Horman wrote:
> The cited commit removed the initialisation of dir in one place too
> many: it is still used within the loop this patch updates.
>
> Compile tested only.
>
> Fixes: 08c2182cf0b4 ("xfrm: policy: use recently added helper in more places")
> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> Closes: https://lore.kernel.org/netdev/CA+G9fYtemFfuhc7=eNyP3TezM9Euc8sFtHe4GDR4Z9XdHzXSJA@mail.gmail.com/
> Signed-off-by: Simon Horman <horms@kernel.org>
Nathan advises me that this fix is incomplete and
that he has sent a complete fix here:
https://lore.kernel.org/all/20240829-xfrm-restore-dir-assign-xfrm_hash_rebuild-v2-1-1cf8958f6e8e@kernel.org/
--
pw-bot: rejected
prev parent reply other threads:[~2024-08-31 8:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 17:01 [PATCH ipsec-next] xfrm: Initialise dir in xfrm_hash_rebuild() Simon Horman
2024-08-31 8:25 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240831082549.GD4063074@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=herbert@gondor.apana.org.au \
--cc=kuba@kernel.org \
--cc=naresh.kamboju@linaro.org \
--cc=nathan@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).