* [PATCH net-next v2 01/15] ethtool: RX software timestamp for all
2024-09-01 11:27 [PATCH net-next v2 00/15] RX software timestamp for all Gal Pressman
@ 2024-09-01 11:27 ` Gal Pressman
2024-09-01 11:27 ` [PATCH net-next v2 02/15] can: dev: Remove setting of RX software timestamp Gal Pressman
` (14 subsequent siblings)
15 siblings, 0 replies; 20+ messages in thread
From: Gal Pressman @ 2024-09-01 11:27 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski
Cc: netdev, Jay Vosburgh, Andy Gospodarek, Marc Kleine-Budde,
Vincent Mailhol, Shyam Sundar S K, Sudarsana Kalluru,
Manish Chopra, Michael Chan, Pavan Chebbi, Nicolas Ferre,
Claudiu Beznea, Sunil Goutham, Potnuri Bharat Teja,
Christian Benvenuti, Satish Kharat, Claudiu Manoil,
Vladimir Oltean, Wei Fang, Shenwei Wang, Clark Wang,
Dimitris Michailidis, Yisen Zhuang, Salil Mehta, Jijie Shao,
Tony Nguyen, Przemek Kitszel, Marcin Wojtas, Russell King,
Geetha sowjanya, Subbaraya Sundeep, hariprasad, Ido Schimmel,
Petr Machata, Bryan Whitehead, UNGLinuxDriver, Horatiu Vultur,
Lars Povlsen, Steen Hegelund, Daniel Machon, Alexandre Belloni,
Shannon Nelson, Brett Creeley, Sergey Shtylyov, Yoshihiro Shimoda,
Niklas Söderlund, Edward Cree, Martin Habets,
Alexandre Torgue, Jose Abreu, Maxime Coquelin,
Siddharth Vadapalli, Roger Quadros, MD Danish Anwar,
Linus Walleij, Imre Kaloz, Richard Cochran, Willem de Bruijn,
Gal Pressman, Rahul Rameshbabu, Willem de Bruijn
All devices support SOF_TIMESTAMPING_RX_SOFTWARE by virtue of
net_timestamp_check() being called in the device independent code.
Move the responsibility of reporting SOF_TIMESTAMPING_RX_SOFTWARE and
SOF_TIMESTAMPING_SOFTWARE, and setting PHC index to -1 to the core.
Device drivers no longer need to use them.
Suggested-by: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Link: https://lore.kernel.org/netdev/661550e348224_23a2b2294f7@willemb.c.googlers.com.notmuch/
Co-developed-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
Signed-off-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
Signed-off-by: Gal Pressman <gal@nvidia.com>
Reviewed-by: Marc Kleine-Budde <mkl@pengutronix.de>
Reviewed-by: Willem de Bruijn <willemb@google.com>
---
net/ethtool/common.c | 19 ++++++++++---------
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/net/ethtool/common.c b/net/ethtool/common.c
index 7257ae272296..aa7010f97152 100644
--- a/net/ethtool/common.c
+++ b/net/ethtool/common.c
@@ -695,20 +695,21 @@ int __ethtool_get_ts_info(struct net_device *dev, struct kernel_ethtool_ts_info
{
const struct ethtool_ops *ops = dev->ethtool_ops;
struct phy_device *phydev = dev->phydev;
+ int err = 0;
memset(info, 0, sizeof(*info));
info->cmd = ETHTOOL_GET_TS_INFO;
-
- if (phy_is_default_hwtstamp(phydev) && phy_has_tsinfo(phydev))
- return phy_ts_info(phydev, info);
- if (ops->get_ts_info)
- return ops->get_ts_info(dev, info);
-
- info->so_timestamping = SOF_TIMESTAMPING_RX_SOFTWARE |
- SOF_TIMESTAMPING_SOFTWARE;
info->phc_index = -1;
- return 0;
+ if (phy_is_default_hwtstamp(phydev) && phy_has_tsinfo(phydev))
+ err = phy_ts_info(phydev, info);
+ else if (ops->get_ts_info)
+ err = ops->get_ts_info(dev, info);
+
+ info->so_timestamping |= SOF_TIMESTAMPING_RX_SOFTWARE |
+ SOF_TIMESTAMPING_SOFTWARE;
+
+ return err;
}
int ethtool_get_phc_vclocks(struct net_device *dev, int **vclock_index)
--
2.40.1
^ permalink raw reply related [flat|nested] 20+ messages in thread* [PATCH net-next v2 02/15] can: dev: Remove setting of RX software timestamp
2024-09-01 11:27 [PATCH net-next v2 00/15] RX software timestamp for all Gal Pressman
2024-09-01 11:27 ` [PATCH net-next v2 01/15] ethtool: " Gal Pressman
@ 2024-09-01 11:27 ` Gal Pressman
2024-09-01 11:27 ` [PATCH net-next v2 03/15] can: peak_canfd: " Gal Pressman
` (13 subsequent siblings)
15 siblings, 0 replies; 20+ messages in thread
From: Gal Pressman @ 2024-09-01 11:27 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski
Cc: netdev, Jay Vosburgh, Andy Gospodarek, Marc Kleine-Budde,
Vincent Mailhol, Shyam Sundar S K, Sudarsana Kalluru,
Manish Chopra, Michael Chan, Pavan Chebbi, Nicolas Ferre,
Claudiu Beznea, Sunil Goutham, Potnuri Bharat Teja,
Christian Benvenuti, Satish Kharat, Claudiu Manoil,
Vladimir Oltean, Wei Fang, Shenwei Wang, Clark Wang,
Dimitris Michailidis, Yisen Zhuang, Salil Mehta, Jijie Shao,
Tony Nguyen, Przemek Kitszel, Marcin Wojtas, Russell King,
Geetha sowjanya, Subbaraya Sundeep, hariprasad, Ido Schimmel,
Petr Machata, Bryan Whitehead, UNGLinuxDriver, Horatiu Vultur,
Lars Povlsen, Steen Hegelund, Daniel Machon, Alexandre Belloni,
Shannon Nelson, Brett Creeley, Sergey Shtylyov, Yoshihiro Shimoda,
Niklas Söderlund, Edward Cree, Martin Habets,
Alexandre Torgue, Jose Abreu, Maxime Coquelin,
Siddharth Vadapalli, Roger Quadros, MD Danish Anwar,
Linus Walleij, Imre Kaloz, Richard Cochran, Willem de Bruijn,
Gal Pressman, Carolina Jubran, Rahul Rameshbabu
The responsibility for reporting of RX software timestamp has moved to
the core layer (see __ethtool_get_ts_info()), remove usage from the
device drivers.
Reviewed-by: Carolina Jubran <cjubran@nvidia.com>
Reviewed-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
Signed-off-by: Gal Pressman <gal@nvidia.com>
Reviewed-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
drivers/net/can/dev/dev.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/can/dev/dev.c b/drivers/net/can/dev/dev.c
index 87828f953073..6792c14fd7eb 100644
--- a/drivers/net/can/dev/dev.c
+++ b/drivers/net/can/dev/dev.c
@@ -380,12 +380,9 @@ int can_ethtool_op_get_ts_info_hwts(struct net_device *dev,
{
info->so_timestamping =
SOF_TIMESTAMPING_TX_SOFTWARE |
- SOF_TIMESTAMPING_RX_SOFTWARE |
- SOF_TIMESTAMPING_SOFTWARE |
SOF_TIMESTAMPING_TX_HARDWARE |
SOF_TIMESTAMPING_RX_HARDWARE |
SOF_TIMESTAMPING_RAW_HARDWARE;
- info->phc_index = -1;
info->tx_types = BIT(HWTSTAMP_TX_ON);
info->rx_filters = BIT(HWTSTAMP_FILTER_ALL);
--
2.40.1
^ permalink raw reply related [flat|nested] 20+ messages in thread* [PATCH net-next v2 03/15] can: peak_canfd: Remove setting of RX software timestamp
2024-09-01 11:27 [PATCH net-next v2 00/15] RX software timestamp for all Gal Pressman
2024-09-01 11:27 ` [PATCH net-next v2 01/15] ethtool: " Gal Pressman
2024-09-01 11:27 ` [PATCH net-next v2 02/15] can: dev: Remove setting of RX software timestamp Gal Pressman
@ 2024-09-01 11:27 ` Gal Pressman
2024-09-01 11:27 ` [PATCH net-next v2 04/15] can: peak_usb: " Gal Pressman
` (12 subsequent siblings)
15 siblings, 0 replies; 20+ messages in thread
From: Gal Pressman @ 2024-09-01 11:27 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski
Cc: netdev, Jay Vosburgh, Andy Gospodarek, Marc Kleine-Budde,
Vincent Mailhol, Shyam Sundar S K, Sudarsana Kalluru,
Manish Chopra, Michael Chan, Pavan Chebbi, Nicolas Ferre,
Claudiu Beznea, Sunil Goutham, Potnuri Bharat Teja,
Christian Benvenuti, Satish Kharat, Claudiu Manoil,
Vladimir Oltean, Wei Fang, Shenwei Wang, Clark Wang,
Dimitris Michailidis, Yisen Zhuang, Salil Mehta, Jijie Shao,
Tony Nguyen, Przemek Kitszel, Marcin Wojtas, Russell King,
Geetha sowjanya, Subbaraya Sundeep, hariprasad, Ido Schimmel,
Petr Machata, Bryan Whitehead, UNGLinuxDriver, Horatiu Vultur,
Lars Povlsen, Steen Hegelund, Daniel Machon, Alexandre Belloni,
Shannon Nelson, Brett Creeley, Sergey Shtylyov, Yoshihiro Shimoda,
Niklas Söderlund, Edward Cree, Martin Habets,
Alexandre Torgue, Jose Abreu, Maxime Coquelin,
Siddharth Vadapalli, Roger Quadros, MD Danish Anwar,
Linus Walleij, Imre Kaloz, Richard Cochran, Willem de Bruijn,
Gal Pressman, Carolina Jubran, Rahul Rameshbabu
The responsibility for reporting of RX software timestamp has moved to
the core layer (see __ethtool_get_ts_info()), remove usage from the
device drivers.
Reviewed-by: Carolina Jubran <cjubran@nvidia.com>
Reviewed-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
Signed-off-by: Gal Pressman <gal@nvidia.com>
Reviewed-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
drivers/net/can/peak_canfd/peak_canfd.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/can/peak_canfd/peak_canfd.c b/drivers/net/can/peak_canfd/peak_canfd.c
index b50005397463..28f3fd805273 100644
--- a/drivers/net/can/peak_canfd/peak_canfd.c
+++ b/drivers/net/can/peak_canfd/peak_canfd.c
@@ -781,11 +781,8 @@ static int peak_get_ts_info(struct net_device *dev,
{
info->so_timestamping =
SOF_TIMESTAMPING_TX_SOFTWARE |
- SOF_TIMESTAMPING_RX_SOFTWARE |
- SOF_TIMESTAMPING_SOFTWARE |
SOF_TIMESTAMPING_RX_HARDWARE |
SOF_TIMESTAMPING_RAW_HARDWARE;
- info->phc_index = -1;
info->tx_types = BIT(HWTSTAMP_TX_OFF);
info->rx_filters = BIT(HWTSTAMP_FILTER_ALL);
--
2.40.1
^ permalink raw reply related [flat|nested] 20+ messages in thread* [PATCH net-next v2 04/15] can: peak_usb: Remove setting of RX software timestamp
2024-09-01 11:27 [PATCH net-next v2 00/15] RX software timestamp for all Gal Pressman
` (2 preceding siblings ...)
2024-09-01 11:27 ` [PATCH net-next v2 03/15] can: peak_canfd: " Gal Pressman
@ 2024-09-01 11:27 ` Gal Pressman
2024-09-01 11:27 ` [PATCH net-next v2 05/15] tsnep: " Gal Pressman
` (11 subsequent siblings)
15 siblings, 0 replies; 20+ messages in thread
From: Gal Pressman @ 2024-09-01 11:27 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski
Cc: netdev, Jay Vosburgh, Andy Gospodarek, Marc Kleine-Budde,
Vincent Mailhol, Shyam Sundar S K, Sudarsana Kalluru,
Manish Chopra, Michael Chan, Pavan Chebbi, Nicolas Ferre,
Claudiu Beznea, Sunil Goutham, Potnuri Bharat Teja,
Christian Benvenuti, Satish Kharat, Claudiu Manoil,
Vladimir Oltean, Wei Fang, Shenwei Wang, Clark Wang,
Dimitris Michailidis, Yisen Zhuang, Salil Mehta, Jijie Shao,
Tony Nguyen, Przemek Kitszel, Marcin Wojtas, Russell King,
Geetha sowjanya, Subbaraya Sundeep, hariprasad, Ido Schimmel,
Petr Machata, Bryan Whitehead, UNGLinuxDriver, Horatiu Vultur,
Lars Povlsen, Steen Hegelund, Daniel Machon, Alexandre Belloni,
Shannon Nelson, Brett Creeley, Sergey Shtylyov, Yoshihiro Shimoda,
Niklas Söderlund, Edward Cree, Martin Habets,
Alexandre Torgue, Jose Abreu, Maxime Coquelin,
Siddharth Vadapalli, Roger Quadros, MD Danish Anwar,
Linus Walleij, Imre Kaloz, Richard Cochran, Willem de Bruijn,
Gal Pressman, Carolina Jubran, Rahul Rameshbabu
The responsibility for reporting of RX software timestamp has moved to
the core layer (see __ethtool_get_ts_info()), remove usage from the
device drivers.
Reviewed-by: Carolina Jubran <cjubran@nvidia.com>
Reviewed-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
Signed-off-by: Gal Pressman <gal@nvidia.com>
Reviewed-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
drivers/net/can/usb/peak_usb/pcan_usb_core.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/can/usb/peak_usb/pcan_usb_core.c b/drivers/net/can/usb/peak_usb/pcan_usb_core.c
index 3d68fef46ded..59f7cd8ceb39 100644
--- a/drivers/net/can/usb/peak_usb/pcan_usb_core.c
+++ b/drivers/net/can/usb/peak_usb/pcan_usb_core.c
@@ -901,11 +901,8 @@ int pcan_get_ts_info(struct net_device *dev, struct kernel_ethtool_ts_info *info
{
info->so_timestamping =
SOF_TIMESTAMPING_TX_SOFTWARE |
- SOF_TIMESTAMPING_RX_SOFTWARE |
- SOF_TIMESTAMPING_SOFTWARE |
SOF_TIMESTAMPING_RX_HARDWARE |
SOF_TIMESTAMPING_RAW_HARDWARE;
- info->phc_index = -1;
info->tx_types = BIT(HWTSTAMP_TX_OFF);
info->rx_filters = BIT(HWTSTAMP_FILTER_ALL);
--
2.40.1
^ permalink raw reply related [flat|nested] 20+ messages in thread* [PATCH net-next v2 05/15] tsnep: Remove setting of RX software timestamp
2024-09-01 11:27 [PATCH net-next v2 00/15] RX software timestamp for all Gal Pressman
` (3 preceding siblings ...)
2024-09-01 11:27 ` [PATCH net-next v2 04/15] can: peak_usb: " Gal Pressman
@ 2024-09-01 11:27 ` Gal Pressman
2024-09-01 11:27 ` [PATCH net-next v2 06/15] ionic: " Gal Pressman
` (10 subsequent siblings)
15 siblings, 0 replies; 20+ messages in thread
From: Gal Pressman @ 2024-09-01 11:27 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski
Cc: netdev, Jay Vosburgh, Andy Gospodarek, Marc Kleine-Budde,
Vincent Mailhol, Shyam Sundar S K, Sudarsana Kalluru,
Manish Chopra, Michael Chan, Pavan Chebbi, Nicolas Ferre,
Claudiu Beznea, Sunil Goutham, Potnuri Bharat Teja,
Christian Benvenuti, Satish Kharat, Claudiu Manoil,
Vladimir Oltean, Wei Fang, Shenwei Wang, Clark Wang,
Dimitris Michailidis, Yisen Zhuang, Salil Mehta, Jijie Shao,
Tony Nguyen, Przemek Kitszel, Marcin Wojtas, Russell King,
Geetha sowjanya, Subbaraya Sundeep, hariprasad, Ido Schimmel,
Petr Machata, Bryan Whitehead, UNGLinuxDriver, Horatiu Vultur,
Lars Povlsen, Steen Hegelund, Daniel Machon, Alexandre Belloni,
Shannon Nelson, Brett Creeley, Sergey Shtylyov, Yoshihiro Shimoda,
Niklas Söderlund, Edward Cree, Martin Habets,
Alexandre Torgue, Jose Abreu, Maxime Coquelin,
Siddharth Vadapalli, Roger Quadros, MD Danish Anwar,
Linus Walleij, Imre Kaloz, Richard Cochran, Willem de Bruijn,
Gal Pressman, Carolina Jubran, Rahul Rameshbabu, Gerhard Engleder
The responsibility for reporting of RX software timestamp has moved to
the core layer (see __ethtool_get_ts_info()), remove usage from the
device drivers.
Reviewed-by: Carolina Jubran <cjubran@nvidia.com>
Reviewed-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
Signed-off-by: Gal Pressman <gal@nvidia.com>
Reviewed-by: Gerhard Engleder <gerhard@engleder-embedded.com>
---
drivers/net/ethernet/engleder/tsnep_ethtool.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/ethernet/engleder/tsnep_ethtool.c b/drivers/net/ethernet/engleder/tsnep_ethtool.c
index 9aa286ba1f00..228a638eae16 100644
--- a/drivers/net/ethernet/engleder/tsnep_ethtool.c
+++ b/drivers/net/ethernet/engleder/tsnep_ethtool.c
@@ -310,16 +310,12 @@ static int tsnep_ethtool_get_ts_info(struct net_device *netdev,
struct tsnep_adapter *adapter = netdev_priv(netdev);
info->so_timestamping = SOF_TIMESTAMPING_TX_SOFTWARE |
- SOF_TIMESTAMPING_RX_SOFTWARE |
- SOF_TIMESTAMPING_SOFTWARE |
SOF_TIMESTAMPING_TX_HARDWARE |
SOF_TIMESTAMPING_RX_HARDWARE |
SOF_TIMESTAMPING_RAW_HARDWARE;
if (adapter->ptp_clock)
info->phc_index = ptp_clock_index(adapter->ptp_clock);
- else
- info->phc_index = -1;
info->tx_types = BIT(HWTSTAMP_TX_OFF) |
BIT(HWTSTAMP_TX_ON);
--
2.40.1
^ permalink raw reply related [flat|nested] 20+ messages in thread* [PATCH net-next v2 06/15] ionic: Remove setting of RX software timestamp
2024-09-01 11:27 [PATCH net-next v2 00/15] RX software timestamp for all Gal Pressman
` (4 preceding siblings ...)
2024-09-01 11:27 ` [PATCH net-next v2 05/15] tsnep: " Gal Pressman
@ 2024-09-01 11:27 ` Gal Pressman
2024-09-03 16:20 ` Brett Creeley
2024-09-01 11:27 ` [PATCH net-next v2 07/15] ravb: " Gal Pressman
` (9 subsequent siblings)
15 siblings, 1 reply; 20+ messages in thread
From: Gal Pressman @ 2024-09-01 11:27 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski
Cc: netdev, Jay Vosburgh, Andy Gospodarek, Marc Kleine-Budde,
Vincent Mailhol, Shyam Sundar S K, Sudarsana Kalluru,
Manish Chopra, Michael Chan, Pavan Chebbi, Nicolas Ferre,
Claudiu Beznea, Sunil Goutham, Potnuri Bharat Teja,
Christian Benvenuti, Satish Kharat, Claudiu Manoil,
Vladimir Oltean, Wei Fang, Shenwei Wang, Clark Wang,
Dimitris Michailidis, Yisen Zhuang, Salil Mehta, Jijie Shao,
Tony Nguyen, Przemek Kitszel, Marcin Wojtas, Russell King,
Geetha sowjanya, Subbaraya Sundeep, hariprasad, Ido Schimmel,
Petr Machata, Bryan Whitehead, UNGLinuxDriver, Horatiu Vultur,
Lars Povlsen, Steen Hegelund, Daniel Machon, Alexandre Belloni,
Shannon Nelson, Brett Creeley, Sergey Shtylyov, Yoshihiro Shimoda,
Niklas Söderlund, Edward Cree, Martin Habets,
Alexandre Torgue, Jose Abreu, Maxime Coquelin,
Siddharth Vadapalli, Roger Quadros, MD Danish Anwar,
Linus Walleij, Imre Kaloz, Richard Cochran, Willem de Bruijn,
Gal Pressman, Carolina Jubran, Rahul Rameshbabu
The responsibility for reporting of RX software timestamp has moved to
the core layer (see __ethtool_get_ts_info()), remove usage from the
device drivers.
Reviewed-by: Carolina Jubran <cjubran@nvidia.com>
Reviewed-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
Signed-off-by: Gal Pressman <gal@nvidia.com>
Reviewed-by: Shannon Nelson <shannon.nelson@amd.com>
---
drivers/net/ethernet/pensando/ionic/ionic_ethtool.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c b/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c
index 4619fd74f3e3..dda22fa4448c 100644
--- a/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c
+++ b/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c
@@ -989,8 +989,6 @@ static int ionic_get_ts_info(struct net_device *netdev,
info->phc_index = ptp_clock_index(lif->phc->ptp);
info->so_timestamping = SOF_TIMESTAMPING_TX_SOFTWARE |
- SOF_TIMESTAMPING_RX_SOFTWARE |
- SOF_TIMESTAMPING_SOFTWARE |
SOF_TIMESTAMPING_TX_HARDWARE |
SOF_TIMESTAMPING_RX_HARDWARE |
SOF_TIMESTAMPING_RAW_HARDWARE;
--
2.40.1
^ permalink raw reply related [flat|nested] 20+ messages in thread* Re: [PATCH net-next v2 06/15] ionic: Remove setting of RX software timestamp
2024-09-01 11:27 ` [PATCH net-next v2 06/15] ionic: " Gal Pressman
@ 2024-09-03 16:20 ` Brett Creeley
0 siblings, 0 replies; 20+ messages in thread
From: Brett Creeley @ 2024-09-03 16:20 UTC (permalink / raw)
To: Gal Pressman, David S. Miller, Jakub Kicinski
Cc: netdev, Jay Vosburgh, Andy Gospodarek, Marc Kleine-Budde,
Vincent Mailhol, Shyam Sundar S K, Sudarsana Kalluru,
Manish Chopra, Michael Chan, Pavan Chebbi, Nicolas Ferre,
Claudiu Beznea, Sunil Goutham, Potnuri Bharat Teja,
Christian Benvenuti, Satish Kharat, Claudiu Manoil,
Vladimir Oltean, Wei Fang, Shenwei Wang, Clark Wang,
Dimitris Michailidis, Yisen Zhuang, Salil Mehta, Jijie Shao,
Tony Nguyen, Przemek Kitszel, Marcin Wojtas, Russell King,
Geetha sowjanya, Subbaraya Sundeep, hariprasad, Ido Schimmel,
Petr Machata, Bryan Whitehead, UNGLinuxDriver, Horatiu Vultur,
Lars Povlsen, Steen Hegelund, Daniel Machon, Alexandre Belloni,
Shannon Nelson, Brett Creeley, Sergey Shtylyov, Yoshihiro Shimoda,
Niklas Söderlund, Edward Cree, Martin Habets,
Alexandre Torgue, Jose Abreu, Maxime Coquelin,
Siddharth Vadapalli, Roger Quadros, MD Danish Anwar,
Linus Walleij, Imre Kaloz, Richard Cochran, Willem de Bruijn,
Carolina Jubran, Rahul Rameshbabu
On 9/1/2024 4:27 AM, Gal Pressman wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> The responsibility for reporting of RX software timestamp has moved to
> the core layer (see __ethtool_get_ts_info()), remove usage from the
> device drivers.
>
> Reviewed-by: Carolina Jubran <cjubran@nvidia.com>
> Reviewed-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
> Signed-off-by: Gal Pressman <gal@nvidia.com>
> Reviewed-by: Shannon Nelson <shannon.nelson@amd.com>
> ---
> drivers/net/ethernet/pensando/ionic/ionic_ethtool.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c b/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c
> index 4619fd74f3e3..dda22fa4448c 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c
> @@ -989,8 +989,6 @@ static int ionic_get_ts_info(struct net_device *netdev,
> info->phc_index = ptp_clock_index(lif->phc->ptp);
>
> info->so_timestamping = SOF_TIMESTAMPING_TX_SOFTWARE |
> - SOF_TIMESTAMPING_RX_SOFTWARE |
> - SOF_TIMESTAMPING_SOFTWARE |
> SOF_TIMESTAMPING_TX_HARDWARE |
> SOF_TIMESTAMPING_RX_HARDWARE |
> SOF_TIMESTAMPING_RAW_HARDWARE;
> --
> 2.40.1
>
Thanks!
Reviewed-by: Brett Creeley <brett.creeley@amd.com>
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH net-next v2 07/15] ravb: Remove setting of RX software timestamp
2024-09-01 11:27 [PATCH net-next v2 00/15] RX software timestamp for all Gal Pressman
` (5 preceding siblings ...)
2024-09-01 11:27 ` [PATCH net-next v2 06/15] ionic: " Gal Pressman
@ 2024-09-01 11:27 ` Gal Pressman
2024-09-02 18:38 ` Sergey Shtylyov
2024-09-01 11:27 ` [PATCH net-next v2 08/15] net: renesas: rswitch: " Gal Pressman
` (8 subsequent siblings)
15 siblings, 1 reply; 20+ messages in thread
From: Gal Pressman @ 2024-09-01 11:27 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski
Cc: netdev, Jay Vosburgh, Andy Gospodarek, Marc Kleine-Budde,
Vincent Mailhol, Shyam Sundar S K, Sudarsana Kalluru,
Manish Chopra, Michael Chan, Pavan Chebbi, Nicolas Ferre,
Claudiu Beznea, Sunil Goutham, Potnuri Bharat Teja,
Christian Benvenuti, Satish Kharat, Claudiu Manoil,
Vladimir Oltean, Wei Fang, Shenwei Wang, Clark Wang,
Dimitris Michailidis, Yisen Zhuang, Salil Mehta, Jijie Shao,
Tony Nguyen, Przemek Kitszel, Marcin Wojtas, Russell King,
Geetha sowjanya, Subbaraya Sundeep, hariprasad, Ido Schimmel,
Petr Machata, Bryan Whitehead, UNGLinuxDriver, Horatiu Vultur,
Lars Povlsen, Steen Hegelund, Daniel Machon, Alexandre Belloni,
Shannon Nelson, Brett Creeley, Sergey Shtylyov, Yoshihiro Shimoda,
Niklas Söderlund, Edward Cree, Martin Habets,
Alexandre Torgue, Jose Abreu, Maxime Coquelin,
Siddharth Vadapalli, Roger Quadros, MD Danish Anwar,
Linus Walleij, Imre Kaloz, Richard Cochran, Willem de Bruijn,
Gal Pressman, Carolina Jubran, Rahul Rameshbabu,
Niklas Söderlund
The responsibility for reporting of RX software timestamp has moved to
the core layer (see __ethtool_get_ts_info()), remove usage from the
device drivers.
Reviewed-by: Carolina Jubran <cjubran@nvidia.com>
Reviewed-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
Signed-off-by: Gal Pressman <gal@nvidia.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
drivers/net/ethernet/renesas/ravb_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
index c02fb296bf7d..c7ec23688d56 100644
--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c
@@ -1744,8 +1744,6 @@ static int ravb_get_ts_info(struct net_device *ndev,
info->so_timestamping =
SOF_TIMESTAMPING_TX_SOFTWARE |
- SOF_TIMESTAMPING_RX_SOFTWARE |
- SOF_TIMESTAMPING_SOFTWARE |
SOF_TIMESTAMPING_TX_HARDWARE |
SOF_TIMESTAMPING_RX_HARDWARE |
SOF_TIMESTAMPING_RAW_HARDWARE;
@@ -1756,6 +1754,8 @@ static int ravb_get_ts_info(struct net_device *ndev,
(1 << HWTSTAMP_FILTER_ALL);
if (hw_info->gptp || hw_info->ccc_gac)
info->phc_index = ptp_clock_index(priv->ptp.clock);
+ else
+ info->phc_index = 0;
return 0;
}
--
2.40.1
^ permalink raw reply related [flat|nested] 20+ messages in thread* Re: [PATCH net-next v2 07/15] ravb: Remove setting of RX software timestamp
2024-09-01 11:27 ` [PATCH net-next v2 07/15] ravb: " Gal Pressman
@ 2024-09-02 18:38 ` Sergey Shtylyov
0 siblings, 0 replies; 20+ messages in thread
From: Sergey Shtylyov @ 2024-09-02 18:38 UTC (permalink / raw)
To: Gal Pressman, David S. Miller, Jakub Kicinski
Cc: netdev, Jay Vosburgh, Andy Gospodarek, Marc Kleine-Budde,
Vincent Mailhol, Shyam Sundar S K, Sudarsana Kalluru,
Manish Chopra, Michael Chan, Pavan Chebbi, Nicolas Ferre,
Claudiu Beznea, Sunil Goutham, Potnuri Bharat Teja,
Christian Benvenuti, Satish Kharat, Claudiu Manoil,
Vladimir Oltean, Wei Fang, Shenwei Wang, Clark Wang,
Dimitris Michailidis, Yisen Zhuang, Salil Mehta, Jijie Shao,
Tony Nguyen, Przemek Kitszel, Marcin Wojtas, Russell King,
Geetha sowjanya, Subbaraya Sundeep, hariprasad, Ido Schimmel,
Petr Machata, Bryan Whitehead, UNGLinuxDriver, Horatiu Vultur,
Lars Povlsen, Steen Hegelund, Daniel Machon, Alexandre Belloni,
Shannon Nelson, Brett Creeley, Yoshihiro Shimoda,
Niklas Söderlund, Edward Cree, Martin Habets,
Alexandre Torgue, Jose Abreu, Maxime Coquelin,
Siddharth Vadapalli, Roger Quadros, MD Danish Anwar,
Linus Walleij, Imre Kaloz, Richard Cochran, Willem de Bruijn,
Carolina Jubran, Rahul Rameshbabu, Niklas Söderlund
On 9/1/24 2:27 PM, Gal Pressman wrote:
> The responsibility for reporting of RX software timestamp has moved to
> the core layer (see __ethtool_get_ts_info()), remove usage from the
> device drivers.
>
> Reviewed-by: Carolina Jubran <cjubran@nvidia.com>
> Reviewed-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
> Signed-off-by: Gal Pressman <gal@nvidia.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
[...]
MBR, Sergey
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH net-next v2 08/15] net: renesas: rswitch: Remove setting of RX software timestamp
2024-09-01 11:27 [PATCH net-next v2 00/15] RX software timestamp for all Gal Pressman
` (6 preceding siblings ...)
2024-09-01 11:27 ` [PATCH net-next v2 07/15] ravb: " Gal Pressman
@ 2024-09-01 11:27 ` Gal Pressman
2024-09-01 11:27 ` [PATCH net-next v2 09/15] net: ethernet: rtsn: " Gal Pressman
` (7 subsequent siblings)
15 siblings, 0 replies; 20+ messages in thread
From: Gal Pressman @ 2024-09-01 11:27 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski
Cc: netdev, Jay Vosburgh, Andy Gospodarek, Marc Kleine-Budde,
Vincent Mailhol, Shyam Sundar S K, Sudarsana Kalluru,
Manish Chopra, Michael Chan, Pavan Chebbi, Nicolas Ferre,
Claudiu Beznea, Sunil Goutham, Potnuri Bharat Teja,
Christian Benvenuti, Satish Kharat, Claudiu Manoil,
Vladimir Oltean, Wei Fang, Shenwei Wang, Clark Wang,
Dimitris Michailidis, Yisen Zhuang, Salil Mehta, Jijie Shao,
Tony Nguyen, Przemek Kitszel, Marcin Wojtas, Russell King,
Geetha sowjanya, Subbaraya Sundeep, hariprasad, Ido Schimmel,
Petr Machata, Bryan Whitehead, UNGLinuxDriver, Horatiu Vultur,
Lars Povlsen, Steen Hegelund, Daniel Machon, Alexandre Belloni,
Shannon Nelson, Brett Creeley, Sergey Shtylyov, Yoshihiro Shimoda,
Niklas Söderlund, Edward Cree, Martin Habets,
Alexandre Torgue, Jose Abreu, Maxime Coquelin,
Siddharth Vadapalli, Roger Quadros, MD Danish Anwar,
Linus Walleij, Imre Kaloz, Richard Cochran, Willem de Bruijn,
Gal Pressman, Carolina Jubran, Rahul Rameshbabu,
Niklas Söderlund
The responsibility for reporting of RX software timestamp has moved to
the core layer (see __ethtool_get_ts_info()), remove usage from the
device drivers.
Reviewed-by: Carolina Jubran <cjubran@nvidia.com>
Reviewed-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
Signed-off-by: Gal Pressman <gal@nvidia.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
drivers/net/ethernet/renesas/rswitch.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/renesas/rswitch.c b/drivers/net/ethernet/renesas/rswitch.c
index ff50e20856ec..b80aa27a7214 100644
--- a/drivers/net/ethernet/renesas/rswitch.c
+++ b/drivers/net/ethernet/renesas/rswitch.c
@@ -1815,8 +1815,6 @@ static int rswitch_get_ts_info(struct net_device *ndev, struct kernel_ethtool_ts
info->phc_index = ptp_clock_index(rdev->priv->ptp_priv->clock);
info->so_timestamping = SOF_TIMESTAMPING_TX_SOFTWARE |
- SOF_TIMESTAMPING_RX_SOFTWARE |
- SOF_TIMESTAMPING_SOFTWARE |
SOF_TIMESTAMPING_TX_HARDWARE |
SOF_TIMESTAMPING_RX_HARDWARE |
SOF_TIMESTAMPING_RAW_HARDWARE;
--
2.40.1
^ permalink raw reply related [flat|nested] 20+ messages in thread* [PATCH net-next v2 09/15] net: ethernet: rtsn: Remove setting of RX software timestamp
2024-09-01 11:27 [PATCH net-next v2 00/15] RX software timestamp for all Gal Pressman
` (7 preceding siblings ...)
2024-09-01 11:27 ` [PATCH net-next v2 08/15] net: renesas: rswitch: " Gal Pressman
@ 2024-09-01 11:27 ` Gal Pressman
2024-09-01 11:27 ` [PATCH net-next v2 10/15] net: hns3: " Gal Pressman
` (6 subsequent siblings)
15 siblings, 0 replies; 20+ messages in thread
From: Gal Pressman @ 2024-09-01 11:27 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski
Cc: netdev, Jay Vosburgh, Andy Gospodarek, Marc Kleine-Budde,
Vincent Mailhol, Shyam Sundar S K, Sudarsana Kalluru,
Manish Chopra, Michael Chan, Pavan Chebbi, Nicolas Ferre,
Claudiu Beznea, Sunil Goutham, Potnuri Bharat Teja,
Christian Benvenuti, Satish Kharat, Claudiu Manoil,
Vladimir Oltean, Wei Fang, Shenwei Wang, Clark Wang,
Dimitris Michailidis, Yisen Zhuang, Salil Mehta, Jijie Shao,
Tony Nguyen, Przemek Kitszel, Marcin Wojtas, Russell King,
Geetha sowjanya, Subbaraya Sundeep, hariprasad, Ido Schimmel,
Petr Machata, Bryan Whitehead, UNGLinuxDriver, Horatiu Vultur,
Lars Povlsen, Steen Hegelund, Daniel Machon, Alexandre Belloni,
Shannon Nelson, Brett Creeley, Sergey Shtylyov, Yoshihiro Shimoda,
Niklas Söderlund, Edward Cree, Martin Habets,
Alexandre Torgue, Jose Abreu, Maxime Coquelin,
Siddharth Vadapalli, Roger Quadros, MD Danish Anwar,
Linus Walleij, Imre Kaloz, Richard Cochran, Willem de Bruijn,
Gal Pressman, Carolina Jubran, Rahul Rameshbabu,
Niklas Söderlund
The responsibility for reporting of RX software timestamp has moved to
the core layer (see __ethtool_get_ts_info()), remove usage from the
device drivers.
Reviewed-by: Carolina Jubran <cjubran@nvidia.com>
Reviewed-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
Signed-off-by: Gal Pressman <gal@nvidia.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
drivers/net/ethernet/renesas/rtsn.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/renesas/rtsn.c b/drivers/net/ethernet/renesas/rtsn.c
index 0e6cea42f007..f9f63c61d792 100644
--- a/drivers/net/ethernet/renesas/rtsn.c
+++ b/drivers/net/ethernet/renesas/rtsn.c
@@ -1219,8 +1219,6 @@ static int rtsn_get_ts_info(struct net_device *ndev,
info->phc_index = ptp_clock_index(priv->ptp_priv->clock);
info->so_timestamping = SOF_TIMESTAMPING_TX_SOFTWARE |
- SOF_TIMESTAMPING_RX_SOFTWARE |
- SOF_TIMESTAMPING_SOFTWARE |
SOF_TIMESTAMPING_TX_HARDWARE |
SOF_TIMESTAMPING_RX_HARDWARE |
SOF_TIMESTAMPING_RAW_HARDWARE;
--
2.40.1
^ permalink raw reply related [flat|nested] 20+ messages in thread* [PATCH net-next v2 10/15] net: hns3: Remove setting of RX software timestamp
2024-09-01 11:27 [PATCH net-next v2 00/15] RX software timestamp for all Gal Pressman
` (8 preceding siblings ...)
2024-09-01 11:27 ` [PATCH net-next v2 09/15] net: ethernet: rtsn: " Gal Pressman
@ 2024-09-01 11:27 ` Gal Pressman
2024-09-01 11:27 ` [PATCH net-next v2 11/15] net: fec: " Gal Pressman
` (5 subsequent siblings)
15 siblings, 0 replies; 20+ messages in thread
From: Gal Pressman @ 2024-09-01 11:27 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski
Cc: netdev, Jay Vosburgh, Andy Gospodarek, Marc Kleine-Budde,
Vincent Mailhol, Shyam Sundar S K, Sudarsana Kalluru,
Manish Chopra, Michael Chan, Pavan Chebbi, Nicolas Ferre,
Claudiu Beznea, Sunil Goutham, Potnuri Bharat Teja,
Christian Benvenuti, Satish Kharat, Claudiu Manoil,
Vladimir Oltean, Wei Fang, Shenwei Wang, Clark Wang,
Dimitris Michailidis, Yisen Zhuang, Salil Mehta, Jijie Shao,
Tony Nguyen, Przemek Kitszel, Marcin Wojtas, Russell King,
Geetha sowjanya, Subbaraya Sundeep, hariprasad, Ido Schimmel,
Petr Machata, Bryan Whitehead, UNGLinuxDriver, Horatiu Vultur,
Lars Povlsen, Steen Hegelund, Daniel Machon, Alexandre Belloni,
Shannon Nelson, Brett Creeley, Sergey Shtylyov, Yoshihiro Shimoda,
Niklas Söderlund, Edward Cree, Martin Habets,
Alexandre Torgue, Jose Abreu, Maxime Coquelin,
Siddharth Vadapalli, Roger Quadros, MD Danish Anwar,
Linus Walleij, Imre Kaloz, Richard Cochran, Willem de Bruijn,
Gal Pressman, Carolina Jubran, Rahul Rameshbabu
The responsibility for reporting of RX software timestamp has moved to
the core layer (see __ethtool_get_ts_info()), remove usage from the
device drivers.
Reviewed-by: Carolina Jubran <cjubran@nvidia.com>
Reviewed-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
Signed-off-by: Gal Pressman <gal@nvidia.com>
Reviewed-by: Jijie Shao <shaojijie@huawei.com>
---
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_ptp.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_ptp.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_ptp.c
index 5fff8ed388f8..5505caea88e9 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_ptp.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_ptp.c
@@ -389,16 +389,12 @@ int hclge_ptp_get_ts_info(struct hnae3_handle *handle,
}
info->so_timestamping = SOF_TIMESTAMPING_TX_SOFTWARE |
- SOF_TIMESTAMPING_RX_SOFTWARE |
- SOF_TIMESTAMPING_SOFTWARE |
SOF_TIMESTAMPING_TX_HARDWARE |
SOF_TIMESTAMPING_RX_HARDWARE |
SOF_TIMESTAMPING_RAW_HARDWARE;
if (hdev->ptp->clock)
info->phc_index = ptp_clock_index(hdev->ptp->clock);
- else
- info->phc_index = -1;
info->tx_types = BIT(HWTSTAMP_TX_OFF) | BIT(HWTSTAMP_TX_ON);
--
2.40.1
^ permalink raw reply related [flat|nested] 20+ messages in thread* [PATCH net-next v2 11/15] net: fec: Remove setting of RX software timestamp
2024-09-01 11:27 [PATCH net-next v2 00/15] RX software timestamp for all Gal Pressman
` (9 preceding siblings ...)
2024-09-01 11:27 ` [PATCH net-next v2 10/15] net: hns3: " Gal Pressman
@ 2024-09-01 11:27 ` Gal Pressman
2024-09-01 11:28 ` [PATCH net-next v2 12/15] net: enetc: " Gal Pressman
` (4 subsequent siblings)
15 siblings, 0 replies; 20+ messages in thread
From: Gal Pressman @ 2024-09-01 11:27 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski
Cc: netdev, Jay Vosburgh, Andy Gospodarek, Marc Kleine-Budde,
Vincent Mailhol, Shyam Sundar S K, Sudarsana Kalluru,
Manish Chopra, Michael Chan, Pavan Chebbi, Nicolas Ferre,
Claudiu Beznea, Sunil Goutham, Potnuri Bharat Teja,
Christian Benvenuti, Satish Kharat, Claudiu Manoil,
Vladimir Oltean, Wei Fang, Shenwei Wang, Clark Wang,
Dimitris Michailidis, Yisen Zhuang, Salil Mehta, Jijie Shao,
Tony Nguyen, Przemek Kitszel, Marcin Wojtas, Russell King,
Geetha sowjanya, Subbaraya Sundeep, hariprasad, Ido Schimmel,
Petr Machata, Bryan Whitehead, UNGLinuxDriver, Horatiu Vultur,
Lars Povlsen, Steen Hegelund, Daniel Machon, Alexandre Belloni,
Shannon Nelson, Brett Creeley, Sergey Shtylyov, Yoshihiro Shimoda,
Niklas Söderlund, Edward Cree, Martin Habets,
Alexandre Torgue, Jose Abreu, Maxime Coquelin,
Siddharth Vadapalli, Roger Quadros, MD Danish Anwar,
Linus Walleij, Imre Kaloz, Richard Cochran, Willem de Bruijn,
Gal Pressman, Carolina Jubran, Rahul Rameshbabu
The responsibility for reporting of RX software timestamp has moved to
the core layer (see __ethtool_get_ts_info()), remove usage from the
device drivers.
Reviewed-by: Carolina Jubran <cjubran@nvidia.com>
Reviewed-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
Signed-off-by: Gal Pressman <gal@nvidia.com>
Reviewed-by: Wei Fang <wei.fang@nxp.com>
---
drivers/net/ethernet/freescale/fec_main.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index 8c3bf0faba63..acbb627d51bf 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -2775,15 +2775,11 @@ static int fec_enet_get_ts_info(struct net_device *ndev,
if (fep->bufdesc_ex) {
info->so_timestamping = SOF_TIMESTAMPING_TX_SOFTWARE |
- SOF_TIMESTAMPING_RX_SOFTWARE |
- SOF_TIMESTAMPING_SOFTWARE |
SOF_TIMESTAMPING_TX_HARDWARE |
SOF_TIMESTAMPING_RX_HARDWARE |
SOF_TIMESTAMPING_RAW_HARDWARE;
if (fep->ptp_clock)
info->phc_index = ptp_clock_index(fep->ptp_clock);
- else
- info->phc_index = -1;
info->tx_types = (1 << HWTSTAMP_TX_OFF) |
(1 << HWTSTAMP_TX_ON);
--
2.40.1
^ permalink raw reply related [flat|nested] 20+ messages in thread* [PATCH net-next v2 12/15] net: enetc: Remove setting of RX software timestamp
2024-09-01 11:27 [PATCH net-next v2 00/15] RX software timestamp for all Gal Pressman
` (10 preceding siblings ...)
2024-09-01 11:27 ` [PATCH net-next v2 11/15] net: fec: " Gal Pressman
@ 2024-09-01 11:28 ` Gal Pressman
2024-09-01 11:28 ` [PATCH net-next v2 13/15] gianfar: " Gal Pressman
` (3 subsequent siblings)
15 siblings, 0 replies; 20+ messages in thread
From: Gal Pressman @ 2024-09-01 11:28 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski
Cc: netdev, Jay Vosburgh, Andy Gospodarek, Marc Kleine-Budde,
Vincent Mailhol, Shyam Sundar S K, Sudarsana Kalluru,
Manish Chopra, Michael Chan, Pavan Chebbi, Nicolas Ferre,
Claudiu Beznea, Sunil Goutham, Potnuri Bharat Teja,
Christian Benvenuti, Satish Kharat, Claudiu Manoil,
Vladimir Oltean, Wei Fang, Shenwei Wang, Clark Wang,
Dimitris Michailidis, Yisen Zhuang, Salil Mehta, Jijie Shao,
Tony Nguyen, Przemek Kitszel, Marcin Wojtas, Russell King,
Geetha sowjanya, Subbaraya Sundeep, hariprasad, Ido Schimmel,
Petr Machata, Bryan Whitehead, UNGLinuxDriver, Horatiu Vultur,
Lars Povlsen, Steen Hegelund, Daniel Machon, Alexandre Belloni,
Shannon Nelson, Brett Creeley, Sergey Shtylyov, Yoshihiro Shimoda,
Niklas Söderlund, Edward Cree, Martin Habets,
Alexandre Torgue, Jose Abreu, Maxime Coquelin,
Siddharth Vadapalli, Roger Quadros, MD Danish Anwar,
Linus Walleij, Imre Kaloz, Richard Cochran, Willem de Bruijn,
Gal Pressman, Carolina Jubran, Rahul Rameshbabu
The responsibility for reporting of RX software timestamp has moved to
the core layer (see __ethtool_get_ts_info()), remove usage from the
device drivers.
Reviewed-by: Carolina Jubran <cjubran@nvidia.com>
Reviewed-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
Signed-off-by: Gal Pressman <gal@nvidia.com>
Reviewed-by: Wei Fang <wei.fang@nxp.com>
---
drivers/net/ethernet/freescale/enetc/enetc_ethtool.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c b/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c
index 5e684b23c5f5..47c478e08d44 100644
--- a/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c
+++ b/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c
@@ -849,17 +849,13 @@ static int enetc_get_ts_info(struct net_device *ndev,
if (phc_idx) {
info->phc_index = *phc_idx;
symbol_put(enetc_phc_index);
- } else {
- info->phc_index = -1;
}
#ifdef CONFIG_FSL_ENETC_PTP_CLOCK
info->so_timestamping = SOF_TIMESTAMPING_TX_HARDWARE |
SOF_TIMESTAMPING_RX_HARDWARE |
SOF_TIMESTAMPING_RAW_HARDWARE |
- SOF_TIMESTAMPING_TX_SOFTWARE |
- SOF_TIMESTAMPING_RX_SOFTWARE |
- SOF_TIMESTAMPING_SOFTWARE;
+ SOF_TIMESTAMPING_TX_SOFTWARE;
info->tx_types = (1 << HWTSTAMP_TX_OFF) |
(1 << HWTSTAMP_TX_ON) |
@@ -867,9 +863,7 @@ static int enetc_get_ts_info(struct net_device *ndev,
info->rx_filters = (1 << HWTSTAMP_FILTER_NONE) |
(1 << HWTSTAMP_FILTER_ALL);
#else
- info->so_timestamping = SOF_TIMESTAMPING_RX_SOFTWARE |
- SOF_TIMESTAMPING_TX_SOFTWARE |
- SOF_TIMESTAMPING_SOFTWARE;
+ info->so_timestamping = SOF_TIMESTAMPING_TX_SOFTWARE;
#endif
return 0;
}
--
2.40.1
^ permalink raw reply related [flat|nested] 20+ messages in thread* [PATCH net-next v2 13/15] gianfar: Remove setting of RX software timestamp
2024-09-01 11:27 [PATCH net-next v2 00/15] RX software timestamp for all Gal Pressman
` (11 preceding siblings ...)
2024-09-01 11:28 ` [PATCH net-next v2 12/15] net: enetc: " Gal Pressman
@ 2024-09-01 11:28 ` Gal Pressman
2024-09-01 11:28 ` [PATCH net-next v2 14/15] octeontx2-pf: " Gal Pressman
` (2 subsequent siblings)
15 siblings, 0 replies; 20+ messages in thread
From: Gal Pressman @ 2024-09-01 11:28 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski
Cc: netdev, Jay Vosburgh, Andy Gospodarek, Marc Kleine-Budde,
Vincent Mailhol, Shyam Sundar S K, Sudarsana Kalluru,
Manish Chopra, Michael Chan, Pavan Chebbi, Nicolas Ferre,
Claudiu Beznea, Sunil Goutham, Potnuri Bharat Teja,
Christian Benvenuti, Satish Kharat, Claudiu Manoil,
Vladimir Oltean, Wei Fang, Shenwei Wang, Clark Wang,
Dimitris Michailidis, Yisen Zhuang, Salil Mehta, Jijie Shao,
Tony Nguyen, Przemek Kitszel, Marcin Wojtas, Russell King,
Geetha sowjanya, Subbaraya Sundeep, hariprasad, Ido Schimmel,
Petr Machata, Bryan Whitehead, UNGLinuxDriver, Horatiu Vultur,
Lars Povlsen, Steen Hegelund, Daniel Machon, Alexandre Belloni,
Shannon Nelson, Brett Creeley, Sergey Shtylyov, Yoshihiro Shimoda,
Niklas Söderlund, Edward Cree, Martin Habets,
Alexandre Torgue, Jose Abreu, Maxime Coquelin,
Siddharth Vadapalli, Roger Quadros, MD Danish Anwar,
Linus Walleij, Imre Kaloz, Richard Cochran, Willem de Bruijn,
Gal Pressman, Carolina Jubran, Rahul Rameshbabu
The responsibility for reporting of RX software timestamp has moved to
the core layer (see __ethtool_get_ts_info()), remove usage from the
device drivers.
Reviewed-by: Carolina Jubran <cjubran@nvidia.com>
Reviewed-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
Signed-off-by: Gal Pressman <gal@nvidia.com>
---
drivers/net/ethernet/freescale/gianfar_ethtool.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ethernet/freescale/gianfar_ethtool.c b/drivers/net/ethernet/freescale/gianfar_ethtool.c
index f581402ad740..a99b95c4bcfb 100644
--- a/drivers/net/ethernet/freescale/gianfar_ethtool.c
+++ b/drivers/net/ethernet/freescale/gianfar_ethtool.c
@@ -1455,12 +1455,8 @@ static int gfar_get_ts_info(struct net_device *dev,
struct device_node *ptp_node;
struct ptp_qoriq *ptp = NULL;
- info->phc_index = -1;
-
if (!(priv->device_flags & FSL_GIANFAR_DEV_HAS_TIMER)) {
- info->so_timestamping = SOF_TIMESTAMPING_RX_SOFTWARE |
- SOF_TIMESTAMPING_TX_SOFTWARE |
- SOF_TIMESTAMPING_SOFTWARE;
+ info->so_timestamping = SOF_TIMESTAMPING_TX_SOFTWARE;
return 0;
}
@@ -1478,9 +1474,7 @@ static int gfar_get_ts_info(struct net_device *dev,
info->so_timestamping = SOF_TIMESTAMPING_TX_HARDWARE |
SOF_TIMESTAMPING_RX_HARDWARE |
SOF_TIMESTAMPING_RAW_HARDWARE |
- SOF_TIMESTAMPING_RX_SOFTWARE |
- SOF_TIMESTAMPING_TX_SOFTWARE |
- SOF_TIMESTAMPING_SOFTWARE;
+ SOF_TIMESTAMPING_TX_SOFTWARE;
info->tx_types = (1 << HWTSTAMP_TX_OFF) |
(1 << HWTSTAMP_TX_ON);
info->rx_filters = (1 << HWTSTAMP_FILTER_NONE) |
--
2.40.1
^ permalink raw reply related [flat|nested] 20+ messages in thread* [PATCH net-next v2 14/15] octeontx2-pf: Remove setting of RX software timestamp
2024-09-01 11:27 [PATCH net-next v2 00/15] RX software timestamp for all Gal Pressman
` (12 preceding siblings ...)
2024-09-01 11:28 ` [PATCH net-next v2 13/15] gianfar: " Gal Pressman
@ 2024-09-01 11:28 ` Gal Pressman
2024-09-01 11:28 ` [PATCH net-next v2 15/15] net: mvpp2: " Gal Pressman
2024-09-03 22:30 ` [PATCH net-next v2 00/15] RX software timestamp for all patchwork-bot+netdevbpf
15 siblings, 0 replies; 20+ messages in thread
From: Gal Pressman @ 2024-09-01 11:28 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski
Cc: netdev, Jay Vosburgh, Andy Gospodarek, Marc Kleine-Budde,
Vincent Mailhol, Shyam Sundar S K, Sudarsana Kalluru,
Manish Chopra, Michael Chan, Pavan Chebbi, Nicolas Ferre,
Claudiu Beznea, Sunil Goutham, Potnuri Bharat Teja,
Christian Benvenuti, Satish Kharat, Claudiu Manoil,
Vladimir Oltean, Wei Fang, Shenwei Wang, Clark Wang,
Dimitris Michailidis, Yisen Zhuang, Salil Mehta, Jijie Shao,
Tony Nguyen, Przemek Kitszel, Marcin Wojtas, Russell King,
Geetha sowjanya, Subbaraya Sundeep, hariprasad, Ido Schimmel,
Petr Machata, Bryan Whitehead, UNGLinuxDriver, Horatiu Vultur,
Lars Povlsen, Steen Hegelund, Daniel Machon, Alexandre Belloni,
Shannon Nelson, Brett Creeley, Sergey Shtylyov, Yoshihiro Shimoda,
Niklas Söderlund, Edward Cree, Martin Habets,
Alexandre Torgue, Jose Abreu, Maxime Coquelin,
Siddharth Vadapalli, Roger Quadros, MD Danish Anwar,
Linus Walleij, Imre Kaloz, Richard Cochran, Willem de Bruijn,
Gal Pressman, Carolina Jubran, Rahul Rameshbabu
The responsibility for reporting of RX software timestamp has moved to
the core layer (see __ethtool_get_ts_info()), remove usage from the
device drivers.
Reviewed-by: Carolina Jubran <cjubran@nvidia.com>
Reviewed-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
Signed-off-by: Gal Pressman <gal@nvidia.com>
Reviewed-by: Subbaraya Sundeep <sbhatta@marvell.com>
---
drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c
index 0db62eb0dab3..32468c663605 100644
--- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c
+++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c
@@ -962,8 +962,6 @@ static int otx2_get_ts_info(struct net_device *netdev,
return ethtool_op_get_ts_info(netdev, info);
info->so_timestamping = SOF_TIMESTAMPING_TX_SOFTWARE |
- SOF_TIMESTAMPING_RX_SOFTWARE |
- SOF_TIMESTAMPING_SOFTWARE |
SOF_TIMESTAMPING_TX_HARDWARE |
SOF_TIMESTAMPING_RX_HARDWARE |
SOF_TIMESTAMPING_RAW_HARDWARE;
--
2.40.1
^ permalink raw reply related [flat|nested] 20+ messages in thread* [PATCH net-next v2 15/15] net: mvpp2: Remove setting of RX software timestamp
2024-09-01 11:27 [PATCH net-next v2 00/15] RX software timestamp for all Gal Pressman
` (13 preceding siblings ...)
2024-09-01 11:28 ` [PATCH net-next v2 14/15] octeontx2-pf: " Gal Pressman
@ 2024-09-01 11:28 ` Gal Pressman
2024-09-02 18:19 ` Marcin Wojtas
2024-09-03 22:30 ` [PATCH net-next v2 00/15] RX software timestamp for all patchwork-bot+netdevbpf
15 siblings, 1 reply; 20+ messages in thread
From: Gal Pressman @ 2024-09-01 11:28 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski
Cc: netdev, Jay Vosburgh, Andy Gospodarek, Marc Kleine-Budde,
Vincent Mailhol, Shyam Sundar S K, Sudarsana Kalluru,
Manish Chopra, Michael Chan, Pavan Chebbi, Nicolas Ferre,
Claudiu Beznea, Sunil Goutham, Potnuri Bharat Teja,
Christian Benvenuti, Satish Kharat, Claudiu Manoil,
Vladimir Oltean, Wei Fang, Shenwei Wang, Clark Wang,
Dimitris Michailidis, Yisen Zhuang, Salil Mehta, Jijie Shao,
Tony Nguyen, Przemek Kitszel, Marcin Wojtas, Russell King,
Geetha sowjanya, Subbaraya Sundeep, hariprasad, Ido Schimmel,
Petr Machata, Bryan Whitehead, UNGLinuxDriver, Horatiu Vultur,
Lars Povlsen, Steen Hegelund, Daniel Machon, Alexandre Belloni,
Shannon Nelson, Brett Creeley, Sergey Shtylyov, Yoshihiro Shimoda,
Niklas Söderlund, Edward Cree, Martin Habets,
Alexandre Torgue, Jose Abreu, Maxime Coquelin,
Siddharth Vadapalli, Roger Quadros, MD Danish Anwar,
Linus Walleij, Imre Kaloz, Richard Cochran, Willem de Bruijn,
Gal Pressman, Carolina Jubran, Rahul Rameshbabu
The responsibility for reporting of RX software timestamp has moved to
the core layer (see __ethtool_get_ts_info()), remove usage from the
device drivers.
Reviewed-by: Carolina Jubran <cjubran@nvidia.com>
Reviewed-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
Signed-off-by: Gal Pressman <gal@nvidia.com>
---
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
index 0d62a33afa80..1f01c6febc6b 100644
--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
@@ -5268,8 +5268,6 @@ static int mvpp2_ethtool_get_ts_info(struct net_device *dev,
info->phc_index = mvpp22_tai_ptp_clock_index(port->priv->tai);
info->so_timestamping = SOF_TIMESTAMPING_TX_SOFTWARE |
- SOF_TIMESTAMPING_RX_SOFTWARE |
- SOF_TIMESTAMPING_SOFTWARE |
SOF_TIMESTAMPING_TX_HARDWARE |
SOF_TIMESTAMPING_RX_HARDWARE |
SOF_TIMESTAMPING_RAW_HARDWARE;
--
2.40.1
^ permalink raw reply related [flat|nested] 20+ messages in thread* Re: [PATCH net-next v2 15/15] net: mvpp2: Remove setting of RX software timestamp
2024-09-01 11:28 ` [PATCH net-next v2 15/15] net: mvpp2: " Gal Pressman
@ 2024-09-02 18:19 ` Marcin Wojtas
0 siblings, 0 replies; 20+ messages in thread
From: Marcin Wojtas @ 2024-09-02 18:19 UTC (permalink / raw)
To: Gal Pressman
Cc: David S. Miller, Jakub Kicinski, netdev, Jay Vosburgh,
Andy Gospodarek, Marc Kleine-Budde, Vincent Mailhol,
Shyam Sundar S K, Sudarsana Kalluru, Manish Chopra, Michael Chan,
Pavan Chebbi, Nicolas Ferre, Claudiu Beznea, Sunil Goutham,
Potnuri Bharat Teja, Christian Benvenuti, Satish Kharat,
Claudiu Manoil, Vladimir Oltean, Wei Fang, Shenwei Wang,
Clark Wang, Dimitris Michailidis, Yisen Zhuang, Salil Mehta,
Jijie Shao, Tony Nguyen, Przemek Kitszel, Russell King,
Geetha sowjanya, Subbaraya Sundeep, hariprasad, Ido Schimmel,
Petr Machata, Bryan Whitehead, UNGLinuxDriver, Horatiu Vultur,
Lars Povlsen, Steen Hegelund, Daniel Machon, Alexandre Belloni,
Shannon Nelson, Brett Creeley, Sergey Shtylyov, Yoshihiro Shimoda,
Niklas Söderlund, Edward Cree, Martin Habets,
Alexandre Torgue, Jose Abreu, Maxime Coquelin,
Siddharth Vadapalli, Roger Quadros, MD Danish Anwar,
Linus Walleij, Imre Kaloz, Richard Cochran, Willem de Bruijn,
Carolina Jubran, Rahul Rameshbabu
niedz., 1 wrz 2024 o 13:31 Gal Pressman <gal@nvidia.com> napisał(a):
>
> The responsibility for reporting of RX software timestamp has moved to
> the core layer (see __ethtool_get_ts_info()), remove usage from the
> device drivers.
>
> Reviewed-by: Carolina Jubran <cjubran@nvidia.com>
> Reviewed-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
> Signed-off-by: Gal Pressman <gal@nvidia.com>
> ---
> drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> index 0d62a33afa80..1f01c6febc6b 100644
> --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> @@ -5268,8 +5268,6 @@ static int mvpp2_ethtool_get_ts_info(struct net_device *dev,
>
> info->phc_index = mvpp22_tai_ptp_clock_index(port->priv->tai);
> info->so_timestamping = SOF_TIMESTAMPING_TX_SOFTWARE |
> - SOF_TIMESTAMPING_RX_SOFTWARE |
> - SOF_TIMESTAMPING_SOFTWARE |
> SOF_TIMESTAMPING_TX_HARDWARE |
> SOF_TIMESTAMPING_RX_HARDWARE |
> SOF_TIMESTAMPING_RAW_HARDWARE;
>
Reviewed-by: Marcin Wojtas <marcin.s.wojtas@gmail.com>
Thanks!
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH net-next v2 00/15] RX software timestamp for all
2024-09-01 11:27 [PATCH net-next v2 00/15] RX software timestamp for all Gal Pressman
` (14 preceding siblings ...)
2024-09-01 11:28 ` [PATCH net-next v2 15/15] net: mvpp2: " Gal Pressman
@ 2024-09-03 22:30 ` patchwork-bot+netdevbpf
15 siblings, 0 replies; 20+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-09-03 22:30 UTC (permalink / raw)
To: Gal Pressman
Cc: davem, kuba, netdev, jv, andy, mkl, mailhol.vincent,
Shyam-sundar.S-k, skalluru, manishc, michael.chan, pavan.chebbi,
nicolas.ferre, claudiu.beznea, sgoutham, bharat, benve, satishkh,
claudiu.manoil, vladimir.oltean, wei.fang, shenwei.wang,
xiaoning.wang, dmichail, yisen.zhuang, salil.mehta, shaojijie,
anthony.l.nguyen, przemyslaw.kitszel, marcin.s.wojtas, linux,
gakula, sbhatta, hkelam, idosch, petrm, bryan.whitehead,
UNGLinuxDriver, horatiu.vultur, lars.povlsen, Steen.Hegelund,
daniel.machon, alexandre.belloni, shannon.nelson, brett.creeley,
s.shtylyov, yoshihiro.shimoda.uh, niklas.soderlund, ecree.xilinx,
habetsm.xilinx, alexandre.torgue, joabreu, mcoquelin.stm32,
s-vadapalli, rogerq, danishanwar, linusw, kaloz, richardcochran,
willemdebruijn.kernel
Hello:
This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Sun, 1 Sep 2024 14:27:48 +0300 you wrote:
> All devices support SOF_TIMESTAMPING_RX_SOFTWARE by virtue of
> net_timestamp_check() being called in the device independent code.
> Following Willem's suggestion [1], make it so drivers do not have to
> handle SOF_TIMESTAMPING_RX_SOFTWARE and SOF_TIMESTAMPING_SOFTWARE, nor
> setting of the PHC index to -1.
>
> All drivers will now report RX software timestamp as supported.
> The series is limited to 15 patches, I will submit other drivers in
> subsequent submissions.
>
> [...]
Here is the summary with links:
- [net-next,v2,01/15] ethtool: RX software timestamp for all
https://git.kernel.org/netdev/net-next/c/12d337339d9f
- [net-next,v2,02/15] can: dev: Remove setting of RX software timestamp
https://git.kernel.org/netdev/net-next/c/b5ed017a5658
- [net-next,v2,03/15] can: peak_canfd: Remove setting of RX software timestamp
https://git.kernel.org/netdev/net-next/c/583fee8210cb
- [net-next,v2,04/15] can: peak_usb: Remove setting of RX software timestamp
https://git.kernel.org/netdev/net-next/c/ab6ebf02f222
- [net-next,v2,05/15] tsnep: Remove setting of RX software timestamp
https://git.kernel.org/netdev/net-next/c/24186dc66b10
- [net-next,v2,06/15] ionic: Remove setting of RX software timestamp
https://git.kernel.org/netdev/net-next/c/e052114e14c2
- [net-next,v2,07/15] ravb: Remove setting of RX software timestamp
https://git.kernel.org/netdev/net-next/c/277901ee3a26
- [net-next,v2,08/15] net: renesas: rswitch: Remove setting of RX software timestamp
https://git.kernel.org/netdev/net-next/c/41ee62317087
- [net-next,v2,09/15] net: ethernet: rtsn: Remove setting of RX software timestamp
https://git.kernel.org/netdev/net-next/c/0f79953c0019
- [net-next,v2,10/15] net: hns3: Remove setting of RX software timestamp
https://git.kernel.org/netdev/net-next/c/c6a15576e60e
- [net-next,v2,11/15] net: fec: Remove setting of RX software timestamp
https://git.kernel.org/netdev/net-next/c/7d20c38d088e
- [net-next,v2,12/15] net: enetc: Remove setting of RX software timestamp
https://git.kernel.org/netdev/net-next/c/3dd261ca7f84
- [net-next,v2,13/15] gianfar: Remove setting of RX software timestamp
https://git.kernel.org/netdev/net-next/c/673ec22b1de8
- [net-next,v2,14/15] octeontx2-pf: Remove setting of RX software timestamp
https://git.kernel.org/netdev/net-next/c/eb87a1daf6fb
- [net-next,v2,15/15] net: mvpp2: Remove setting of RX software timestamp
https://git.kernel.org/netdev/net-next/c/406e862b4583
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 20+ messages in thread