From: Simon Horman <horms@kernel.org>
To: Ahmed Zaki <ahmed.zaki@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
pavan.kumar.linga@intel.com,
Przemek Kitszel <przemyslaw.kitszel@intel.com>
Subject: Re: [PATCH iwl-net] idpf: fix VF dynamic interrupt ctl register initialization
Date: Mon, 2 Sep 2024 09:49:18 +0100 [thread overview]
Message-ID: <20240902084918.GD23170@kernel.org> (raw)
In-Reply-To: <20240828223825.426647-1-ahmed.zaki@intel.com>
On Wed, Aug 28, 2024 at 04:38:25PM -0600, Ahmed Zaki wrote:
> The VF's dynamic interrupt ctl "dyn_ctl_intrvl_s" is not initialized
> in idpf_vf_intr_reg_init(). This resulted in the following UBSAN error
> whenever a VF is created:
>
> [ 564.345655] UBSAN: shift-out-of-bounds in drivers/net/ethernet/intel/idpf/idpf_txrx.c:3654:10
> [ 564.345663] shift exponent 4294967295 is too large for 32-bit type 'int'
> [ 564.345671] CPU: 33 UID: 0 PID: 2458 Comm: NetworkManager Not tainted 6.11.0-rc4+ #1
> [ 564.345678] Hardware name: Intel Corporation M50CYP2SBSTD/M50CYP2SBSTD, BIOS SE5C6200.86B.0027.P10.2201070222 01/07/2022
> [ 564.345683] Call Trace:
> [ 564.345688] <TASK>
> [ 564.345693] dump_stack_lvl+0x91/0xb0
> [ 564.345708] __ubsan_handle_shift_out_of_bounds+0x16b/0x320
> [ 564.345730] idpf_vport_intr_update_itr_ena_irq.cold+0x13/0x39 [idpf]
> [ 564.345755] ? __pfx_idpf_vport_intr_update_itr_ena_irq+0x10/0x10 [idpf]
> [ 564.345771] ? static_obj+0x95/0xd0
> [ 564.345782] ? lockdep_init_map_type+0x1a5/0x800
> [ 564.345794] idpf_vport_intr_ena+0x5ef/0x9f0 [idpf]
> [ 564.345814] idpf_vport_open+0x2cc/0x1240 [idpf]
> [ 564.345837] idpf_open+0x6d/0xc0 [idpf]
> [ 564.345850] __dev_open+0x241/0x420
>
> Fixes: d4d558718266 ("idpf: initialize interrupts and enable vport")
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Signed-off-by: Ahmed Zaki <ahmed.zaki@intel.com>
Thanks,
I see that this now matches the implementation of idpf_intr_reg_init().
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-09-02 8:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 22:38 [PATCH iwl-net] idpf: fix VF dynamic interrupt ctl register initialization Ahmed Zaki
2024-09-02 8:49 ` Simon Horman [this message]
2024-09-25 20:22 ` Singh, Krishneil K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240902084918.GD23170@kernel.org \
--to=horms@kernel.org \
--cc=ahmed.zaki@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=netdev@vger.kernel.org \
--cc=pavan.kumar.linga@intel.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).