From: Simon Horman <horms@kernel.org>
To: Yuesong Li <liyuesong@vivo.com>
Cc: elder@kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, lihongbo22@huawei.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
opensource.kernel@vivo.com
Subject: Re: [PATCH net-next v2] net: ipa: make use of dev_err_cast_probe()
Date: Mon, 2 Sep 2024 09:56:57 +0100 [thread overview]
Message-ID: <20240902085657.GE23170@kernel.org> (raw)
In-Reply-To: <20240829030739.1899011-1-liyuesong@vivo.com>
On Thu, Aug 29, 2024 at 11:07:39AM +0800, Yuesong Li wrote:
> Using dev_err_cast_probe() to simplify the code.
>
> Signed-off-by: Yuesong Li <liyuesong@vivo.com>
> Signed-off-by: Hongbo Li <lihongbo22@huawei.com>
> ---
> v2: https://lore.kernel.org/all/20240828160728.GR1368797@kernel.org/
> - fix patch name
> - drop the {} and fix the alignment
Thanks for hte updates.
I note that this code is in a probe function,
so this patch is an appropriate use of dev_err_cast_probe() [1].
I also see that it addresses the feedback on code style from v1.
Reviewed-by: Simon Horman <horms@kernel.org>
[1] [PATCH] net: alacritech: Partially revert "net: alacritech: Switch to use dev_err_probe()"
https://lore.kernel.org/netdev/20240830170014.15389-1-krzysztof.kozlowski@linaro.org/
...
next prev parent reply other threads:[~2024-09-02 8:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 3:07 [PATCH net-next v2] net: ipa: make use of dev_err_cast_probe() Yuesong Li
2024-09-02 8:56 ` Simon Horman [this message]
2024-09-03 8:41 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240902085657.GE23170@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=elder@kernel.org \
--cc=kuba@kernel.org \
--cc=lihongbo22@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liyuesong@vivo.com \
--cc=netdev@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).