Re: [PATCH net-next] netlink: specs: nftables: allow decode of default firewalld ruleset

[Florian Westphal <fw@strlen.de>]

Donald Hunter <donald.hunter@gmail.com> wrote:
> Florian Westphal <fw@strlen.de> writes:
> 
> > This update allows listing default firewalld ruleset on Fedora 40 via
> >   tools/net/ynl/cli.py --spec \
> >      Documentation/netlink/specs/nftables.yaml --dump getrule
> >
> > Default ruleset uses fib, reject and objref expressions which were
> > missing.
> >
> > Other missing expressions can be added later.
> >
> > Improve decoding while at it:
> > - add bitwise, ct and lookup attributes
> > - wire up the quota expression
> > - translate raw verdict codes to a human reable name, e.g.
> >   'code': 4294967293 becomes 'code': 'jump'.
> >
> > Cc: Donald Hunter <donald.hunter@gmail.com>
> > Signed-off-by: Florian Westphal <fw@strlen.de>
> 
> One minor question below, otherwise LGTM.
> 
> Reviewed-by: Donald Hunter <donald.hunter@gmail.com>
> 
> 
> > +    name: fib-result
> > +    type: enum
> > +    entries:
> > +      - oif
> > +      - oifname
> 
> Did you intentionally leave out addrtype from the enum?

No, I'm just incompetent.

Will send a v2 tomorrow.