From: Jakub Kicinski <kuba@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Jiri Pirko <jiri@resnulli.us>,
netdev@vger.kernel.org, Madhu Chittim <madhu.chittim@intel.com>,
Sridhar Samudrala <sridhar.samudrala@intel.com>,
Simon Horman <horms@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Sunil Kovvuri Goutham <sgoutham@marvell.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Donald Hunter <donald.hunter@gmail.com>,
anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com,
intel-wired-lan@lists.osuosl.org, edumazet@google.com
Subject: Re: [PATCH v5 net-next 02/12] net-shapers: implement NL get operation
Date: Mon, 2 Sep 2024 17:37:04 -0700 [thread overview]
Message-ID: <20240902173704.71c6b35a@kernel.org> (raw)
In-Reply-To: <c6d8052c-c5a0-48e2-8984-0063afc1e482@redhat.com>
On Mon, 2 Sep 2024 12:10:50 +0200 Paolo Abeni wrote:
> >> Was that way a couple of iterations ago. Jiri explicitly asked for the
> >> separation, I asked for confirmation and nobody objected.
> >
> > Could you link to that? I must have not read it.
>
> https://lore.kernel.org/netdev/ZqzIoZaGVb3jIW43@nanopsycho.orion/
>
> search for "I wonder if the handle should be part of this structure"
>
> I must admit by wannabe reply on such point never left my outbox.
"I wonder if .." does not sound like a strong preference.
And the parent ID remained in the struct, so it still partially records
its position in the hierarchy. Since there is no "move" op it's really
not worth multiplying arguments to most functions 2x.
next prev parent reply other threads:[~2024-09-03 0:37 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 15:16 [PATCH v5 net-next 00/12] net: introduce TX H/W shaping API Paolo Abeni
2024-08-29 15:16 ` [PATCH v5 net-next 01/12] netlink: spec: add shaper YAML spec Paolo Abeni
2024-08-29 15:16 ` [PATCH v5 net-next 02/12] net-shapers: implement NL get operation Paolo Abeni
2024-08-29 23:28 ` Jakub Kicinski
2024-08-30 1:20 ` Jakub Kicinski
2024-08-30 10:55 ` Paolo Abeni
2024-08-30 18:39 ` Jakub Kicinski
2024-08-30 23:42 ` Jakub Kicinski
2024-09-02 13:00 ` Paolo Abeni
2024-08-30 15:43 ` Paolo Abeni
2024-08-30 19:14 ` Jakub Kicinski
2024-09-02 10:10 ` Paolo Abeni
2024-09-03 0:37 ` Jakub Kicinski [this message]
2024-08-29 15:16 ` [PATCH v5 net-next 03/12] net-shapers: implement NL set and delete operations Paolo Abeni
2024-08-30 1:43 ` Jakub Kicinski
2024-08-29 15:16 ` [PATCH v5 net-next 04/12] net-shapers: implement NL group operation Paolo Abeni
2024-08-30 2:04 ` Jakub Kicinski
2024-08-30 16:48 ` Paolo Abeni
2024-08-30 18:48 ` Jakub Kicinski
2024-08-29 15:16 ` [PATCH v5 net-next 05/12] net-shapers: implement delete support for NODE scope shaper Paolo Abeni
2024-08-29 15:16 ` [PATCH v5 net-next 06/12] netlink: spec: add shaper introspection support Paolo Abeni
2024-08-29 15:17 ` [PATCH v5 net-next 07/12] net: shaper: implement " Paolo Abeni
2024-08-30 2:11 ` Jakub Kicinski
2024-08-29 15:17 ` [PATCH v5 net-next 08/12] testing: net-drv: add basic shaper test Paolo Abeni
2024-08-29 15:17 ` [PATCH v5 net-next 09/12] virtchnl: support queue rate limit and quanta size configuration Paolo Abeni
2024-08-29 15:17 ` [PATCH v5 net-next 10/12] ice: Support VF " Paolo Abeni
2024-08-29 15:17 ` [PATCH v5 net-next 11/12] iavf: Add net_shaper_ops support Paolo Abeni
2024-08-30 2:09 ` Jakub Kicinski
2024-08-29 15:17 ` [PATCH v5 net-next 12/12] iavf: add support to exchange qos capabilities Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240902173704.71c6b35a@kernel.org \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=john.fastabend@gmail.com \
--cc=madhu.chittim@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=sgoutham@marvell.com \
--cc=sridhar.samudrala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).