From: Simon Horman <horms@kernel.org>
To: Yue Haibing <yuehaibing@huawei.com>
Cc: ajit.khaparde@broadcom.com, sriharsha.basavapatna@broadcom.com,
somnath.kotur@broadcom.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] be2net: Remove unused declarations
Date: Mon, 2 Sep 2024 19:24:19 +0100 [thread overview]
Message-ID: <20240902182419.GJ23170@kernel.org> (raw)
In-Reply-To: <20240902113238.557515-1-yuehaibing@huawei.com>
On Mon, Sep 02, 2024 at 07:32:38PM +0800, Yue Haibing wrote:
> Commit 6b7c5b947c67 ("net: Add be2net driver.") declared be_pci_fnum_get()
> and be_cmd_reset() but never implemented. And commit 9fa465c0ce0d ("be2net:
> remove code duplication relating to Lancer reset sequence") removed
> lancer_test_and_set_rdy_state() but leave declaration.
>
> Commit 76a9e08e33ce ("be2net: cleanup wake-on-lan code") left behind
> be_is_wol_supported() declaration.
> Commit baaa08d148ac ("be2net: do not call be_set/get_fw_log_level() on
> Skyhawk-R") removed be_get_fw_log_level() but leave declaration.
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
Thanks, I agree with your analysis.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-09-02 18:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 11:32 [PATCH net-next] be2net: Remove unused declarations Yue Haibing
2024-09-02 18:24 ` Simon Horman [this message]
2024-09-04 0:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240902182419.GJ23170@kernel.org \
--to=horms@kernel.org \
--cc=ajit.khaparde@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=somnath.kotur@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).