[PATCH net-next] be2net: Remove unused declarations

[PATCH net-next] be2net: Remove unused declarations

[Yue Haibing]

Commit 6b7c5b947c67 ("net: Add be2net driver.") declared be_pci_fnum_get()
and be_cmd_reset() but never implemented. And commit 9fa465c0ce0d ("be2net:
remove code duplication relating to Lancer reset sequence") removed
lancer_test_and_set_rdy_state() but leave declaration.

Commit 76a9e08e33ce ("be2net: cleanup wake-on-lan code") left behind
be_is_wol_supported() declaration.
Commit baaa08d148ac ("be2net: do not call be_set/get_fw_log_level() on
Skyhawk-R") removed be_get_fw_log_level() but leave declaration.

Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
 drivers/net/ethernet/emulex/benet/be.h      | 2 --
 drivers/net/ethernet/emulex/benet/be_cmds.h | 3 ---
 2 files changed, 5 deletions(-)

diff --git a/drivers/net/ethernet/emulex/benet/be.h b/drivers/net/ethernet/emulex/benet/be.h
index 61fe9625bed1..e48b861e4ce1 100644
--- a/drivers/net/ethernet/emulex/benet/be.h
+++ b/drivers/net/ethernet/emulex/benet/be.h
@@ -966,9 +966,7 @@ void be_cq_notify(struct be_adapter *adapter, u16 qid, bool arm,
 void be_link_status_update(struct be_adapter *adapter, u8 link_status);
 void be_parse_stats(struct be_adapter *adapter);
 int be_load_fw(struct be_adapter *adapter, u8 *func);
-bool be_is_wol_supported(struct be_adapter *adapter);
 bool be_pause_supported(struct be_adapter *adapter);
-u32 be_get_fw_log_level(struct be_adapter *adapter);
 int be_update_queues(struct be_adapter *adapter);
 int be_poll(struct napi_struct *napi, int budget);
 void be_eqd_update(struct be_adapter *adapter, bool force_update);
diff --git a/drivers/net/ethernet/emulex/benet/be_cmds.h b/drivers/net/ethernet/emulex/benet/be_cmds.h
index e2085c68c0ee..d70818f06be7 100644
--- a/drivers/net/ethernet/emulex/benet/be_cmds.h
+++ b/drivers/net/ethernet/emulex/benet/be_cmds.h
@@ -2381,7 +2381,6 @@ struct be_cmd_req_manage_iface_filters {
 } __packed;
 
 u16 be_POST_stage_get(struct be_adapter *adapter);
-int be_pci_fnum_get(struct be_adapter *adapter);
 int be_fw_wait_ready(struct be_adapter *adapter);
 int be_cmd_mac_addr_query(struct be_adapter *adapter, u8 *mac_addr,
 			  bool permanent, u32 if_handle, u32 pmac_id);
@@ -2406,7 +2405,6 @@ int be_cmd_q_destroy(struct be_adapter *adapter, struct be_queue_info *q,
 int be_cmd_rxq_destroy(struct be_adapter *adapter, struct be_queue_info *q);
 int be_cmd_link_status_query(struct be_adapter *adapter, u16 *link_speed,
 			     u8 *link_status, u32 dom);
-int be_cmd_reset(struct be_adapter *adapter);
 int be_cmd_get_stats(struct be_adapter *adapter, struct be_dma_mem *nonemb_cmd);
 int lancer_cmd_get_pport_stats(struct be_adapter *adapter,
 			       struct be_dma_mem *nonemb_cmd);
@@ -2488,7 +2486,6 @@ int lancer_physdev_ctrl(struct be_adapter *adapter, u32 mask);
 int lancer_initiate_dump(struct be_adapter *adapter);
 int lancer_delete_dump(struct be_adapter *adapter);
 bool dump_present(struct be_adapter *adapter);
-int lancer_test_and_set_rdy_state(struct be_adapter *adapter);
 int be_cmd_query_port_name(struct be_adapter *adapter);
 int be_cmd_get_func_config(struct be_adapter *adapter,
 			   struct be_resources *res);
-- 
2.34.1

Re: [PATCH net-next] be2net: Remove unused declarations

[Simon Horman]

On Mon, Sep 02, 2024 at 07:32:38PM +0800, Yue Haibing wrote:
> Commit 6b7c5b947c67 ("net: Add be2net driver.") declared be_pci_fnum_get()
> and be_cmd_reset() but never implemented. And commit 9fa465c0ce0d ("be2net:
> remove code duplication relating to Lancer reset sequence") removed
> lancer_test_and_set_rdy_state() but leave declaration.
> 
> Commit 76a9e08e33ce ("be2net: cleanup wake-on-lan code") left behind
> be_is_wol_supported() declaration.
> Commit baaa08d148ac ("be2net: do not call be_set/get_fw_log_level() on
> Skyhawk-R") removed be_get_fw_log_level() but leave declaration.
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>

Thanks, I agree with your analysis.

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [PATCH net-next] be2net: Remove unused declarations

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 2 Sep 2024 19:32:38 +0800 you wrote:
> Commit 6b7c5b947c67 ("net: Add be2net driver.") declared be_pci_fnum_get()
> and be_cmd_reset() but never implemented. And commit 9fa465c0ce0d ("be2net:
> remove code duplication relating to Lancer reset sequence") removed
> lancer_test_and_set_rdy_state() but leave declaration.
> 
> Commit 76a9e08e33ce ("be2net: cleanup wake-on-lan code") left behind
> be_is_wol_supported() declaration.
> Commit baaa08d148ac ("be2net: do not call be_set/get_fw_log_level() on
> Skyhawk-R") removed be_get_fw_log_level() but leave declaration.
> 
> [...]

Here is the summary with links:
  - [net-next] be2net: Remove unused declarations
    https://git.kernel.org/netdev/net-next/c/3d4d0fa4fc32

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html